Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username template #1103

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Add username template #1103

merged 5 commits into from
Aug 25, 2021

Conversation

DesmondH0
Copy link
Contributor

Adding username_template support in vault_database_secret_backend_connection

Question to community:

  • Currently only tested with Postgres, and not sure if the username_template should stay in connectionStringResource schema or not, since I don't have db like oracle which is not supporting the username_template to test with.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #1030

Release note for CHANGELOG:

Add username_template to vault_database_secret_backend_connection

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccXXX -timeout 120m
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/codegen	0.025s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	0.033s [no tests to run]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	0.030s [no tests to run]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	0.034s [no tests to run]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	0.035s [no tests to run]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	0.035s [no tests to run]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	0.027s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/util	0.037s [no tests to run]
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.

testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	0.030s [no tests to run]
...

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@abbasalizaidi
Copy link

abbasalizaidi commented Jul 26, 2021 •
edited
Loading

I want this to be merged! Vault already has support for this.

hashicorp/vault#8063

@angeloskaltsikis
Copy link

Hey,
It would be great if we could merge this (it already has 22 👍🏽 ) & release a new version of the provider, as it is currently blocking us from continuing with Vault & MySQL authentication (due to long usernames by default :).

@vinay-gopalan vinay-gopalan self-assigned this Aug 23, 2021
vinay-gopalan
vinay-gopalan requested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

vault/resource_database_secret_backend_connection.go Show resolved Hide resolved
@DesmondH0 DesmondH0 force-pushed the add_username_template branch from afb4d10 to 2d3234b Compare August 25, 2021 08:58
@DesmondH0 DesmondH0 changed the title Add username template [WIP] Add username template Aug 25, 2021
@DesmondH0 DesmondH0 changed the title [WIP] Add username template Add username template Aug 25, 2021
vinay-gopalan
vinay-gopalan requested changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your response! Sorry for the additional changes, but I think this might be a better way to go when I think more about it

vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
vinay-gopalan
vinay-gopalan approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@vinay-gopalan vinay-gopalan merged commit 2f072b1 into hashicorp:master Aug 25, 2021
@iniinikoski iniinikoski mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@benashz benashz benashz left review comments

Assignees

@vinay-gopalan vinay-gopalan

Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: username_template in vault_database_secret_backend_connection, from vault 1.7
6 participants
@DesmondH0 @hashicorp-cla @abbasalizaidi @angeloskaltsikis @benashz @vinay-gopalan