Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Listener Attributes for Application Load Balancer #40736

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

oliverjfletcher
Copy link
Contributor

Description

Adding support for Listener Attributes for HTTP and HTTPS listeners for Application Load Balancer

Relations

Closes #40269

References

Output from Acceptance Testing

terraform-provider-aws git:(f-elb-listener-attribute) ✗ make testacc TESTS=TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders PKG=elbv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders'  -timeout 360m
2024/12/31 13:01:00 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders
=== PAUSE TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders
=== CONT  TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders
--- PASS: TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders (277.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      277.673sterraform-provider-aws git:(f-elb-listener-attribute) ✗ make testacc TESTS=TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders PKG=elbv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders'  -timeout 360m
2024/12/31 13:14:16 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders
=== PAUSE TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders
=== CONT  TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders
--- PASS: TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders (301.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      301.222s
...

@oliverjfletcher oliverjfletcher requested a review from a team as a code owner December 31, 2024 13:14
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. labels Dec 31, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @oliverjfletcher 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 31, 2024
@JacobWeyer
Copy link

We were just looking for how this was supported in Terraform and stumbled onto this here; would love to see it get a proper review

@ewbankkit ewbankkit self-assigned this Jan 12, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 12, 2025
ewbankkit
ewbankkit previously approved these changes Jan 13, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2Listener_' PKG=elbv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2Listener_ -timeout 360m -vet=off
2025/01/12 17:33:07 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2Listener_tags
=== PAUSE TestAccELBV2Listener_tags
=== RUN   TestAccELBV2Listener_tags_null
=== PAUSE TestAccELBV2Listener_tags_null
=== RUN   TestAccELBV2Listener_tags_EmptyMap
=== PAUSE TestAccELBV2Listener_tags_EmptyMap
=== RUN   TestAccELBV2Listener_tags_AddOnUpdate
=== PAUSE TestAccELBV2Listener_tags_AddOnUpdate
=== RUN   TestAccELBV2Listener_tags_EmptyTag_OnCreate
=== PAUSE TestAccELBV2Listener_tags_EmptyTag_OnCreate
=== RUN   TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccELBV2Listener_tags_DefaultTags_providerOnly
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_providerOnly
=== RUN   TestAccELBV2Listener_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_nonOverlapping
=== RUN   TestAccELBV2Listener_tags_DefaultTags_overlapping
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_overlapping
=== RUN   TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccELBV2Listener_tags_ComputedTag_OnCreate
=== PAUSE TestAccELBV2Listener_tags_ComputedTag_OnCreate
=== RUN   TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccELBV2Listener_Application_basic
=== PAUSE TestAccELBV2Listener_Application_basic
=== RUN   TestAccELBV2Listener_Network_basic
=== PAUSE TestAccELBV2Listener_Network_basic
=== RUN   TestAccELBV2Listener_Gateway_basic
=== PAUSE TestAccELBV2Listener_Gateway_basic
=== RUN   TestAccELBV2Listener_disappears
=== PAUSE TestAccELBV2Listener_disappears
=== RUN   TestAccELBV2Listener_Forward_update
=== PAUSE TestAccELBV2Listener_Forward_update
=== RUN   TestAccELBV2Listener_Forward_ingest
=== PAUSE TestAccELBV2Listener_Forward_ingest
=== RUN   TestAccELBV2Listener_Forward_weighted
=== PAUSE TestAccELBV2Listener_Forward_weighted
=== RUN   TestAccELBV2Listener_Forward_tgARNAndForward
=== PAUSE TestAccELBV2Listener_Forward_tgARNAndForward
=== RUN   TestAccELBV2Listener_Forward_TGARNToForward_noChanges
=== PAUSE TestAccELBV2Listener_Forward_TGARNToForward_noChanges
=== RUN   TestAccELBV2Listener_Forward_addStickiness
=== PAUSE TestAccELBV2Listener_Forward_addStickiness
=== RUN   TestAccELBV2Listener_Forward_removeStickiness
=== PAUSE TestAccELBV2Listener_Forward_removeStickiness
=== RUN   TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness
=== PAUSE TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness
=== RUN   TestAccELBV2Listener_Forward_ToTGARN_noChanges
=== PAUSE TestAccELBV2Listener_Forward_ToTGARN_noChanges
=== RUN   TestAccELBV2Listener_Forward_ToTGARN_weightStickiness
=== PAUSE TestAccELBV2Listener_Forward_ToTGARN_weightStickiness
=== RUN   TestAccELBV2Listener_Forward_addAction
=== PAUSE TestAccELBV2Listener_Forward_addAction
=== RUN   TestAccELBV2Listener_Forward_removeAction
=== PAUSE TestAccELBV2Listener_Forward_removeAction
=== RUN   TestAccELBV2Listener_Forward_ignoreFields
=== PAUSE TestAccELBV2Listener_Forward_ignoreFields
=== RUN   TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== RUN   TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== RUN   TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders
=== PAUSE TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders
=== RUN   TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders
=== PAUSE TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders
=== RUN   TestAccELBV2Listener_Protocol_upd
=== PAUSE TestAccELBV2Listener_Protocol_upd
=== RUN   TestAccELBV2Listener_backwardsCompatibility
=== PAUSE TestAccELBV2Listener_backwardsCompatibility
=== RUN   TestAccELBV2Listener_Protocol_https
=== PAUSE TestAccELBV2Listener_Protocol_https
=== RUN   TestAccELBV2Listener_mutualAuthentication
=== PAUSE TestAccELBV2Listener_mutualAuthentication
=== RUN   TestAccELBV2Listener_mutualAuthenticationPassthrough
=== PAUSE TestAccELBV2Listener_mutualAuthenticationPassthrough
=== RUN   TestAccELBV2Listener_mutualAuthenticationAdvertiseCASubject
=== PAUSE TestAccELBV2Listener_mutualAuthenticationAdvertiseCASubject
=== RUN   TestAccELBV2Listener_Gateway_lbARN
=== PAUSE TestAccELBV2Listener_Gateway_lbARN
=== RUN   TestAccELBV2Listener_Protocol_tls
=== PAUSE TestAccELBV2Listener_Protocol_tls
=== RUN   TestAccELBV2Listener_redirect
=== PAUSE TestAccELBV2Listener_redirect
=== RUN   TestAccELBV2Listener_fixedResponse
=== PAUSE TestAccELBV2Listener_fixedResponse
=== RUN   TestAccELBV2Listener_cognito
=== PAUSE TestAccELBV2Listener_cognito
=== RUN   TestAccELBV2Listener_oidc
=== PAUSE TestAccELBV2Listener_oidc
=== RUN   TestAccELBV2Listener_DefaultAction_defaultOrder
=== PAUSE TestAccELBV2Listener_DefaultAction_defaultOrder
=== RUN   TestAccELBV2Listener_DefaultAction_specifyOrder
=== PAUSE TestAccELBV2Listener_DefaultAction_specifyOrder
=== RUN   TestAccELBV2Listener_DefaultAction_actionDisappears
=== PAUSE TestAccELBV2Listener_DefaultAction_actionDisappears
=== RUN   TestAccELBV2Listener_DefaultAction_empty
=== PAUSE TestAccELBV2Listener_DefaultAction_empty
=== RUN   TestAccELBV2Listener_redirectWithTargetGroupARN
=== PAUSE TestAccELBV2Listener_redirectWithTargetGroupARN
=== CONT  TestAccELBV2Listener_tags
=== CONT  TestAccELBV2Listener_Forward_addStickiness
=== CONT  TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag (220.08s)
=== CONT  TestAccELBV2Listener_mutualAuthentication
--- PASS: TestAccELBV2Listener_Forward_addStickiness (244.67s)
=== CONT  TestAccELBV2Listener_redirectWithTargetGroupARN
--- PASS: TestAccELBV2Listener_tags (292.60s)
=== CONT  TestAccELBV2Listener_DefaultAction_empty
=== RUN   TestAccELBV2Listener_DefaultAction_empty/redirect
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/redirect
=== RUN   TestAccELBV2Listener_DefaultAction_empty/fixed-response
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/fixed-response
=== RUN   TestAccELBV2Listener_DefaultAction_empty/forward
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/forward
=== RUN   TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc
=== RUN   TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito
=== CONT  TestAccELBV2Listener_DefaultAction_actionDisappears
--- PASS: TestAccELBV2Listener_mutualAuthentication (237.94s)
=== CONT  TestAccELBV2Listener_DefaultAction_specifyOrder
--- PASS: TestAccELBV2Listener_redirectWithTargetGroupARN (263.79s)
=== CONT  TestAccELBV2Listener_DefaultAction_defaultOrder
--- PASS: TestAccELBV2Listener_DefaultAction_actionDisappears (220.28s)
=== CONT  TestAccELBV2Listener_oidc
--- PASS: TestAccELBV2Listener_DefaultAction_specifyOrder (219.84s)
=== CONT  TestAccELBV2Listener_Gateway_basic
--- PASS: TestAccELBV2Listener_DefaultAction_defaultOrder (228.06s)
=== CONT  TestAccELBV2Listener_Forward_TGARNToForward_noChanges
--- PASS: TestAccELBV2Listener_oidc (237.81s)
=== CONT  TestAccELBV2Listener_Forward_tgARNAndForward
--- PASS: TestAccELBV2Listener_Gateway_lbARN (173.76s)
=== CONT  TestAccELBV2Listener_Forward_weighted
--- PASS: TestAccELBV2Listener_Forward_tgARNAndForward (217.82s)
=== CONT  TestAccELBV2Listener_Forward_ingest
--- PASS: TestAccELBV2Listener_Forward_TGARNToForward_noChanges (235.94s)
=== CONT  TestAccELBV2Listener_Forward_update
--- PASS: TestAccELBV2Listener_Forward_ingest (112.69s)
=== CONT  TestAccELBV2Listener_disappears
--- PASS: TestAccELBV2Listener_Forward_update (112.39s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_nonOverlapping
--- PASS: TestAccELBV2Listener_Forward_weighted (258.84s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccELBV2Listener_disappears (145.07s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag (128.58s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccELBV2Listener_tags_DefaultTags_nonOverlapping (248.78s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag (193.36s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag (199.84s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_overlapping
--- PASS: TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly (145.40s)
=== CONT  TestAccELBV2Listener_tags_EmptyTag_OnCreate
--- PASS: TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly (144.41s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_providerOnly
--- PASS: TestAccELBV2Listener_tags_DefaultTags_overlapping (199.00s)
=== CONT  TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccELBV2Listener_tags_EmptyTag_OnCreate (226.79s)
=== CONT  TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccELBV2Listener_tags_DefaultTags_providerOnly (278.49s)
=== CONT  TestAccELBV2Listener_cognito
--- PASS: TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace (220.66s)
=== CONT  TestAccELBV2Listener_tags_EmptyMap
--- PASS: TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add (157.57s)
=== CONT  TestAccELBV2Listener_fixedResponse
--- PASS: TestAccELBV2Listener_fixedResponse (118.85s)
=== CONT  TestAccELBV2Listener_Network_basic
--- PASS: TestAccELBV2Listener_tags_EmptyMap (144.72s)
=== CONT  TestAccELBV2Listener_redirect
--- PASS: TestAccELBV2Listener_cognito (167.57s)
=== CONT  TestAccELBV2Listener_Application_basic
--- PASS: TestAccELBV2Listener_redirect (128.02s)
=== CONT  TestAccELBV2Listener_Protocol_tls
--- PASS: TestAccELBV2Listener_Application_basic (237.15s)
=== CONT  TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccELBV2Listener_Network_basic (224.25s)
=== CONT  TestAccELBV2Listener_Gateway_lbARN
--- PASS: TestAccELBV2Listener_Gateway_basic (191.50s)
=== CONT  TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
--- PASS: TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag (166.56s)
=== CONT  TestAccELBV2Listener_mutualAuthenticationAdvertiseCASubject
--- PASS: TestAccELBV2Listener_Protocol_tls (233.51s)
=== CONT  TestAccELBV2Listener_Protocol_https
--- PASS: TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds (171.42s)
=== CONT  TestAccELBV2Listener_backwardsCompatibility
--- PASS: TestAccELBV2Listener_mutualAuthenticationAdvertiseCASubject (126.60s)
=== CONT  TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccELBV2Listener_backwardsCompatibility (137.09s)
=== CONT  TestAccELBV2Listener_Protocol_upd
--- PASS: TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add (135.60s)
=== CONT  TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccELBV2Listener_Protocol_https (208.80s)
=== CONT  TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders
--- PASS: TestAccELBV2Listener_Protocol_upd (242.12s)
=== CONT  TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders
--- PASS: TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace (235.18s)
=== CONT  TestAccELBV2Listener_mutualAuthenticationPassthrough
--- PASS: TestAccELBV2Listener_attributes_alb_HTTPSRequestHeaders (227.31s)
=== CONT  TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
--- PASS: TestAccELBV2Listener_attributes_alb_HTTPRequestHeaders (158.38s)
=== CONT  TestAccELBV2Listener_tags_AddOnUpdate
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (158.46s)
=== CONT  TestAccELBV2Listener_tags_null
--- PASS: TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds (189.17s)
=== CONT  TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccELBV2Listener_tags_null (144.40s)
=== CONT  TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness
--- PASS: TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag (121.84s)
=== CONT  TestAccELBV2Listener_Forward_removeStickiness
--- PASS: TestAccELBV2Listener_tags_AddOnUpdate (167.79s)
=== CONT  TestAccELBV2Listener_Forward_ToTGARN_noChanges
--- PASS: TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness (235.31s)
=== CONT  TestAccELBV2Listener_Forward_addAction
--- PASS: TestAccELBV2Listener_Forward_ToTGARN_noChanges (245.80s)
=== CONT  TestAccELBV2Listener_Forward_removeAction
--- PASS: TestAccELBV2Listener_Forward_removeStickiness (265.54s)
=== CONT  TestAccELBV2Listener_Forward_ignoreFields
--- PASS: TestAccELBV2Listener_Forward_ignoreFields (117.03s)
=== CONT  TestAccELBV2Listener_tags_ComputedTag_OnCreate
--- PASS: TestAccELBV2Listener_Forward_addAction (164.77s)
=== CONT  TestAccELBV2Listener_Forward_ToTGARN_weightStickiness
--- PASS: TestAccELBV2Listener_Forward_removeAction (134.60s)
=== CONT  TestAccELBV2Listener_DefaultAction_empty/redirect
=== CONT  TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc
=== CONT  TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito
=== CONT  TestAccELBV2Listener_DefaultAction_empty/forward
=== CONT  TestAccELBV2Listener_DefaultAction_empty/fixed-response
--- PASS: TestAccELBV2Listener_DefaultAction_empty (0.00s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/redirect (1.61s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc (1.56s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito (1.58s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/forward (1.61s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/fixed-response (1.62s)
--- PASS: TestAccELBV2Listener_tags_ComputedTag_OnCreate (141.36s)
--- PASS: TestAccELBV2Listener_Forward_ToTGARN_weightStickiness (143.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	3643.983s

jar-b
jar-b previously approved these changes Jan 13, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit dismissed stale reviews from jar-b and themself via 2731ef8 January 13, 2025 16:48
@ewbankkit
Copy link
Contributor

@oliverjfletcher Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c749d82 into hashicorp:main Jan 13, 2025
43 checks passed
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 13, 2025
@oliverjfletcher oliverjfletcher deleted the f-elb-listener-attribute branch January 14, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_lb_listener: HTTP header modifications
4 participants