Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stage-Level Rollback for CodePipeline #37245

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Stage-Level Rollback for CodePipeline #37245

wants to merge 3 commits into from

Conversation

mw-root
Copy link

@mw-root mw-root commented May 3, 2024 •
edited by justinretzolk
Loading

Description

Closes #37244

This is a fairly straight-forward change to enable the new Stage-Level Rollback Option (links are in the issue)

Tests

I have added to the TestAccCodePipeline_pipelinetype test. The test will now set and remove the flag and validate the setting.

$ make testacc TESTS=TestAccCodePipeline_pipelinetype PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run='TestAccCodePipeline_pipelinetype'  -timeout 360m
=== RUN   TestAccCodePipeline_pipelinetype
=== PAUSE TestAccCodePipeline_pipelinetype
=== CONT  TestAccCodePipeline_pipelinetype
--- PASS: TestAccCodePipeline_pipelinetype (82.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	88.823s

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codepipeline Issues and PRs that pertain to the codepipeline service. labels May 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 3, 2024
github-actions[bot]
github-actions bot reviewed May 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mw-root 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2024
@mw-root
Copy link
Author

mw-root commented May 22, 2024

Hi, could I get some 👀 on this one? It's a super minor change but it would be nice to have.

@mw-root mw-root mentioned this pull request Sep 13, 2024
Open
mw-root
mw-root commented Dec 19, 2024
View reviewed changes
Copy link
Author

@mw-root mw-root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I please get a review of this change?

@justinretzolk justinretzolk mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@KnabItPlatform KnabItPlatform KnabItPlatform approved these changes

@dennismdejong dennismdejong dennismdejong approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Enable New Feature: Stage Level Rollback
4 participants
@mw-root @dennismdejong @KnabItPlatform @justinretzolk