Add aws_cognito_user resource #19919

rtim75 · 2021-06-22T13:47:15Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

make testacc PKG_NAME=internal/service/cognitoidp TESTARGS='-run=TestAccCognitoUser'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run=TestAccCognitoUser -timeout 180m
=== RUN   TestAccCognitoUser_basic
=== PAUSE TestAccCognitoUser_basic
=== RUN   TestAccCognitoUser_disappears
=== PAUSE TestAccCognitoUser_disappears
=== RUN   TestAccCognitoUser_temporaryPassword
=== PAUSE TestAccCognitoUser_temporaryPassword
=== RUN   TestAccCognitoUser_password
=== PAUSE TestAccCognitoUser_password
=== RUN   TestAccCognitoUser_attributes
=== PAUSE TestAccCognitoUser_attributes
=== RUN   TestAccCognitoUser_enabled
=== PAUSE TestAccCognitoUser_enabled
=== CONT  TestAccCognitoUser_basic
=== CONT  TestAccCognitoUser_attributes
=== CONT  TestAccCognitoUser_password
=== CONT  TestAccCognitoUser_disappears
=== CONT  TestAccCognitoUser_enabled
=== CONT  TestAccCognitoUser_temporaryPassword
--- PASS: TestAccCognitoUser_disappears (51.18s)
--- PASS: TestAccCognitoUser_basic (61.03s)
--- PASS: TestAccCognitoUser_enabled (99.19s)
--- PASS: TestAccCognitoUser_attributes (99.97s)
--- PASS: TestAccCognitoUser_temporaryPassword (137.58s)
--- PASS: TestAccCognitoUser_password (138.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 140.789s

Only user-attributes are currently supported

aws/resource_aws_cognito_user.go

github-actions

Welcome @rtim75 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

rtim75 · 2021-06-22T13:54:37Z

Another thing I'm not sure about is client_metadata attribute in the inputs.

I'm thinking about adding it with ForceNew attribute.

aws/resource_aws_cognito_user.go

tomelliot16 · 2021-08-30T22:13:36Z

Any status update on this?

rtim75 · 2021-09-03T21:45:46Z

Any status update on this?

Hey, as you probably have noticed I've been working very slowly on this one. I will try to finish at least the main resource(aws_cognito_user) in the near future. From there things should go quicker.

aws/provider.go

Renamed resource to aws_cognito_user_pool_user PR: hashicorp#19919 Issue: hashicorp#4542

aws/resource_aws_cognito_user.go

rtim75 · 2021-10-12T20:33:42Z

TODO:

User password
MFA Preferences
~~User settings~~ the action in the link is deprecated
Handle custom user attributes to allow not specifying custom: prefix (cognitoUserPoolSchemaAttributeMatchesStandardAttribute in aws_cognito_user_pool)
~~Data source~~ if it should be implemented, a separate PR might be the better option, I think
Acceptance tests
Documentation

aws/resource_aws_cognito_user.go

pjroth · 2021-10-13T15:49:49Z

@rtim75 in case you were unaware, it looks like updating the changelog is required per PR guidelines changelog process. Just in case you were unaware of this I wanted to point it out since I didn't see it explicitly on the TODO list.

Thanks for all your work on this!

aws/resource_aws_cognito_user.go

gdavison · 2021-12-09T23:51:08Z

Testing of the client-side arguments can get challenging, since many of them are handled by a Lambda function that's a part of an authentication/authorization system, and it could be implementation-dependent. For the most part, we rely on the AWS API catching major errors.

For implementation in Terraform, in general we try to match the AWS API structures. Sometimes this can end up looking a little strange, like the MFA information. However, it makes dealing with changes on the AWS side easier, for example if they added another MFA contact method, they could just add an item to the list, instead of needing to add another Boolean parameter.

gdavison · 2021-12-09T23:53:19Z

For the timestamp fields, I would include them for consistency with the other resources.

This ensures that the attributes array is fully saved in state while suppressing changes to delete the "sub" attribute, which all cognito users have.

internal/service/cognitoidp/user.go

rtim75 · 2022-01-20T13:17:45Z

@gdavison The PR is ready for the second review. All the discussions have been resolved. The only failing action is caused by resources unrelated to this PR.

cemo · 2022-02-02T19:40:00Z

Gentle ping @gdavison :) We desperately need this PR

gdavison

Looks good! 🚀

--- PASS: TestAccCognitoUser_disappears (40.50s)
--- PASS: TestAccCognitoUser_basic (46.74s)
--- PASS: TestAccCognitoUser_enabled (68.43s)
--- PASS: TestAccCognitoUser_attributes (69.27s)
--- PASS: TestAccCognitoUser_password (86.09s)
--- PASS: TestAccCognitoUser_temporaryPassword (86.16s)

pjroth · 2022-02-03T03:01:30Z

Thanks so much @rtim75 for adding this! I'm looking forward to being able to use this soon!

github-actions · 2022-02-10T18:14:29Z

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-20T02:32:37Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Add aws_cognito_user

a76b8d4

Only user-attributes are currently supported

github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/cognito size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 22, 2021

rtim75 commented Jun 22, 2021

View reviewed changes

aws/resource_aws_cognito_user.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jun 22, 2021

View reviewed changes

rtim75 commented Jun 22, 2021

View reviewed changes

aws/resource_aws_cognito_user.go Outdated Show resolved Hide resolved

rtim75 added 2 commits June 22, 2021 17:22

make attribute value sensitive

35407fb

add desiredDeliveryMediums and enabled

cbd1393

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 14, 2021

breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2021

pjroth reviewed Oct 11, 2021

View reviewed changes

aws/provider.go Outdated Show resolved Hide resolved

pjroth pushed a commit to pjroth/terraform-provider-aws that referenced this pull request Oct 11, 2021

Copied code from PR hashicorp#19919 from user rtim75

e650516

Renamed resource to aws_cognito_user_pool_user PR: hashicorp#19919 Issue: hashicorp#4542

Add client_metadata, force_alias_creation and message_action

d9a7743

rtim75 force-pushed the f-aws_cognito_user branch from ea30815 to d9a7743 Compare October 12, 2021 19:47

rtim75 commented Oct 12, 2021

View reviewed changes

aws/resource_aws_cognito_user.go Outdated Show resolved Hide resolved

add validation data

9b3abf4

Add temporary and permanent passwords

7284b8a

pjroth reviewed Oct 13, 2021

View reviewed changes

aws/resource_aws_cognito_user.go Outdated Show resolved Hide resolved

pjroth reviewed Oct 13, 2021

View reviewed changes

aws/resource_aws_cognito_user.go Outdated Show resolved Hide resolved

pjroth reviewed Oct 13, 2021

View reviewed changes

aws/resource_aws_cognito_user.go Outdated Show resolved Hide resolved

github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 9, 2021

PR fixes: refactoring

1952176

rtim75 force-pushed the f-aws_cognito_user branch from 7ac1886 to 1952176 Compare December 14, 2021 15:03

rtim75 added 3 commits December 14, 2021 18:26

Add DiffSupressFunc to the attributes field

78517ae

This ensures that the attributes array is fully saved in state while suppressing changes to delete the "sub" attribute, which all cognito users have.

adjust phrasing in docs

9f4186a

include ClientMetadata in UpdateUserAttributes

66c3adf

rtim75 commented Dec 14, 2021

View reviewed changes

internal/service/cognitoidp/user.go Show resolved Hide resolved

rtim75 requested a review from gdavison December 15, 2021 08:42

rtim75 added 4 commits December 22, 2021 17:07

fix error message using not yet existing id

321746d

apply terrafmt

448c756

fix attributes section in docs

baa486a

remove extraneous pointer conversions

7013e9f

TommasoBianchi mentioned this pull request Jan 17, 2022

Add aws_cognito_user resource #4542

Closed

rtim75 added 3 commits January 20, 2022 13:31

small logging refactor

8a2cce1

add a note about passwords clearing

8b4db9d

Remove dev debug log message

1688fb7

Merge main

538e1c1

gdavison approved these changes Feb 2, 2022

View reviewed changes

gdavison merged commit de950a3 into hashicorp:main Feb 2, 2022

github-actions bot modified the milestones: Roadmap, v4.0.0 Feb 2, 2022

cemo mentioned this pull request Mar 1, 2022

Add aws_cognito_user_to_group #23442

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aws_cognito_user resource #19919

Add aws_cognito_user resource #19919

rtim75 commented Jun 22, 2021 •

edited

Loading

github-actions bot left a comment

rtim75 commented Jun 22, 2021

tomelliot16 commented Aug 30, 2021

rtim75 commented Sep 3, 2021

rtim75 commented Oct 12, 2021 •

edited

Loading

pjroth commented Oct 13, 2021

gdavison commented Dec 9, 2021

gdavison commented Dec 9, 2021

rtim75 commented Jan 20, 2022

cemo commented Feb 2, 2022

gdavison left a comment

pjroth commented Feb 3, 2022

github-actions bot commented Feb 10, 2022

github-actions bot commented May 20, 2022

Add aws_cognito_user resource #19919

Add aws_cognito_user resource #19919

Conversation

rtim75 commented Jun 22, 2021 • edited Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

rtim75 commented Jun 22, 2021

tomelliot16 commented Aug 30, 2021

rtim75 commented Sep 3, 2021

rtim75 commented Oct 12, 2021 • edited Loading

pjroth commented Oct 13, 2021

gdavison commented Dec 9, 2021

gdavison commented Dec 9, 2021

rtim75 commented Jan 20, 2022

cemo commented Feb 2, 2022

gdavison left a comment

Choose a reason for hiding this comment

pjroth commented Feb 3, 2022

github-actions bot commented Feb 10, 2022

github-actions bot commented May 20, 2022

rtim75 commented Jun 22, 2021 •

edited

Loading

rtim75 commented Oct 12, 2021 •

edited

Loading