Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: Ensure bill-rich gets maintainer treatment in conditionals #17983

Merged
merged 1 commit into from
Mar 8, 2021
Merged

workflows: Ensure bill-rich gets maintainer treatment in conditionals #17983

merged 1 commit into from
Mar 8, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 8, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing: N/A (CI)

@bflad bflad requested a review from a team as a code owner March 8, 2021 18:58
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 8, 2021
@gdavison
Copy link
Contributor

gdavison commented Mar 8, 2021

Could we have a single source of truth for the maintainer list that gets read by these actions?

@bflad
Copy link
Contributor Author

bflad commented Mar 8, 2021

@gdavison most likely! If the collaborator information is still not accessible in workflows, it just might need some additional complexity of checking out the repository so a file can be read, then getting that output in a conditional compatible way. Created followup issue: #17986

breathingdust
breathingdust approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bflad bflad merged commit b430579 into main Mar 8, 2021
@bflad bflad deleted the td-workflows-bill-rich branch March 8, 2021 21:46
@github-actions github-actions bot added this to the v3.32.0 milestone Mar 8, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @gdavison @breathingdust