Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapted validatePrincipal to all allowed lakeformation principals types, solves #16848 #16916

Merged
merged 10 commits into from
Apr 29, 2021
Merged

adapted validatePrincipal to all allowed lakeformation principals types, solves #16848 #16916

merged 10 commits into from
Apr 29, 2021

Conversation

chrisbulgaria
Copy link
Contributor

@chrisbulgaria chrisbulgaria commented Dec 28, 2020 •
edited by YakDriver
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16848
Closes #18034
Closes #18374

Release note for CHANGELOG:

In aws_lakeformation_permissions all principal types (including SAML/AD, QuickSight and other accounts) are now suported

Output from acceptance testing:

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLakeFormation_serial/Permissions -timeout 120m
=== RUN   TestAccAWSLakeFormation_serial
=== RUN   TestAccAWSLakeFormation_serial/Permissions
=== RUN   TestAccAWSLakeFormation_serial/Permissions/tableDataSource
=== RUN   TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsDataSource
=== RUN   TestAccAWSLakeFormation_serial/Permissions/dataLocation
=== RUN   TestAccAWSLakeFormation_serial/Permissions/database
=== RUN   TestAccAWSLakeFormation_serial/Permissions/dataLocationDataSource
=== RUN   TestAccAWSLakeFormation_serial/Permissions/basicDataSource
=== RUN   TestAccAWSLakeFormation_serial/Permissions/databaseDataSource
=== RUN   TestAccAWSLakeFormation_serial/Permissions/basic
=== RUN   TestAccAWSLakeFormation_serial/Permissions/table
=== RUN   TestAccAWSLakeFormation_serial/Permissions/tableWithColumns
--- PASS: TestAccAWSLakeFormation_serial (285.31s)
    --- PASS: TestAccAWSLakeFormation_serial/Permissions (285.31s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableDataSource (28.05s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsDataSource (26.45s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (23.90s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (25.68s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocationDataSource (27.67s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basicDataSource (26.45s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/databaseDataSource (25.91s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (32.73s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/table (34.53s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumns (33.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       285.413s
...

@chrisbulgaria chrisbulgaria requested a review from a team as a code owner December 28, 2020 13:21
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 28, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 28, 2020
github-actions[bot]
github-actions bot reviewed Dec 28, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @chrisbulgaria 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Base automatically changed from master to main January 23, 2021 01:00
@YakDriver YakDriver self-assigned this Apr 28, 2021
@YakDriver YakDriver mentioned this pull request Apr 29, 2021
Closed
@YakDriver
Copy link
Member

YakDriver commented Apr 29, 2021 •
edited
Loading

Additional Principals Perm Delete/Revoke
Related #16848 (Issue)
Related #16916
Related #18034 (Issue)
Related #18374		 Related #17633 (Issue)
Related #18446 (Issue)
Related #18505
Related #19063 (Issue)
Related #19064 (Issue)

This was referenced Apr 29, 2021
Closed
Closed
Closed
Merged
Closed
Closed
@YakDriver YakDriver added enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2021
@YakDriver YakDriver mentioned this pull request Apr 29, 2021
Closed
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. labels Apr 29, 2021
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 29, 2021
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 29, 2021
@ghost ghost added size/S Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. labels Apr 29, 2021
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. labels Apr 29, 2021
@YakDriver YakDriver merged commit 46d6e0e into hashicorp:main Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
3 participants
@chrisbulgaria @YakDriver @kampka