Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_route_table: Refactor acceptance test configuration generator so as avoid 'terrafmt' linting exclusion #16735

Merged
merged 2 commits into from
Dec 14, 2020
Merged

r/aws_route_table: Refactor acceptance test configuration generator so as avoid 'terrafmt' linting exclusion #16735

merged 2 commits into from
Dec 14, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 12, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14013.

Addresses this review comment by refactoring (and as a side effect simplifying) testAccAWSRouteTableConfigMultipleRoutes() so that aws_route_table_test.go no longer needs to be excluded from terrafmt linting.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_MultipleRoutes' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_MultipleRoutes -timeout 120m
=== RUN   TestAccAWSRouteTable_MultipleRoutes
=== PAUSE TestAccAWSRouteTable_MultipleRoutes
=== CONT  TestAccAWSRouteTable_MultipleRoutes
--- PASS: TestAccAWSRouteTable_MultipleRoutes (145.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	145.183s

@ewbankkit
r/aws_route_table: Refactor 'TestAccAWSRouteTable_MultipleRoutes' so …
911e84f 
…that 'resource_aws_route_table_test.go' does not need exclusion from terrafmt linting.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_MultipleRoutes'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_MultipleRoutes -timeout 120m
=== RUN   TestAccAWSRouteTable_MultipleRoutes
=== PAUSE TestAccAWSRouteTable_MultipleRoutes
=== CONT  TestAccAWSRouteTable_MultipleRoutes
--- PASS: TestAccAWSRouteTable_MultipleRoutes (145.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	145.183s
@ewbankkit
No need to exclude 'resource_aws_route_table_test.go' from terrafmt l…
f2c12b1 
…inting.
@ewbankkit ewbankkit requested a review from a team as a code owner December 12, 2020 22:07
@ghost ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 12, 2020
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 12, 2020
This was referenced Dec 12, 2020
Merged
Closed
bflad
bflad approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting this, @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRouteTable_MultipleRoutes (170.00s)

@bflad bflad added this to the v3.22.0 milestone Dec 14, 2020
@bflad bflad merged commit 87bdbf5 into hashicorp:master Dec 14, 2020
@ewbankkit ewbankkit deleted the td-refactor-testAccAWSRouteTableConfigMultipleRoutes-avoiding-terrafmt-exclusion branch December 14, 2020 14:45
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @bflad