Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use patch updates for aws_api_gateway_base_path_mapping where possibl… #16147

Merged
merged 3 commits into from
Jan 13, 2021
Merged

use patch updates for aws_api_gateway_base_path_mapping where possibl… #16147

merged 3 commits into from
Jan 13, 2021

Conversation

matt-mercer
Copy link
Contributor

use patch updates for aws_api_gateway_base_path_mapping where possible, this allows switching the mapped api / stage without destroying and creating the mapping

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

resource/aws_api_gateway_base_path_mapping: Support in-place updates for `stage_name`, `api_id` and `base_path`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayBasePathMapping' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayBasePathMapping -timeout 120m
=== RUN   TestAccAWSAPIGatewayBasePathMapping_basic
=== PAUSE TestAccAWSAPIGatewayBasePathMapping_basic
=== RUN   TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty
=== PAUSE TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty
=== RUN   TestAccAWSAPIGatewayBasePathMapping_updates
=== PAUSE TestAccAWSAPIGatewayBasePathMapping_updates
=== RUN   TestAccAWSAPIGatewayBasePathMapping_disappears
=== PAUSE TestAccAWSAPIGatewayBasePathMapping_disappears
=== CONT  TestAccAWSAPIGatewayBasePathMapping_basic
=== CONT  TestAccAWSAPIGatewayBasePathMapping_disappears
=== CONT  TestAccAWSAPIGatewayBasePathMapping_updates
=== CONT  TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty
--- PASS: TestAccAWSAPIGatewayBasePathMapping_disappears (58.39s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty (115.67s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_basic (192.74s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_updates (268.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	269.489s

...

@matt-mercer matt-mercer requested a review from a team as a code owner November 11, 2020 19:23
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 11, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 11, 2020
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 14, 2020
@matt-mercer
Copy link
Contributor Author

extra checks for rest api id update

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayBasePathMapping_updates -timeout 120m
=== RUN   TestAccAWSAPIGatewayBasePathMapping_updates
=== PAUSE TestAccAWSAPIGatewayBasePathMapping_updates
=== CONT  TestAccAWSAPIGatewayBasePathMapping_updates
--- PASS: TestAccAWSAPIGatewayBasePathMapping_updates (164.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	164.508s

@bflad bflad mentioned this pull request Jan 13, 2021
Closed
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2021
@bflad bflad self-assigned this Jan 13, 2021
@bflad bflad added this to the v3.24.0 milestone Jan 13, 2021
bflad
bflad approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @vurt007 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayBasePathMapping_disappears (20.50s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_updates (89.70s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty (121.17s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_basic (142.49s)

aws/resource_aws_api_gateway_base_path_mapping.go Outdated Show resolved Hide resolved
aws/resource_aws_api_gateway_base_path_mapping.go Outdated Show resolved Hide resolved
aws/resource_aws_api_gateway_base_path_mapping.go Outdated Show resolved Hide resolved
aws/resource_aws_api_gateway_base_path_mapping.go Outdated Show resolved Hide resolved
@bflad bflad merged commit 706406f into hashicorp:master Jan 13, 2021
bflad added a commit that referenced this pull request Jan 13, 2021
@bflad
Update CHANGELOG for #16147
18c862a
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
@matt-mercer matt-mercer deleted the f-aws_api_gateway_base_path_mapping-allow-in-place-updates branch October 4, 2021 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-mercer @bflad