Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_elb & aws_lb: Add desync_mitigation_mode #14764

Merged
merged 12 commits into from
Nov 22, 2021
Merged

aws_elb & aws_lb: Add desync_mitigation_mode #14764

merged 12 commits into from
Nov 22, 2021

Conversation

roberth-k
Copy link
Contributor

@roberth-k roberth-k commented Aug 20, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14696

Release note for CHANGELOG:

ENHANCEMENTS:

data-source/aws_elb: Add `desync_mitigation_mode` attribute
data-source/aws_lb: Add `desync_mitigation_mode` attribute
resource/aws_elb: Add `desync_mitigation_mode` attribute
resource/aws_lb: Add `desync_mitigation_mode` attribute

Output from acceptance testing:

f-lb_desync_mitigation_mode-2 $ make testacc PKG=elbv2 TESTS=TestAccELBV2LoadBalancer_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2 -run='TestAccELBV2LoadBalancer_' -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== RUN   TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== RUN   TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== RUN   TestAccELBV2LoadBalancer_ALB_outpost
=== PAUSE TestAccELBV2LoadBalancer_ALB_outpost
=== RUN   TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== RUN   TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== PAUSE TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== RUN   TestAccELBV2LoadBalancer_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancer_backwardsCompatibility
=== RUN   TestAccELBV2LoadBalancer_generatedName
=== PAUSE TestAccELBV2LoadBalancer_generatedName
=== RUN   TestAccELBV2LoadBalancer_generatesNameForZeroValue
=== PAUSE TestAccELBV2LoadBalancer_generatesNameForZeroValue
=== RUN   TestAccELBV2LoadBalancer_namePrefix
=== PAUSE TestAccELBV2LoadBalancer_namePrefix
=== RUN   TestAccELBV2LoadBalancer_tags
=== PAUSE TestAccELBV2LoadBalancer_tags
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== RUN   TestAccELBV2LoadBalancer_updatedSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_updatedSecurityGroups
=== RUN   TestAccELBV2LoadBalancer_updatedSubnets
=== PAUSE TestAccELBV2LoadBalancer_updatedSubnets
=== RUN   TestAccELBV2LoadBalancer_updatedIPAddressType
=== PAUSE TestAccELBV2LoadBalancer_updatedIPAddressType
=== RUN   TestAccELBV2LoadBalancer_noSecurityGroup
=== PAUSE TestAccELBV2LoadBalancer_noSecurityGroup
=== RUN   TestAccELBV2LoadBalancer_ALB_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_ALB_accessLogs
=== RUN   TestAccELBV2LoadBalancer_ALBAccessLogs_prefix
=== PAUSE TestAccELBV2LoadBalancer_ALBAccessLogs_prefix
=== RUN   TestAccELBV2LoadBalancer_NLB_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_NLB_accessLogs
=== RUN   TestAccELBV2LoadBalancer_NLBAccessLogs_prefix
=== PAUSE TestAccELBV2LoadBalancer_NLBAccessLogs_prefix
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancerSubnet_change
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancerSubnet_change
=== RUN   TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== PAUSE TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (182.23s)
=== CONT  TestAccELBV2LoadBalancer_updateDesyncMitigationMode
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2 (307.58s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancerSubnet_change
--- PASS: TestAccELBV2LoadBalancer_updateDesyncMitigationMode (309.43s)
=== CONT  TestAccELBV2LoadBalancer_NLBAccessLogs_prefix
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancerSubnet_change (485.83s)
=== CONT  TestAccELBV2LoadBalancer_NLB_accessLogs
--- PASS: TestAccELBV2LoadBalancer_NLBAccessLogs_prefix (362.80s)
=== CONT  TestAccELBV2LoadBalancer_ALBAccessLogs_prefix
--- PASS: TestAccELBV2LoadBalancer_ALBAccessLogs_prefix (340.48s)
=== CONT  TestAccELBV2LoadBalancer_NLB_privateIPv4Address
--- PASS: TestAccELBV2LoadBalancer_NLB_accessLogs (418.68s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (241.60s)
=== CONT  TestAccELBV2LoadBalancer_tags
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (323.24s)
=== CONT  TestAccELBV2LoadBalancer_namePrefix
--- PASS: TestAccELBV2LoadBalancer_namePrefix (180.03s)
=== CONT  TestAccELBV2LoadBalancer_ALB_accessLogs
--- PASS: TestAccELBV2LoadBalancer_tags (324.26s)
=== CONT  TestAccELBV2LoadBalancer_noSecurityGroup
--- PASS: TestAccELBV2LoadBalancer_noSecurityGroup (236.71s)
=== CONT  TestAccELBV2LoadBalancer_updatedIPAddressType
--- PASS: TestAccELBV2LoadBalancer_ALB_accessLogs (398.41s)
=== CONT  TestAccELBV2LoadBalancer_updatedSubnets
--- PASS: TestAccELBV2LoadBalancer_updatedIPAddressType (301.62s)
=== CONT  TestAccELBV2LoadBalancer_updatedSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_updatedSubnets (278.37s)
=== CONT  TestAccELBV2LoadBalancer_generatesNameForZeroValue
--- PASS: TestAccELBV2LoadBalancer_updatedSecurityGroups (237.65s)
=== CONT  TestAccELBV2LoadBalancer_generatedName
--- PASS: TestAccELBV2LoadBalancer_generatesNameForZeroValue (237.93s)
=== CONT  TestAccELBV2LoadBalancer_backwardsCompatibility
--- PASS: TestAccELBV2LoadBalancer_generatedName (177.05s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
--- PASS: TestAccELBV2LoadBalancer_backwardsCompatibility (186.58s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection (355.87s)
=== CONT  TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields (296.55s)
=== CONT  TestAccELBV2LoadBalancer_networkLoadBalancerEIP
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing (168.24s)
=== CONT  TestAccELBV2LoadBalancer_ALB_outpost
    acctest.go:1241: skipping acceptance testing: AccessDeniedException: User: arn:aws:iam::868807437771:user/cloud_user is not authorized to perform: outposts:ListOutposts on resource: arn:aws:outposts:us-east-1:868807437771:* with an explicit deny
--- SKIP: TestAccELBV2LoadBalancer_ALB_outpost (0.40s)
=== CONT  TestAccELBV2LoadBalancer_LoadBalancerType_gateway
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (223.42s)
=== CONT  TestAccELBV2LoadBalancer_ipv6SubnetMapping
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (113.67s)
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (207.86s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (234.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      3588.660s

f-lb_desync_mitigation_mode-2 $ make testacc PKG=elbv2 TESTS=TestAccELBV2LoadBalancerDataSource_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2 -run='TestAccELBV2LoadBalancerDataSource_' -timeout 180m
=== RUN   TestAccELBV2LoadBalancerDataSource_basic
=== PAUSE TestAccELBV2LoadBalancerDataSource_basic
=== RUN   TestAccELBV2LoadBalancerDataSource_outpost
=== PAUSE TestAccELBV2LoadBalancerDataSource_outpost
=== RUN   TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== CONT  TestAccELBV2LoadBalancerDataSource_basic
=== CONT  TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (240.44s)
=== CONT  TestAccELBV2LoadBalancerDataSource_outpost
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (240.44s)
=== CONT  TestAccELBV2LoadBalancerDataSource_outpost
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancerDataSource_outpost (0.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      242.559s

f-lb_desync_mitigation_mode-2 $ make testacc PKG=elb TESTS=TestAccELBLoadBalancer_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 2 -run='TestAccELBLoadBalancer_' -timeout 180m
=== RUN   TestAccELBLoadBalancer_basic
=== PAUSE TestAccELBLoadBalancer_basic
=== RUN   TestAccELBLoadBalancer_disappears
=== PAUSE TestAccELBLoadBalancer_disappears
=== RUN   TestAccELBLoadBalancer_fullCharacterRange
=== PAUSE TestAccELBLoadBalancer_fullCharacterRange
=== RUN   TestAccELBLoadBalancer_AccessLogs_enabled
=== PAUSE TestAccELBLoadBalancer_AccessLogs_enabled
=== RUN   TestAccELBLoadBalancer_AccessLogs_disabled
=== PAUSE TestAccELBLoadBalancer_AccessLogs_disabled
=== RUN   TestAccELBLoadBalancer_namePrefix
=== PAUSE TestAccELBLoadBalancer_namePrefix
=== RUN   TestAccELBLoadBalancer_generatedName
=== PAUSE TestAccELBLoadBalancer_generatedName
=== RUN   TestAccELBLoadBalancer_generatesNameForZeroValue
=== PAUSE TestAccELBLoadBalancer_generatesNameForZeroValue
=== RUN   TestAccELBLoadBalancer_availabilityZones
=== PAUSE TestAccELBLoadBalancer_availabilityZones
=== RUN   TestAccELBLoadBalancer_tags
=== PAUSE TestAccELBLoadBalancer_tags
=== RUN   TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate
=== PAUSE TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate
=== RUN   TestAccELBLoadBalancer_Swap_subnets
=== PAUSE TestAccELBLoadBalancer_Swap_subnets
=== RUN   TestAccELBLoadBalancer_instanceAttaching
=== PAUSE TestAccELBLoadBalancer_instanceAttaching
=== RUN   TestAccELBLoadBalancer_listener
=== PAUSE TestAccELBLoadBalancer_listener
=== RUN   TestAccELBLoadBalancer_healthCheck
=== PAUSE TestAccELBLoadBalancer_healthCheck
=== RUN   TestAccELBLoadBalancer_timeout
=== PAUSE TestAccELBLoadBalancer_timeout
=== RUN   TestAccELBLoadBalancer_connectionDraining
=== PAUSE TestAccELBLoadBalancer_connectionDraining
=== RUN   TestAccELBLoadBalancer_securityGroups
=== PAUSE TestAccELBLoadBalancer_securityGroups
=== RUN   TestAccELBLoadBalancer_desyncMitigationMode
=== PAUSE TestAccELBLoadBalancer_desyncMitigationMode
=== RUN   TestAccELBLoadBalancer_desyncMitigationMode_update
=== PAUSE TestAccELBLoadBalancer_desyncMitigationMode_update
=== CONT  TestAccELBLoadBalancer_basic
=== CONT  TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate
--- PASS: TestAccELBLoadBalancer_basic (29.02s)
=== CONT  TestAccELBLoadBalancer_healthCheck
--- PASS: TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate (39.55s)
=== CONT  TestAccELBLoadBalancer_listener
--- PASS: TestAccELBLoadBalancer_healthCheck (42.91s)
=== CONT  TestAccELBLoadBalancer_instanceAttaching
--- PASS: TestAccELBLoadBalancer_listener (113.33s)
=== CONT  TestAccELBLoadBalancer_Swap_subnets
--- PASS: TestAccELBLoadBalancer_instanceAttaching (119.17s)
=== CONT  TestAccELBLoadBalancer_desyncMitigationMode
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode (25.65s)
=== CONT  TestAccELBLoadBalancer_desyncMitigationMode_update
--- PASS: TestAccELBLoadBalancer_Swap_subnets (88.10s)
=== CONT  TestAccELBLoadBalancer_timeout
--- PASS: TestAccELBLoadBalancer_timeout (38.79s)
=== CONT  TestAccELBLoadBalancer_securityGroups
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode_update (64.03s)
=== CONT  TestAccELBLoadBalancer_connectionDraining
--- PASS: TestAccELBLoadBalancer_securityGroups (46.21s)
=== CONT  TestAccELBLoadBalancer_namePrefix
--- PASS: TestAccELBLoadBalancer_connectionDraining (56.91s)
=== CONT  TestAccELBLoadBalancer_generatesNameForZeroValue
--- PASS: TestAccELBLoadBalancer_namePrefix (23.08s)
=== CONT  TestAccELBLoadBalancer_generatedName
--- PASS: TestAccELBLoadBalancer_generatesNameForZeroValue (24.05s)
=== CONT  TestAccELBLoadBalancer_tags
--- PASS: TestAccELBLoadBalancer_generatedName (22.82s)
=== CONT  TestAccELBLoadBalancer_AccessLogs_enabled
--- PASS: TestAccELBLoadBalancer_tags (61.75s)
=== CONT  TestAccELBLoadBalancer_availabilityZones
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (74.87s)
=== CONT  TestAccELBLoadBalancer_fullCharacterRange
--- PASS: TestAccELBLoadBalancer_availabilityZones (41.03s)
=== CONT  TestAccELBLoadBalancer_disappears
--- PASS: TestAccELBLoadBalancer_fullCharacterRange (23.95s)
=== CONT  TestAccELBLoadBalancer_AccessLogs_disabled
--- PASS: TestAccELBLoadBalancer_disappears (19.89s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (75.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        548.016s

f-lb_desync_mitigation_mode-2 $ make testacc PKG=elb TESTS=TestAccELBLoadBalancerDataSource_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 2 -run='TestAccELBLoadBalancerDataSource_' -timeout 180m
=== RUN   TestAccELBLoadBalancerDataSource_basic
=== PAUSE TestAccELBLoadBalancerDataSource_basic
=== CONT  TestAccELBLoadBalancerDataSource_basic
--- PASS: TestAccELBLoadBalancerDataSource_basic (55.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        57.333s

@roberth-k roberth-k requested a review from a team August 20, 2020 22:36
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 20, 2020
@roberth-k roberth-k mentioned this pull request Aug 20, 2020
Closed
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@reedloden
Copy link
Contributor

@roberth-k care to rebase to fix the conflicts?

@roberth-k
Copy link
Contributor Author

@reedloden I will rebase and re-run the acceptance tests when maintainers indicate a review is scheduled.

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@breathingdust breathingdust added this to the Roadmap milestone Nov 10, 2021
@roberth-k
Copy link
Contributor Author

Thank you for the heads up @breathingdust -- I'll bring the PR up to date in about a week or so.

@roberth-k roberth-k force-pushed the f-lb_desync_mitigation_mode branch from c4e02e1 to 8b3ce10 Compare November 21, 2021 14:34
@github-actions github-actions bot added the pre-service-packages Includes pre-Service Packages aspects. label Nov 21, 2021
@roberth-k roberth-k force-pushed the f-lb_desync_mitigation_mode branch from 8b3ce10 to 4102fce Compare November 21, 2021 14:36
@github-actions github-actions bot removed the pre-service-packages Includes pre-Service Packages aspects. label Nov 21, 2021
@roberth-k
Copy link
Contributor Author

@breathingdust The PR is now up to date.

@anGie44 anGie44 self-assigned this Nov 22, 2021
anGie44
anGie44 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to this feature @roberth-k ! Looks great 🚀

Output of acceptance tests:

--- PASS: TestAccELBLoadBalancerDataSource_basic (267.08s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (272.24s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (237.63s)
--- PASS: TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate (167.02s)
--- PASS: TestAccELBLoadBalancer_Swap_subnets (123.45s)
--- PASS: TestAccELBLoadBalancer_availabilityZones (268.65s)
--- PASS: TestAccELBLoadBalancer_basic (164.52s)
--- PASS: TestAccELBLoadBalancer_connectionDraining (235.95s)
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode (54.56s)
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode_update (148.25s)
--- PASS: TestAccELBLoadBalancer_disappears (50.11s)
--- PASS: TestAccELBLoadBalancer_fullCharacterRange (140.14s)
--- PASS: TestAccELBLoadBalancer_generatedName (129.21s)
--- PASS: TestAccELBLoadBalancer_generatesNameForZeroValue (49.21s)
--- PASS: TestAccELBLoadBalancer_healthCheck (109.48s)
--- PASS: TestAccELBLoadBalancer_instanceAttaching (352.77s)
--- PASS: TestAccELBLoadBalancer_listener (200.02s)
--- PASS: TestAccELBLoadBalancer_namePrefix (188.17s)
--- PASS: TestAccELBLoadBalancer_securityGroups (65.70s)
--- PASS: TestAccELBLoadBalancer_tags (77.89s)
--- PASS: TestAccELBLoadBalancer_timeout (63.51s)

--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (309.91s)
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (581.12s)
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (275.02s)
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (287.13s)
--- PASS: TestAccELBV2LoadBalancer_ALBAccessLogs_prefix (256.76s)
--- PASS: TestAccELBV2LoadBalancer_ALB_accessLogs (358.15s)
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (269.00s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection (334.23s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields (322.18s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2 (387.32s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen (308.26s)
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing (170.66s)
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (250.10s)
--- PASS: TestAccELBV2LoadBalancer_NLBAccessLogs_prefix (346.87s)
--- PASS: TestAccELBV2LoadBalancer_NLB_accessLogs (356.44s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (270.72s)
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (231.39s)
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancerSubnet_change (425.62s)
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (387.87s)
--- PASS: TestAccELBV2LoadBalancer_backwardsCompatibility (309.30s)
--- PASS: TestAccELBV2LoadBalancer_generatedName (256.36s)
--- PASS: TestAccELBV2LoadBalancer_generatesNameForZeroValue (287.00s)
--- PASS: TestAccELBV2LoadBalancer_namePrefix (266.55s)
--- PASS: TestAccELBV2LoadBalancer_noSecurityGroup (167.65s)
--- PASS: TestAccELBV2LoadBalancer_tags (377.94s)
--- PASS: TestAccELBV2LoadBalancer_updateDesyncMitigationMode (322.91s)
--- PASS: TestAccELBV2LoadBalancer_updatedIPAddressType (215.02s)
--- PASS: TestAccELBV2LoadBalancer_updatedSecurityGroups (368.56s)
--- PASS: TestAccELBV2LoadBalancer_updatedSubnets (393.75s)
--- SKIP: TestAccELBV2LoadBalancerDataSource_outpost (1.29s)
--- SKIP: TestAccELBV2LoadBalancer_ALB_outpost (1.14s)

@anGie44 anGie44 modified the milestones: Roadmap, v3.67.0 Nov 22, 2021
@anGie44 anGie44 merged commit c3422bf into hashicorp:main Nov 22, 2021
@anGie44 anGie44 mentioned this pull request Nov 23, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-lb_desync_mitigation_mode branch January 16, 2022 20:23
This was referenced Mar 31, 2022
Closed
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.67.0
Development

Successfully merging this pull request may close these issues.

Support for routing.http.desync_mitigation_mode in ALB/CLB
5 participants
@roberth-k @reedloden @zhelding @breathingdust @anGie44