Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quicksight group membership resource #11160

Closed
wants to merge 7 commits into from
Closed

Add quicksight group membership resource #11160

wants to merge 7 commits into from

Conversation

mjgpy3
Copy link
Contributor

@mjgpy3 mjgpy3 commented Dec 5, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10990

Release note for CHANGELOG:

* **New Resource:** `aws_quicksight_group_membership`

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSQuickSightGroupMembership'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSQuickSightGroupMembership -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSQuickSightGroupMembership_basic
=== PAUSE TestAccAWSQuickSightGroupMembership_basic
=== RUN   TestAccAWSQuickSightGroupMembership_disappears
=== PAUSE TestAccAWSQuickSightGroupMembership_disappears
=== CONT  TestAccAWSQuickSightGroupMembership_basic
=== CONT  TestAccAWSQuickSightGroupMembership_disappears
--- PASS: TestAccAWSQuickSightGroupMembership_disappears (19.05s)
--- PASS: TestAccAWSQuickSightGroupMembership_basic (19.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.932s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.022s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.004s [no tests to run]

mjgpy3 and others added 5 commits October 10, 2019 19:27
@mjgpy3
Add basic resource for QuickSight group memberships.
1d11151
@mjgpy3
Test aws_quicksight_group_membership. The tests fail but...
098957c 
I believe the failure is due to non-determinism/caching in the AWS APIs.
I'm going to sit on this change for a while because I believe AWS is
working on fixing this at the moment.
@mjgpy3
Add doc for quicksight_group_membership.
413ec40
@mjgpy3
Implement importer.
53181c2
@mjgpy3
Remove CheckDestroy since there's now way to get just a group members…
61ca648 
…hip.
@mjgpy3 mjgpy3 requested a review from a team December 5, 2019 18:42
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 5, 2019
@teamterraform
Copy link

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

Base automatically changed from master to main January 23, 2021 00:56
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:56
a11e99 added a commit to a11e99/terraform-provider-candidaws that referenced this pull request Jul 19, 2021
@a11e99
Add AWS QuickSight Group Membership
3536aed 
Cribbed from prior art implementation here:
hashicorp/terraform-provider-aws#11160
troy-brathwaite-cp pushed a commit to candidpartners/terraform-provider-candidaws that referenced this pull request Jul 20, 2021
@a11e99
CFS-7074 - Terraform Provider AWS - QuickSight Integration (#24)
ac4e03f 
* Rectify inconsistent vendoring

Addresses error:
go: inconsistent vendoring in /code:
    github.com/aws/aws-sdk-go@v1.35.8: is explicitly required in
    go.mod, but vendor/modules.txt indicates
    github.com/aws/aws-sdk-go@v1.29.24

        To ignore the vendor directory, use -mod=readonly or -mod=mod.
        To sync the vendor directory, run:
            go mod vendor

* Add AWS QuickSight Group Membership

Cribbed from prior art implementation here:
hashicorp/terraform-provider-aws#11160

* Add AWS QuickSight IAM Policy Assignment

Cribbed from prior art implementation here:
hashicorp/terraform-provider-aws#12279

* Add AWS QuickSight Namespaces
@lacernetic
Copy link
Contributor

@mjgpy3 I'm looking into getting this PR into a state that is ready for merging, would you be able to help me go through with this?

@lacernetic lacernetic mentioned this pull request Aug 25, 2021
Merged
@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 31, 2021
@github-actions github-actions bot added this to the v3.58.0 milestone Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This functionality has been released in v3.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/quicksight Issues and PRs that pertain to the quicksight service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.58.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mjgpy3 @teamterraform @lacernetic @anGie44