Add datasource ssm_parameters_by_path #9615

katainaka0503 · 2019-08-04T02:46:46Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9429.
Closes #11318.

Release note for CHANGELOG:

New Data Source: aws_ssm_parameters_by_path

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSsmParametersByPathDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSsmParametersByPathDataSource_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSsmParametersByPathDataSource_basic
=== PAUSE TestAccAWSSsmParametersByPathDataSource_basic
=== CONT  TestAccAWSSsmParametersByPathDataSource_basic
--- PASS: TestAccAWSSsmParametersByPathDataSource_basic (32.50s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       32.551s

katainaka0503 · 2019-08-04T03:09:04Z

aws/provider.go

@@ -261,6 +261,7 @@ func Provider() terraform.ResourceProvider {
 			"aws_sqs_queue":                                 dataSourceAwsSqsQueue(),
 			"aws_ssm_document":                              dataSourceAwsSsmDocument(),
 			"aws_ssm_parameter":                             dataSourceAwsSsmParameter(),
+			"aws_ssm_parameters_by_path":                    dataSourceAwsSsmParametersByPath(),


I could not determine which naming is better aws_ssm_parameters_by_path or simply aws_ssm_parameters.

IMO aws_ssm_parameters is cleaner but I'd prefer aligning with the aws-cli so aws_ssm_parameters_by_path is the wiser choice.

differentiating this feature and the single parameter only with one trailing "s" sounds like problematic user/developer experience :)

cmeisinger · 2020-02-26T22:33:21Z

Any updates here?

Dgadavin · 2020-05-04T08:12:53Z

Hey guys. This is very useful things. I'm very appreciate any movement in this PR.

DmitriyLyalyuev · 2020-05-04T08:44:17Z

Guys, we need this. Please merge :)

katainaka0503 · 2020-05-07T04:37:28Z

I've rebased and fixed dependency

vlefr · 2020-06-12T09:25:17Z

do you know when should be release please ? It would be very useful feature :)

teamterraform · 2020-08-18T20:04:17Z

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

tsalinguepumpkin · 2020-09-01T08:52:52Z

@katainaka0503 do you know if this gonna be merged ?

katainaka0503 · 2020-09-01T08:56:45Z

@tsalinguepumpkin I don't know how this repo's mainteners wish to deal with this PR at all.

Maybe this PR won't ever be merged, since there is no comment from the mainteners here on this PR.

melvinkcx · 2020-09-14T02:20:02Z

We need this feature too! The workaround I have is utterly ugly RN

maulik-vimond · 2020-10-26T09:03:18Z

Is there any chance that this will be merged any time soon? This is a very useful feature.

itays333 · 2020-10-28T12:51:07Z

Was surprised to find out this feature doesn't exist yet, I need this as well.

theuves · 2020-12-06T18:28:18Z

This is very useful! Merge it, please!!!

tsalinguepumpkin · 2021-01-07T13:51:23Z

any updates on the subject ?

fatbasstard · 2021-04-20T12:23:47Z

Just found this PR since I also "need" this datasource. Any chance this can/will get any support?

@katainaka0503 You're still monitoring this?

katainaka0503 · 2021-04-20T22:27:28Z

Yes. If maintainors are still monitoring this PR, I'm ready to rewrite this PR as it fits current code base.

fatbasstard · 2021-04-26T08:06:08Z

Going to tag some of the recent contibuters: @anGie44 @ewbankkit @bflad

This is feature people want (including myself 😉 ) and @katainaka0503 is willing to finish up the PR. Can this PR get some ❤️ ?

yuklia · 2021-07-04T12:19:52Z

hi! any news? this feature is really great and we all waiting for the release 👍

jbcom · 2021-07-27T17:08:16Z

Is there anything I could do to help with this? Right now the approach we're using is hacky as heck involving awscli and I would massively love to not be doing that.

nickperkins · 2021-07-31T15:05:53Z

Yes. If maintainors are still monitoring this PR, I'm ready to rewrite this PR as it fits current code base.

It might be worth closing this and creating a new PR with the updates rom #9615 (comment).

Acceptance test output: % make testacc TESTARGS='-run=TestAccAWSSsmParametersByPathDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSsmParametersByPathDataSource_ -timeout 180m === RUN TestAccAWSSsmParametersByPathDataSource_basic === PAUSE TestAccAWSSsmParametersByPathDataSource_basic === CONT TestAccAWSSsmParametersByPathDataSource_basic --- PASS: TestAccAWSSsmParametersByPathDataSource_basic (16.99s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 21.585s

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSSsmParametersByPathDataSource_'        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSsmParametersByPathDataSource_ -timeout 180m
=== RUN   TestAccAWSSsmParametersByPathDataSource_basic
=== PAUSE TestAccAWSSsmParametersByPathDataSource_basic
=== CONT  TestAccAWSSsmParametersByPathDataSource_basic
--- PASS: TestAccAWSSsmParametersByPathDataSource_basic (17.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.858s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSSsmParametersByPathDataSource_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSsmParametersByPathDataSource_ -timeout 180m
=== RUN   TestAccAWSSsmParametersByPathDataSource_basic
=== PAUSE TestAccAWSSsmParametersByPathDataSource_basic
=== CONT  TestAccAWSSsmParametersByPathDataSource_basic
--- PASS: TestAccAWSSsmParametersByPathDataSource_basic (20.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.193s

ewbankkit · 2021-09-30T21:20:07Z

@katainaka0503 Thanks for the contribution 🎉 👏.

github-actions · 2021-10-07T17:59:58Z

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-17T02:36:14Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

katainaka0503 requested a review from a team August 4, 2019 02:46

katainaka0503 force-pushed the add-aws-ssm-parameters-by-path-data-source branch 2 times, most recently from 1bd6e9d to a01b4f1 Compare August 4, 2019 03:06

katainaka0503 changed the title ~~[WIP] Add datasource ssm_parameters_by_path~~ Add datasource ssm_parameters_by_path Aug 4, 2019

katainaka0503 commented Aug 4, 2019

View reviewed changes

ryndaniels mentioned this pull request Sep 2, 2019

Get recursive ssm keys #9749

Closed

katainaka0503 force-pushed the add-aws-ssm-parameters-by-path-data-source branch 2 times, most recently from 4c016ae to a4e3a6c Compare May 7, 2020 15:48

katainaka0503 removed the request for review from a team May 8, 2020 02:34

katainaka0503 closed this May 8, 2020

katainaka0503 reopened this May 8, 2020

katainaka0503 mentioned this pull request May 8, 2020

SSM Parameter store data source which uses GetParametersByPath #9429

Closed

anGie44 force-pushed the master branch from 6c6566f to 081bf57 Compare June 29, 2020 16:15

Base automatically changed from master to main January 23, 2021 00:56

breathingdust requested a review from a team as a code owner January 23, 2021 00:56

ghostd mentioned this pull request Feb 16, 2021

Data source to query ssm parameter by path #17283

Closed

anGie44 added the new-data-source Introduces a new data source. label Mar 16, 2021

katainaka0503 and others added 6 commits September 30, 2021 16:22

Add datasource ssm_parameters_by_path

e6ceacf

Fix dependency

dd4905f

Delete unused Elem designation

6ba658d

Remove sidebar_current

f230d4e

Add subcategory

c7e2641

Corrections after rebase.

ac4b98b

ewbankkit force-pushed the add-aws-ssm-parameters-by-path-data-source branch from 5dfab2d to ac4b98b Compare September 30, 2021 20:32

ewbankkit added 3 commits September 30, 2021 17:03

Add CHANGELOG entry.

236f5af

d/aws_ssm_parameters_by_path: Use 'GetParametersByPathPages'.

15872fc

ewbankkit approved these changes Sep 30, 2021

View reviewed changes

ewbankkit mentioned this pull request Sep 30, 2021

[WIP] [Advice needed] Add data source SSM Parameters #8327

Closed

2 tasks

ewbankkit merged commit 7d5b779 into hashicorp:main Sep 30, 2021

github-actions bot added this to the v3.61.0 milestone Sep 30, 2021

Xerkus mentioned this pull request Oct 13, 2021

Add support for recursive flag on datasource aws_ssm_parameters_by_path #21274

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add datasource ssm_parameters_by_path #9615

Add datasource ssm_parameters_by_path #9615

katainaka0503 commented Aug 4, 2019 •

edited by ewbankkit

Loading

katainaka0503 Aug 4, 2019 •

edited

Loading

robertcnix May 6, 2020

dominik-ba Jul 21, 2021

cmeisinger commented Feb 26, 2020

Dgadavin commented May 4, 2020

DmitriyLyalyuev commented May 4, 2020

katainaka0503 commented May 7, 2020 •

edited

Loading

vlefr commented Jun 12, 2020 •

edited

Loading

teamterraform commented Aug 18, 2020

tsalinguepumpkin commented Sep 1, 2020

katainaka0503 commented Sep 1, 2020 •

edited

Loading

melvinkcx commented Sep 14, 2020

maulik-vimond commented Oct 26, 2020

itays333 commented Oct 28, 2020

theuves commented Dec 6, 2020

tsalinguepumpkin commented Jan 7, 2021

fatbasstard commented Apr 20, 2021

katainaka0503 commented Apr 20, 2021

fatbasstard commented Apr 26, 2021

yuklia commented Jul 4, 2021 •

edited

Loading

jbcom commented Jul 27, 2021

nickperkins commented Jul 31, 2021

ewbankkit left a comment

ewbankkit commented Sep 30, 2021

github-actions bot commented Oct 7, 2021

github-actions bot commented Jun 17, 2022

Add datasource ssm_parameters_by_path #9615

Add datasource ssm_parameters_by_path #9615

Conversation

katainaka0503 commented Aug 4, 2019 • edited by ewbankkit Loading

Community Note

katainaka0503 Aug 4, 2019 • edited Loading

Choose a reason for hiding this comment

robertcnix May 6, 2020

Choose a reason for hiding this comment

dominik-ba Jul 21, 2021

Choose a reason for hiding this comment

cmeisinger commented Feb 26, 2020

Dgadavin commented May 4, 2020

DmitriyLyalyuev commented May 4, 2020

katainaka0503 commented May 7, 2020 • edited Loading

vlefr commented Jun 12, 2020 • edited Loading

teamterraform commented Aug 18, 2020

Notification of Recent and Upcoming Changes to Contributions

Terraform 0.12 Syntax

Action Required: Terraform Plugin SDK Version 2

Action Required: Removal of website/aws.erb File

Upcoming Change of Git Branch Naming

Upcoming Change of GitHub Organization

tsalinguepumpkin commented Sep 1, 2020

katainaka0503 commented Sep 1, 2020 • edited Loading

melvinkcx commented Sep 14, 2020

maulik-vimond commented Oct 26, 2020

itays333 commented Oct 28, 2020

theuves commented Dec 6, 2020

tsalinguepumpkin commented Jan 7, 2021

fatbasstard commented Apr 20, 2021

katainaka0503 commented Apr 20, 2021

fatbasstard commented Apr 26, 2021

yuklia commented Jul 4, 2021 • edited Loading

jbcom commented Jul 27, 2021

nickperkins commented Jul 31, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Sep 30, 2021

github-actions bot commented Oct 7, 2021

github-actions bot commented Jun 17, 2022

katainaka0503 commented Aug 4, 2019 •

edited by ewbankkit

Loading

katainaka0503 Aug 4, 2019 •

edited

Loading

katainaka0503 commented May 7, 2020 •

edited

Loading

vlefr commented Jun 12, 2020 •

edited

Loading

katainaka0503 commented Sep 1, 2020 •

edited

Loading

yuklia commented Jul 4, 2021 •

edited

Loading