Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b/fix_dms_task_update_bug_19938: Add required fields to update input #28047

Merged
merged 4 commits into from
Jan 6, 2023
Merged

b/fix_dms_task_update_bug_19938: Add required fields to update input #28047

merged 4 commits into from
Jan 6, 2023

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented Nov 28, 2022

Description

This PR intends to fix the bug described here by including MigrationType and TableMappings on the update call regardless of whether they have been changed.
That issue is well written and is great for context.

Relations

Closes #19938

References

Readme in this repo for dms - note: the altered fields are listed as required.
AWS dms api

Output from Acceptance Testing

I couldn't acceptance test this, hopefully you can run this on your side. I would be surprised if this change caused failures but you never know...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/dms Issues and PRs that pertain to the dms service. needs-triage Waiting for first response or review from a maintainer. labels Nov 28, 2022
@Phlair Phlair mentioned this pull request Nov 28, 2022
Closed
github-actions[bot]
github-actions bot reviewed Nov 28, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Phlair 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 5, 2022
@YakDriver YakDriver self-assigned this Jan 4, 2023
@YakDriver YakDriver force-pushed the b-fix_dms_task_update_bug_19938 branch from 1c1bcd8 to 423cbcd Compare January 6, 2023 04:37
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 6, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 6, 2023
YakDriver
YakDriver approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTS=TestAccDMSReplicationTask PKG=dms                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_update
=== PAUSE TestAccDMSReplicationTask_update
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== RUN   TestAccDMSReplicationTask_s3ToRDS
=== PAUSE TestAccDMSReplicationTask_s3ToRDS
=== RUN   TestAccDMSReplicationTask_disappears
=== PAUSE TestAccDMSReplicationTask_disappears
=== CONT  TestAccDMSReplicationTask_basic
=== CONT  TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_disappears
=== CONT  TestAccDMSReplicationTask_s3ToRDS
=== CONT  TestAccDMSReplicationTask_update
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
--- PASS: TestAccDMSReplicationTask_disappears (888.76s)
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (910.55s)
--- PASS: TestAccDMSReplicationTask_basic (949.78s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1122.22s)
--- PASS: TestAccDMSReplicationTask_update (1266.09s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1652.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1654.180s

@YakDriver YakDriver merged commit fbc1c40 into hashicorp:main Jan 6, 2023
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 6, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.50.0
Development

Successfully merging this pull request may close these issues.

InvalidParameterValueException when updating aws_dms_replication_task
3 participants
@Phlair @YakDriver @justinretzolk