Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/rum_app_monitor - new resource #25180

Merged
merged 13 commits into from
Jun 23, 2022
Merged

r/rum_app_monitor - new resource #25180

merged 13 commits into from
Jun 23, 2022

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22201

Output from acceptance testing:

$ make testacc TESTS=TestAccAppMonitor_ PKG=rum
--- PASS: TestAccAppMonitor_disappears (27.81s)
--- PASS: TestAccAppMonitor_basic (37.02s)
--- PASS: TestAccAppMonitor_tags (83.40s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/rum Issues and PRs that pertain to the rum service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 5, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review June 5, 2022 16:02
@DrFaust92 DrFaust92 marked this pull request as draft June 5, 2022 16:03
@DrFaust92 DrFaust92 marked this pull request as ready for review June 5, 2022 16:14
@DrFaust92 DrFaust92 changed the title r/cloudwatchrum_app_monitor - new resource r/cloudwatch_rum_app_monitor - new resource Jun 6, 2022
@DrFaust92 DrFaust92 changed the title r/cloudwatch_rum_app_monitor - new resource r/rum_app_monitor - new resource Jun 6, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Jun 18, 2022
@github-actions github-actions bot added the repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. label Jun 23, 2022
ewbankkit
ewbankkit approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRUMAppMonitor_' PKG=rum ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 2  -run=TestAccRUMAppMonitor_ -timeout 180m
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMAppMonitor_disappears
--- PASS: TestAccRUMAppMonitor_disappears (15.66s)
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_basic (33.41s)
--- PASS: TestAccRUMAppMonitor_tags (41.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	61.264s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor 

% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit caf5a74 into hashicorp:main Jun 23, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 23, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/rum Issues and PRs that pertain to the rum service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.

Support Real-User Monitoring (RUM) for Amazon CloudWatch
2 participants
@DrFaust92 @ewbankkit