r/dms_replication_task: set cdc_start_position to computed
#23328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/databasemigrationservice
tests
ewbankkit
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTS=TestAccDMSReplicationTask_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask_' -timeout 180m
=== RUN TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== CONT TestAccDMSReplicationTask_basic
=== CONT TestAccDMSReplicationTask_cdcStartPosition
=== CONT TestAccDMSReplicationTask_basic
replication_task_test.go:30: Step 1/4 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_dms_replication_task.test will be updated in-place
~ resource "aws_dms_replication_task" "test" {
id = "tf-acc-test-5007085691435611452"
~ replication_task_settings = jsonencode(
~ {
- TTSettings = null -> null
# (13 unchanged elements hidden)
}
)
tags = {
"Name" = "tf-acc-test-5007085691435611452"
"Remove" = "to-remove"
"Update" = "to-update"
}
# (8 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (449.86s)
--- FAIL: TestAccDMSReplicationTask_basic (618.17s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/dms 622.385s
FAIL
make: *** [testacc] Error 1
|
This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #23319
Output from acceptance testing:
Test error related to #19883