Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/synthetics_canary - add artifact_config + make artifact_s3_location updateble #21963

Merged
merged 4 commits into from
Dec 1, 2021
Merged

r/synthetics_canary - add artifact_config + make artifact_s3_location updateble #21963

merged 4 commits into from
Dec 1, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 30, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccSyntheticsCanary_ PKG=synthetics
--- PASS: TestAccSyntheticsCanary_disappears (151.63s)
--- PASS: TestAccSyntheticsCanary_s3 (167.12s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (225.27s)
--- PASS: TestAccSyntheticsCanary_basic (240.57s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (249.96s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (250.73s)
--- PASS: TestAccSyntheticsCanary_runTracing (269.59s)
--- PASS: TestAccSyntheticsCanary_startCanary (279.54s)
--- PASS: TestAccSyntheticsCanary_tags (281.43s)
--- PASS: TestAccSyntheticsCanary_run (282.26s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/synthetics Issues and PRs that pertain to the synthetics service. labels Nov 30, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 30, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 30, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review November 30, 2021 14:28
ewbankkit
ewbankkit approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSyntheticsCanary_ PKG=synthetics
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_' -timeout 180m
=== RUN   TestAccSyntheticsCanary_basic
=== PAUSE TestAccSyntheticsCanary_basic
=== RUN   TestAccSyntheticsCanary_artifactEncryption
=== PAUSE TestAccSyntheticsCanary_artifactEncryption
=== RUN   TestAccSyntheticsCanary_runtimeVersion
=== PAUSE TestAccSyntheticsCanary_runtimeVersion
=== RUN   TestAccSyntheticsCanary_startCanary
=== PAUSE TestAccSyntheticsCanary_startCanary
=== RUN   TestAccSyntheticsCanary_StartCanary_codeChanges
=== PAUSE TestAccSyntheticsCanary_StartCanary_codeChanges
=== RUN   TestAccSyntheticsCanary_s3
=== PAUSE TestAccSyntheticsCanary_s3
=== RUN   TestAccSyntheticsCanary_run
=== PAUSE TestAccSyntheticsCanary_run
=== RUN   TestAccSyntheticsCanary_runTracing
=== PAUSE TestAccSyntheticsCanary_runTracing
=== RUN   TestAccSyntheticsCanary_vpc
=== PAUSE TestAccSyntheticsCanary_vpc
=== RUN   TestAccSyntheticsCanary_tags
=== PAUSE TestAccSyntheticsCanary_tags
=== RUN   TestAccSyntheticsCanary_disappears
=== PAUSE TestAccSyntheticsCanary_disappears
=== CONT  TestAccSyntheticsCanary_basic
=== CONT  TestAccSyntheticsCanary_run
=== CONT  TestAccSyntheticsCanary_tags
=== CONT  TestAccSyntheticsCanary_StartCanary_codeChanges
=== CONT  TestAccSyntheticsCanary_s3
=== CONT  TestAccSyntheticsCanary_vpc
=== CONT  TestAccSyntheticsCanary_runTracing
=== CONT  TestAccSyntheticsCanary_runtimeVersion
=== CONT  TestAccSyntheticsCanary_artifactEncryption
=== CONT  TestAccSyntheticsCanary_disappears
=== CONT  TestAccSyntheticsCanary_startCanary
--- PASS: TestAccSyntheticsCanary_disappears (72.80s)
--- PASS: TestAccSyntheticsCanary_s3 (89.83s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (102.59s)
--- PASS: TestAccSyntheticsCanary_runTracing (129.89s)
--- PASS: TestAccSyntheticsCanary_startCanary (130.28s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (134.32s)
--- PASS: TestAccSyntheticsCanary_tags (135.85s)
--- PASS: TestAccSyntheticsCanary_basic (139.16s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (139.20s)
--- PASS: TestAccSyntheticsCanary_run (141.11s)
--- PASS: TestAccSyntheticsCanary_vpc (2157.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	2163.483s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8b1ce98 into hashicorp:main Dec 1, 2021
@github-actions github-actions bot added this to the v3.68.0 milestone Dec 1, 2021
@DrFaust92 DrFaust92 deleted the r/synthetics_artifact_config branch December 1, 2021 17:49
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/synthetics Issues and PRs that pertain to the synthetics service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.68.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit