-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output S3 region to AWS SSM since it is now a supported parameter. #21803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @atomixer 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank your for this PR @atomixer 🚀 ! I've added in a changelog file and an additional validation to the new argument to get this merged into our upcoming release.
Output of acceptance tests:
--- PASS: TestAccSSMAssociation_withDocumentVersion (226.75s)
--- PASS: TestAccSSMAssociation_withAssociationName (308.02s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (317.07s)
--- PASS: TestAccSSMAssociation_withParameters (330.37s)
--- PASS: TestAccSSMAssociation_rateControl (330.52s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (331.37s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (357.34s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (357.40s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (376.86s)
--- PASS: TestAccSSMAssociation_disappears (391.39s)
--- PASS: TestAccSSMAssociation_withTargets (393.98s)
--- PASS: TestAccSSMAssociation_basic (404.14s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (456.12s)
--- PASS: TestAccSSMAssociation_withOutputLocation (457.57s)
This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21522
Output from acceptance testing:
I'm unable to run acceptance tests from my machine at this time. I will update the PR once I run them but I also don't want to block the review of the PR.