Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output S3 region to AWS SSM since it is now a supported parameter. #21803

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

atomixer
Copy link
Contributor

@atomixer atomixer commented Nov 17, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21522

Output from acceptance testing:

I'm unable to run acceptance tests from my machine at this time. I will update the PR once I run them but I also don't want to block the review of the PR.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. labels Nov 17, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @atomixer 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 17, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 20, 2021
@atomixer atomixer changed the title [WIP] Add output S3 region to AWS SSM since it is now a supported parameter. Add output S3 region to AWS SSM since it is now a supported parameter. Nov 21, 2021
@anGie44 anGie44 self-assigned this Nov 24, 2021
@anGie44 anGie44 added this to the v3.67.0 milestone Nov 24, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 24, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for this PR @atomixer 🚀 ! I've added in a changelog file and an additional validation to the new argument to get this merged into our upcoming release.

Output of acceptance tests:

--- PASS: TestAccSSMAssociation_withDocumentVersion (226.75s)
--- PASS: TestAccSSMAssociation_withAssociationName (308.02s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (317.07s)
--- PASS: TestAccSSMAssociation_withParameters (330.37s)
--- PASS: TestAccSSMAssociation_rateControl (330.52s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (331.37s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (357.34s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (357.40s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (376.86s)
--- PASS: TestAccSSMAssociation_disappears (391.39s)
--- PASS: TestAccSSMAssociation_withTargets (393.98s)
--- PASS: TestAccSSMAssociation_basic (404.14s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (456.12s)
--- PASS: TestAccSSMAssociation_withOutputLocation (457.57s)

@anGie44 anGie44 merged commit 50ed381 into hashicorp:main Nov 24, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OutputS3Region value in the output_location section of the aws_ssm_association resource
3 participants