Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_iot_thing_type tags support #21769

Merged
merged 5 commits into from
Nov 15, 2021
Merged

aws_iot_thing_type tags support #21769

merged 5 commits into from
Nov 15, 2021

Conversation

tmarlok88
Copy link
Contributor

@tmarlok88 tmarlok88 commented Nov 14, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ AWS_PROFILE=default make testacc TESTARGS='-run=TestAccIoTThingType' PKG_NAME=internal/service/iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTThingType -timeout 180m
=== RUN   TestAccIoTThingType_basic
=== PAUSE TestAccIoTThingType_basic
=== RUN   TestAccIoTThingType_full
=== PAUSE TestAccIoTThingType_full
=== RUN   TestAccIoTThingType_tags
=== PAUSE TestAccIoTThingType_tags
=== CONT  TestAccIoTThingType_basic
=== CONT  TestAccIoTThingType_tags
=== CONT  TestAccIoTThingType_full
--- PASS: TestAccIoTThingType_basic (344.52s)
--- PASS: TestAccIoTThingType_full (369.34s)
--- PASS: TestAccIoTThingType_tags (396.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	396.123s


...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iot Issues and PRs that pertain to the iot service. labels Nov 14, 2021
@tmarlok88 tmarlok88 changed the title F iot thing type tags support aws_iot_thing_type tags support Nov 14, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 15, 2021
ewbankkit
ewbankkit approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIoTThingType' PKG_NAME=internal/service/iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTThingType -timeout 180m
=== RUN   TestAccIoTThingType_basic
=== PAUSE TestAccIoTThingType_basic
=== RUN   TestAccIoTThingType_full
=== PAUSE TestAccIoTThingType_full
=== RUN   TestAccIoTThingType_tags
=== PAUSE TestAccIoTThingType_tags
=== CONT  TestAccIoTThingType_basic
=== CONT  TestAccIoTThingType_tags
=== CONT  TestAccIoTThingType_full
--- PASS: TestAccIoTThingType_basic (331.70s)
--- PASS: TestAccIoTThingType_full (344.95s)
--- PASS: TestAccIoTThingType_tags (356.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	362.431s

@ewbankkit
Copy link
Contributor

@tmarlok88 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e597e2e into hashicorp:main Nov 15, 2021
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 15, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.66.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tmarlok88 @ewbankkit