Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds/emr_release_labels #21767

Merged
merged 4 commits into from
Nov 15, 2021
Merged

ds/emr_release_labels #21767

merged 4 commits into from
Nov 15, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 13, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEMRReleaseLabels_basic' PKG_NAME=internal/service/emr

--- PASS: TestAccEMRReleaseLabels_application (35.46s)
--- PASS: TestAccEMRReleaseLabels_prefix (35.53s)
--- PASS: TestAccEMRReleaseLabels_basic (35.66s)
--- PASS: TestAccEMRReleaseLabels_full (36.19s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 13, 2021
@DrFaust92 DrFaust92 added the new-data-source Introduces a new data source. label Nov 13, 2021
@DrFaust92 DrFaust92 marked this pull request as draft November 13, 2021 23:39
@DrFaust92 DrFaust92 marked this pull request as ready for review November 13, 2021 23:43
ewbankkit
ewbankkit approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRReleaseLabels_' PKG_NAME=internal/service/emr 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run=TestAccEMRReleaseLabels_ -timeout 180m
=== RUN   TestAccEMRReleaseLabels_basic
=== PAUSE TestAccEMRReleaseLabels_basic
=== RUN   TestAccEMRReleaseLabels_prefix
=== PAUSE TestAccEMRReleaseLabels_prefix
=== RUN   TestAccEMRReleaseLabels_application
=== PAUSE TestAccEMRReleaseLabels_application
=== RUN   TestAccEMRReleaseLabels_full
=== PAUSE TestAccEMRReleaseLabels_full
=== CONT  TestAccEMRReleaseLabels_basic
=== CONT  TestAccEMRReleaseLabels_full
=== CONT  TestAccEMRReleaseLabels_prefix
=== CONT  TestAccEMRReleaseLabels_application
--- PASS: TestAccEMRReleaseLabels_application (16.68s)
--- PASS: TestAccEMRReleaseLabels_full (16.82s)
--- PASS: TestAccEMRReleaseLabels_prefix (16.87s)
--- PASS: TestAccEMRReleaseLabels_basic (17.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	21.377s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 199fe02 into hashicorp:main Nov 15, 2021
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 15, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/emr_release_label_ds branch November 19, 2021 22:21
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/emr Issues and PRs that pertain to the emr service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.66.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit