Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_securityhub_finding_aggregator #21560

Merged
merged 6 commits into from
Nov 15, 2021
Merged

New resource: aws_securityhub_finding_aggregator #21560

merged 6 commits into from
Nov 15, 2021

Conversation

ljones92
Copy link
Contributor

@ljones92 ljones92 commented Oct 31, 2021 •
edited
Loading

This PR allows the creation of aws_securityhub_finding_aggregator resources. These allow security hub findings to be aggregated across multiple regions into a single aggregation region. https://docs.aws.amazon.com/securityhub/latest/userguide/finding-aggregation.html

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

New resource: aws_securityhub_finding_aggregator

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccFindingAggregator' PKG_NAME=internal/service/securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20 -run=TestAccFindingAggregator -timeout 180m
=== RUN   TestAccFindingAggregator_basic
--- PASS: TestAccFindingAggregator_basic (126.07s)
=== RUN   TestAccFindingAggregator_disappears
--- PASS: TestAccFindingAggregator_disappears (41.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/securityhub        169.419s

Notes

  • This is my first terraform change so I'm open to any and all feedback around best practice!

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/securityhub Issues and PRs that pertain to the securityhub service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 31, 2021
github-actions[bot]
github-actions bot reviewed Oct 31, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ljones92 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 2, 2021
ewbankkit
ewbankkit approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSecurityHub_serial/FindingAggregator' PKG_NAME=internal/service/securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20 -run=TestAccSecurityHub_serial/FindingAggregator -timeout 180m
=== RUN   TestAccSecurityHub_serial
=== RUN   TestAccSecurityHub_serial/FindingAggregator
=== RUN   TestAccSecurityHub_serial/FindingAggregator/basic
=== RUN   TestAccSecurityHub_serial/FindingAggregator/disappears
--- PASS: TestAccSecurityHub_serial (65.31s)
    --- PASS: TestAccSecurityHub_serial/FindingAggregator (65.31s)
        --- PASS: TestAccSecurityHub_serial/FindingAggregator/basic (50.35s)
        --- PASS: TestAccSecurityHub_serial/FindingAggregator/disappears (14.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	68.236s

@ewbankkit
Copy link
Contributor

@ljones92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 05699bc into hashicorp:main Nov 15, 2021
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 15, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rxd90 rxd90 rxd90 approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/securityhub Issues and PRs that pertain to the securityhub service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.66.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ljones92 @ewbankkit @rxd90 @justinretzolk