Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/api_gateway_usage_plan - support method specific throttle settings #21461

Merged
merged 3 commits into from
Oct 25, 2021
Merged

r/api_gateway_usage_plan - support method specific throttle settings #21461

merged 3 commits into from
Oct 25, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 23, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5901.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAPIGatewayUsagePlan_'
--- PASS: TestAccAPIGatewayUsagePlan_disappears (100.71s)
--- PASS: TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit (143.04s)
--- PASS: TestAccAPIGatewayUsagePlan_basic (185.44s)
--- PASS: TestAccAPIGatewayUsagePlan_APIStages_throttle (260.78s)
--- PASS: TestAccAPIGatewayUsagePlan_productCode (277.56s)
--- PASS: TestAccAPIGatewayUsagePlan_throttling (368.32s)
--- PASS: TestAccAPIGatewayUsagePlan_apiStages (399.34s)
--- PASS: TestAccAPIGatewayUsagePlan_APIStages_multiple (451.38s)
--- PASS: TestAccAPIGatewayUsagePlan_quota (461.09s)
--- PASS: TestAccAPIGatewayUsagePlan_tags (500.93s)
--- PASS: TestAccAPIGatewayUsagePlan_description (708.25s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 23, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review October 23, 2021 20:26
@ewbankkit ewbankkit mentioned this pull request Oct 23, 2021
Closed
ewbankkit
ewbankkit approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayUsagePlan_' PKG_NAME=internal/service/apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run=TestAccAPIGatewayUsagePlan_ -timeout 180m
=== RUN   TestAccAPIGatewayUsagePlan_basic
=== PAUSE TestAccAPIGatewayUsagePlan_basic
=== RUN   TestAccAPIGatewayUsagePlan_tags
=== PAUSE TestAccAPIGatewayUsagePlan_tags
=== RUN   TestAccAPIGatewayUsagePlan_description
=== PAUSE TestAccAPIGatewayUsagePlan_description
=== RUN   TestAccAPIGatewayUsagePlan_productCode
=== PAUSE TestAccAPIGatewayUsagePlan_productCode
=== RUN   TestAccAPIGatewayUsagePlan_throttling
=== PAUSE TestAccAPIGatewayUsagePlan_throttling
=== RUN   TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit
=== PAUSE TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit
=== RUN   TestAccAPIGatewayUsagePlan_quota
=== PAUSE TestAccAPIGatewayUsagePlan_quota
=== RUN   TestAccAPIGatewayUsagePlan_apiStages
=== PAUSE TestAccAPIGatewayUsagePlan_apiStages
=== RUN   TestAccAPIGatewayUsagePlan_APIStages_multiple
=== PAUSE TestAccAPIGatewayUsagePlan_APIStages_multiple
=== RUN   TestAccAPIGatewayUsagePlan_APIStages_throttle
=== PAUSE TestAccAPIGatewayUsagePlan_APIStages_throttle
=== RUN   TestAccAPIGatewayUsagePlan_disappears
=== PAUSE TestAccAPIGatewayUsagePlan_disappears
=== CONT  TestAccAPIGatewayUsagePlan_basic
=== CONT  TestAccAPIGatewayUsagePlan_quota
=== CONT  TestAccAPIGatewayUsagePlan_productCode
=== CONT  TestAccAPIGatewayUsagePlan_apiStages
=== CONT  TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit
=== CONT  TestAccAPIGatewayUsagePlan_throttling
=== CONT  TestAccAPIGatewayUsagePlan_description
=== CONT  TestAccAPIGatewayUsagePlan_APIStages_throttle
=== CONT  TestAccAPIGatewayUsagePlan_disappears
=== CONT  TestAccAPIGatewayUsagePlan_APIStages_multiple
=== CONT  TestAccAPIGatewayUsagePlan_tags
--- PASS: TestAccAPIGatewayUsagePlan_tags (89.08s)
--- PASS: TestAccAPIGatewayUsagePlan_quota (123.55s)
--- PASS: TestAccAPIGatewayUsagePlan_disappears (197.76s)
--- PASS: TestAccAPIGatewayUsagePlan_APIStages_throttle (199.06s)
--- PASS: TestAccAPIGatewayUsagePlan_throttling (240.47s)
--- PASS: TestAccAPIGatewayUsagePlan_apiStages (361.17s)
--- PASS: TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit (651.54s)
--- PASS: TestAccAPIGatewayUsagePlan_description (832.32s)
--- PASS: TestAccAPIGatewayUsagePlan_APIStages_multiple (1300.59s)
--- PASS: TestAccAPIGatewayUsagePlan_basic (2453.86s)
--- PASS: TestAccAPIGatewayUsagePlan_productCode (2643.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	2646.442s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f16a97c into hashicorp:main Oct 25, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 25, 2021
@DrFaust92 DrFaust92 deleted the apigw_usage_plan_throttle branch October 25, 2021 15:16
This was referenced Oct 26, 2021
Merged
Merged
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

AWS API GW FR: Method Level Throttling
2 participants
@DrFaust92 @ewbankkit