Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus alert manager definition resource #21431

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Add prometheus alert manager definition resource #21431

merged 4 commits into from
Oct 21, 2021

Conversation

stijndehaes
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21236

Output from acceptance testing:

$ make testacc PKG_NAME=internal/service/prometheus TESTARGS='-run=TestAccPrometheusAlertManagerDefinition'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/prometheus/... -v -count 1 -parallel 20 -run=TestAccPrometheusAlertManagerDefinition -timeout 180m
=== RUN   TestAccPrometheusAlertManagerDefinition_basic
=== PAUSE TestAccPrometheusAlertManagerDefinition_basic
=== RUN   TestAccPrometheusAlertManagerDefinition_disappears
=== PAUSE TestAccPrometheusAlertManagerDefinition_disappears
=== CONT  TestAccPrometheusAlertManagerDefinition_basic
=== CONT  TestAccPrometheusAlertManagerDefinition_disappears
--- PASS: TestAccPrometheusAlertManagerDefinition_disappears (112.76s)
--- PASS: TestAccPrometheusAlertManagerDefinition_basic (293.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/prometheus 293.067s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/prometheusservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 21, 2021
@stijndehaes stijndehaes force-pushed the f-aws_prometheus_alert_manager_definition branch from cafd538 to c4b1afc Compare October 21, 2021 10:34
@stijndehaes
Add prometheus alert manager definition resource
20bf4d6 
Signed-off-by: Stijn De Haes <stijndehaes@gmail.com>
@stijndehaes stijndehaes force-pushed the f-aws_prometheus_alert_manager_definition branch from c4b1afc to 20bf4d6 Compare October 21, 2021 10:46
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2021
ewbankkit
ewbankkit approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG_NAME=internal/service/prometheus TESTARGS='-run=TestAccPrometheusAlertManagerDefinition'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/prometheus/... -v -count 1 -parallel 20 -run=TestAccPrometheusAlertManagerDefinition -timeout 180m
=== RUN   TestAccPrometheusAlertManagerDefinition_basic
=== PAUSE TestAccPrometheusAlertManagerDefinition_basic
=== RUN   TestAccPrometheusAlertManagerDefinition_disappears
=== PAUSE TestAccPrometheusAlertManagerDefinition_disappears
=== CONT  TestAccPrometheusAlertManagerDefinition_basic
=== CONT  TestAccPrometheusAlertManagerDefinition_disappears
--- PASS: TestAccPrometheusAlertManagerDefinition_disappears (104.18s)
--- PASS: TestAccPrometheusAlertManagerDefinition_basic (268.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/prometheus	275.019s
GovCloud
% make testacc PKG_NAME=internal/service/prometheus TESTARGS='-run=TestAccPrometheusAlertManagerDefinition'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/prometheus/... -v -count 1 -parallel 20 -run=TestAccPrometheusAlertManagerDefinition -timeout 180m
=== RUN   TestAccPrometheusAlertManagerDefinition_basic
=== PAUSE TestAccPrometheusAlertManagerDefinition_basic
=== RUN   TestAccPrometheusAlertManagerDefinition_disappears
=== PAUSE TestAccPrometheusAlertManagerDefinition_disappears
=== CONT  TestAccPrometheusAlertManagerDefinition_basic
=== CONT  TestAccPrometheusAlertManagerDefinition_disappears
=== CONT  TestAccPrometheusAlertManagerDefinition_basic
    acctest.go:694: skipping tests; partition aws-us-gov does not support aps service
--- SKIP: TestAccPrometheusAlertManagerDefinition_basic (1.49s)
=== CONT  TestAccPrometheusAlertManagerDefinition_disappears
    acctest.go:694: skipping tests; partition aws-us-gov does not support aps service
--- SKIP: TestAccPrometheusAlertManagerDefinition_disappears (1.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/prometheus	11.406s

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Oct 21, 2021
@ewbankkit
Copy link
Contributor

@stijndehaes Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ebb9e50 into hashicorp:main Oct 21, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 21, 2021
This was referenced Oct 21, 2021
Closed
Merged
@stijndehaes stijndehaes deleted the f-aws_prometheus_alert_manager_definition branch October 26, 2021 06:17
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stijndehaes @ewbankkit