-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "change arg back to a TypeSet since it supports multiple values and order doesn't matter" #21404
Conversation
…s and order doesn't matter" This reverts commit eff2775.
@ewbankkit could you please review this ? |
The CloudFormation Resource Schema definition for
and as the default value of |
I think thats exactly what this MR tries to solve. It was changed to |
Will wait for @anGie44 to take a look before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @sylr 🚀 ! Preemptively approving while the acceptance tests finish running on our side.
Just a heads up: i've come across a test failure pertaining to the order of
|
cacee52
to
dda2977
Compare
Confirming test is now passing with change:
|
This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This reverts commit eff2775.
Fixes #21203.
Relates #20532.
Original PR stated that the order of instance types did not matter but it absolutely does.
Community Note
Relates OR Closes #0000
Output from acceptance testing: