Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import icmp #21163

Merged
merged 11 commits into from
Nov 11, 2021
Merged

Import icmp #21163

merged 11 commits into from
Nov 11, 2021

Conversation

brenthc
Copy link
Contributor

@brenthc brenthc commented Oct 5, 2021 •
edited by anGie44
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15501
Closes #11433

Output from new acceptance test (before code change):

=== RUN   TestAccEC2SecurityGroupRule_Ingress_icmpv6
=== PAUSE TestAccEC2SecurityGroupRule_Ingress_icmpv6
=== CONT  TestAccEC2SecurityGroupRule_Ingress_icmpv6
    security_group_rule_test.go:245: Step 2/2 error running import: exit status 1

        Error: unexpected format of import string ("sg-0ff65b23f0006e024_ingress_icmpv6_-1_-1_::/0"), expected SECURITYGROUPID_TYPE_PROTOCOL_FROMPORT_TOPORT_SOURCE[_SOURCE]*: protocol must be tcp/udp/icmp/all or a number


--- FAIL: TestAccEC2SecurityGroupRule_Ingress_icmpv6 (27.38s)

Output from new acceptance test (after code change):

--- PASS: TestAccEC2SecurityGroupRule_Ingress_icmpv6 (28.06s)

Output of unit testing:

 make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
?   	github.com/hashicorp/terraform-provider-aws	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	6.275s
ok  	github.com/hashicorp/terraform-provider-aws/internal/conns	(cached)
ok  	github.com/hashicorp/terraform-provider-aws/internal/create	(cached)
ok  	github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable	(cached)
?   	github.com/hashicorp/terraform-provider-aws/internal/experimental/sync	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/flex	(cached)
ok  	github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters	7.821s
?   	github.com/hashicorp/terraform-provider-aws/internal/provider	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	16.782s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	9.284s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	28.307s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amplify	19.583s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	35.030s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	22.998s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	9.881s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	11.948s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	14.467s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	31.346s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	26.328s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	28.864s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	36.426s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	23.764s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans	23.169s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	24.814s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	21.641s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	24.113s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	24.799s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloud9	28.231s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol	25.307s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	26.651s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	28.390s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	24.824s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	27.158s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	20.680s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchevents	21.140s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchlogs	19.393s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact	19.336s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	16.989s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecommit	16.752s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codedeploy	19.335s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	19.441s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	21.078s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications	21.907s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	21.883s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	19.904s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/config	19.927s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	19.997s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cur	20.344s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline	20.116s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	22.483s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dax	22.818s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	23.198s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	22.179s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	23.719s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	18.633s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	21.173s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	18.837s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	22.031s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.817s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	20.171s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	23.406s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	20.598s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	21.566s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	16.308s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	16.534s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	19.528s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	19.742s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder	18.718s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	13.585s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	18.395s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	16.492s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	11.932s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	15.864s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	17.535s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	18.683s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glacier	20.311s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	23.771s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	27.747s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/greengrass	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	24.382s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	8.756s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	7.486s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	8.149s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector	12.306s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	8.350s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotevents	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	5.689s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	15.148s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics	10.293s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2	14.704s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo	16.166s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	21.098s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	16.979s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	19.339s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodelbuilding	16.950s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager	15.823s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	22.671s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie	19.873s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	21.046s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	20.323s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage	20.308s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediastore	19.958s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	19.710s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	20.776s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	21.322s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	19.626s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	19.887s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	17.080s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	16.815s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	19.830s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint	16.862s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pricing	20.425s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/prometheus	18.425s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	21.095s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	18.152s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	22.035s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	20.111s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	19.249s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	20.206s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstagging	17.871s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	14.734s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig	15.587s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	18.136s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	16.720s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	19.455s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	14.507s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts	12.196s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	13.957s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	17.198s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	17.816s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	18.218s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/serverlessapprepo	18.435s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	16.010s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	13.673s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas	11.055s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	17.284s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	18.161s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	13.003s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/signer	12.656s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	13.951s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	21.675s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	3.941s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	6.253s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	13.989s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	11.170s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	5.309s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/swf	8.045s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	4.053s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	12.658s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	7.739s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/waf	14.277s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafregional	13.653s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	13.781s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/worklink	9.290s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	11.835s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/xray	13.092s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tags	6.495s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tfresource	32.587s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys	7.821s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil	1.132s
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	12.478s
?   	github.com/hashicorp/terraform-provider-aws/version	[no test files]

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2021
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@anGie44 anGie44 self-assigned this Nov 10, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 10, 2021
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Nov 10, 2021
@anGie44
Copy link
Contributor

anGie44 commented Nov 10, 2021

Output of acceptance tests (commercial):

--- PASS: TestAccEC2SecurityGroupRule_expectInvalidTypeError (13.94s)
--- PASS: TestAccEC2SecurityGroupRule_expectInvalidCIDR (21.96s)
--- PASS: TestAccEC2SecurityGroupRule_IngressSourceWithAccount_id (83.25s)
--- PASS: TestAccEC2SecurityGroupDataSource_basic (86.96s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_vpc (88.29s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_ipv6 (89.36s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_classic (90.10s)
--- PASS: TestAccEC2SecurityGroupRule_ingressDescription (90.19s)
--- PASS: TestAccEC2SecurityGroupRule_egress (90.89s)
--- PASS: TestAccEC2SecurityGroupRule_egressDescription (91.20s)
--- PASS: TestAccEC2SecurityGroupRule_issue5310 (93.61s)
--- PASS: TestAccEC2SecurityGroupRule_selfSource (97.50s)
--- PASS: TestAccEC2SecurityGroupRule_multiIngress (98.27s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_protocol (98.39s)
--- PASS: TestAccEC2SecurityGroupRule_selfReference (98.37s)
--- PASS: TestAccEC2SecurityGroupRule_PartialMatching_source (101.44s)
--- PASS: TestAccEC2SecurityGroupRule_prefixListEgress (107.34s)
--- PASS: TestAccEC2SecurityGroupRule_PartialMatching_basic (124.78s)
--- PASS: TestAccEC2SecurityGroupRule_IngressDescription_updates (156.39s)
--- PASS: TestAccEC2SecurityGroupRule_EgressDescription_updates (153.92s)
--- PASS: TestAccEC2SecurityGroupRule_MultipleRuleSearching_allProtocolCrash (82.60s)
--- PASS: TestAccEC2SecurityGroupRule_Description_allPorts (152.97s)
--- PASS: TestAccEC2SecurityGroup_sourceSecurityGroup (98.82s)
--- PASS: TestAccEC2SecurityGroup_allowAll (99.67s)
--- PASS: TestAccEC2SecurityGroup_ipRangesWithSameRules (98.55s)
--- PASS: TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules (99.62s)
--- PASS: TestAccEC2SecurityGroup_basic (100.32s)
--- PASS: TestAccEC2SecurityGroup_ipv6 (95.52s)
--- PASS: TestAccEC2SecurityGroup_Name_generated (95.46s)
--- SKIP: TestAccEC2SecurityGroup_defaultEgressClassic (2.43s)
--- PASS: TestAccEC2SecurityGroup_ruleGathering (107.90s)
--- PASS: TestAccEC2SecurityGroupRule_race (209.48s)
--- PASS: TestAccEC2SecurityGroup_Name_terraformPrefix (92.73s)
--- PASS: TestAccEC2SecurityGroupRule_DescriptionAllPorts_nonZeroPorts (153.75s)
--- PASS: TestAccEC2SecurityGroup_invalidCIDRBlock (34.55s)
--- PASS: TestAccEC2SecurityGroup_namePrefix (90.37s)
--- SKIP: TestAccEC2SecurityGroup_ingressWithCIDRAndSGsClassic (2.42s)
--- PASS: TestAccEC2SecurityGroup_NamePrefix_terraformPrefix (89.22s)
--- PASS: TestAccEC2SecurityGroup_self (90.10s)
--- PASS: TestAccEC2SecurityGroup_vpc (88.86s)
--- PASS: TestAccEC2SecurityGroup_vpcNegOneIngress (85.34s)
--- PASS: TestAccEC2SecurityGroup_vpcProtoNumIngress (87.65s)
--- PASS: TestAccEC2SecurityGroup_multiIngress (90.02s)
--- PASS: TestAccEC2SecurityGroup_defaultEgressVPC (85.04s)
--- PASS: TestAccEC2SecurityGroup_drift (81.11s)
--- PASS: TestAccEC2SecurityGroup_driftComplex (86.41s)
--- PASS: TestAccEC2SecurityGroup_egressMode (216.46s)
--- PASS: TestAccEC2SecurityGroup_ingressMode (213.38s)
--- PASS: TestAccEC2SecurityGroupRule_multiDescription (234.01s)
--- PASS: TestAccEC2SecurityGroup_cidrAndGroups (86.53s)
--- PASS: TestAccEC2SecurityGroup_ingressWithCIDRAndSGsVPC (82.88s)
--- PASS: TestAccEC2SecurityGroup_change (143.88s)
--- PASS: TestAccEC2SecurityGroup_failWithDiffMismatch (70.80s)
--- PASS: TestAccEC2SecurityGroup_ipv4AndIPv6Egress (77.64s)
--- PASS: TestAccEC2SecurityGroup_egressWithPrefixList (90.94s)
--- PASS: TestAccEC2SecurityGroup_ingressWithPrefixList (88.72s)
--- PASS: TestAccEC2SecurityGroupsDataSource_tag (57.67s)
--- PASS: TestAccEC2SecurityGroupsDataSource_filter (47.27s)
--- PASS: TestAccEC2SecurityGroup_ruleDescription (171.40s)
--- PASS: TestAccEC2SecurityGroup_tags (151.22s)
--- PASS: TestAccEC2SecurityGroup_rulesDropOnError (87.01s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitCIDRBlockExceededAppend (98.08s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitExceededAppend (113.45s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitExceededAllNew (109.27s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitExceededPrepend (111.58s)
--- PASS: TestAccEC2SecurityGroup_forceRevokeRulesFalse (1036.64s)
--- PASS: TestAccEC2SecurityGroup_forceRevokeRulesTrue (1060.57s)

anGie44
anGie44 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch @brenthc ! LGTM 🚀

@anGie44 anGie44 added this to the v3.65.0 milestone Nov 11, 2021
@anGie44 anGie44 merged commit 2d3d492 into hashicorp:main Nov 11, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@brenthc
Copy link
Contributor Author

brenthc commented Nov 11, 2021

@anGie44 fyi the github-actions bot has a bad link to the 3.65.0 changelog because that version doesn't appear to be tagged or published on the releases site yet. Dunno if that's intended for, like, when people find this later, or if it's supposed to be for after the release is actually published.

@brenthc brenthc deleted the import_icmp branch November 11, 2021 23:08
@wedge-jarrad wedge-jarrad mentioned this pull request Dec 1, 2021
Closed
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.65.0
4 participants
@brenthc @zhelding @anGie44 @justinretzolk