Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_flow_definition #20825

Merged
merged 10 commits into from
Sep 21, 2021
Merged

r/sagemaker_flow_definition #20825

merged 10 commits into from
Sep 21, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Sep 7, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerFlowDefinition_'
--- PASS: TestAccAWSSagemakerFlowDefinition_basic (211.82s)
--- PASS: TestAccAWSSagemakerFlowDefinition_humanLoopConfig_publicWorkforce (107.37s)
--- PASS: TestAccAWSSagemakerFlowDefinition_humanLoopRequestSource (153.40s)
--- PASS: TestAccAWSSagemakerFlowDefinition_tags (303.88s)
--- PASS: TestAccAWSSagemakerFlowDefinition_disappears (144.54s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 7, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Sep 7, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review September 7, 2021 21:06
@DrFaust92 DrFaust92 force-pushed the r/sagemaker_flow_definition branch from 6be2857 to 7f01ce6 Compare September 10, 2021 16:16
ewbankkit
ewbankkit approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/FlowDefinition'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/FlowDefinition -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/FlowDefinition
=== RUN   TestAccAWSSagemaker_serial/FlowDefinition/HumanLoopRequestSource
=== RUN   TestAccAWSSagemaker_serial/FlowDefinition/Tags
=== RUN   TestAccAWSSagemaker_serial/FlowDefinition/basic
=== RUN   TestAccAWSSagemaker_serial/FlowDefinition/disappears
=== RUN   TestAccAWSSagemaker_serial/FlowDefinition/HumanLoopConfigPublicWorkforce
--- PASS: TestAccAWSSagemaker_serial (592.57s)
    --- PASS: TestAccAWSSagemaker_serial/FlowDefinition (592.57s)
        --- PASS: TestAccAWSSagemaker_serial/FlowDefinition/HumanLoopRequestSource (103.38s)
        --- PASS: TestAccAWSSagemaker_serial/FlowDefinition/Tags (143.51s)
        --- PASS: TestAccAWSSagemaker_serial/FlowDefinition/basic (101.38s)
        --- PASS: TestAccAWSSagemaker_serial/FlowDefinition/disappears (198.45s)
        --- PASS: TestAccAWSSagemaker_serial/FlowDefinition/HumanLoopConfigPublicWorkforce (45.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	596.082s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemakerFlowDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerFlowDefinition_ -timeout 180m
=== RUN   TestAccAWSSagemakerFlowDefinition_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-4342882516533128815): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: b0bc03f9-12c0-48b7-a8ef-bc1e5a5deaa7
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
        
        Error: error creating SageMaker Workforce (tf-acc-test-4342882516533128815): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 40332a18-c2fe-447f-a7da-2474e9a997fc
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 84, in resource "aws_sagemaker_workforce" "test":
          84: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerFlowDefinition_basic (17.13s)
=== RUN   TestAccAWSSagemakerFlowDefinition_humanLoopConfig_publicWorkforce
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-7512304840105050346): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: c573173b-cac3-48f7-bde9-f58edde31934
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
--- SKIP: TestAccAWSSagemakerFlowDefinition_humanLoopConfig_publicWorkforce (17.07s)
=== RUN   TestAccAWSSagemakerFlowDefinition_humanLoopRequestSource
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-6236203991910895701): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 8f204398-372e-4f26-b20e-165633edab65
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
        
        Error: error creating SageMaker Workforce (tf-acc-test-6236203991910895701): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 8b00c0e6-c0ed-4fb1-8d05-166bb5def1c7
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 84, in resource "aws_sagemaker_workforce" "test":
          84: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerFlowDefinition_humanLoopRequestSource (15.74s)
=== RUN   TestAccAWSSagemakerFlowDefinition_tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-2606529329326258546): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: e63ed262-44b6-415d-a1d9-af97af222c3c
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
        
        Error: error creating SageMaker Workforce (tf-acc-test-2606529329326258546): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 124eb942-d6f5-4307-acd8-efe500aa6b99
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 84, in resource "aws_sagemaker_workforce" "test":
          84: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerFlowDefinition_tags (15.61s)
=== RUN   TestAccAWSSagemakerFlowDefinition_disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-8730481172086387437): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 27ab09c5-8387-4686-8364-c37ecba627d9
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
        
        Error: error creating SageMaker Workforce (tf-acc-test-8730481172086387437): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 1f7bd5b0-3171-4b2e-85dc-b70151d5031a
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 84, in resource "aws_sagemaker_workforce" "test":
          84: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerFlowDefinition_disappears (15.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	84.647s

@ewbankkit ewbankkit force-pushed the r/sagemaker_flow_definition branch from c4cc760 to d0fc1ad Compare September 21, 2021 20:42
@ewbankkit ewbankkit merged commit bc728a0 into hashicorp:main Sep 21, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 21, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_flow_definition branch September 21, 2021 21:44
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.60.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit