rd/route53_zone - add `arn` attribute #20652

DrFaust92 · 2021-08-22T21:01:31Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20647

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53Zone_'
--- PASS: TestAccAWSRoute53Zone_disappears (78.37s)
--- PASS: TestAccAWSRoute53Zone_multiple (112.07s)
--- PASS: TestAccAWSRoute53Zone_basic (118.98s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (119.63s)
--- PASS: TestAccAWSRoute53Zone_Comment (202.60s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (216.23s)
--- PASS: TestAccAWSRoute53Zone_Tags (243.91s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (272.20s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (314.59s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (354.00s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (489.74s)

$ make testacc TESTARGS='-run=TestAccAWSRoute53Zone_'
--- PASS: TestAccAWSRoute53ZoneDataSource_id (95.37s)
--- PASS: TestAccAWSRoute53ZoneDataSource_vpc (158.02s)
--- PASS: TestAccAWSRoute53ZoneDataSource_tags (159.61s)
--- PASS: TestAccAWSRoute53ZoneDataSource_serviceDiscovery (176.49s)
Error: no matching Route53Zone found

  on terraform_plugin_test.tf line 6, in data "aws_route53_zone" "test":
   6: data "aws_route53_zone" "test" {


    data_source_aws_route53_zone_test.go:44: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: no matching Route53Zone found
        
          on terraform_plugin_test.tf line 6, in data "aws_route53_zone" "test":
           6: data "aws_route53_zone" "test" {
        
        
--- FAIL: TestAccAWSRoute53ZoneDataSource_name (15.25s)

error seems unrelated

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSRoute53ZoneDataSource_\|TestAccAWSRoute53Zone_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ZoneDataSource_\|TestAccAWSRoute53Zone_ -timeout 180m
=== RUN   TestAccAWSRoute53ZoneDataSource_id
=== PAUSE TestAccAWSRoute53ZoneDataSource_id
=== RUN   TestAccAWSRoute53ZoneDataSource_name
=== PAUSE TestAccAWSRoute53ZoneDataSource_name
=== RUN   TestAccAWSRoute53ZoneDataSource_tags
=== PAUSE TestAccAWSRoute53ZoneDataSource_tags
=== RUN   TestAccAWSRoute53ZoneDataSource_vpc
=== PAUSE TestAccAWSRoute53ZoneDataSource_vpc
=== RUN   TestAccAWSRoute53ZoneDataSource_serviceDiscovery
=== PAUSE TestAccAWSRoute53ZoneDataSource_serviceDiscovery
=== RUN   TestAccAWSRoute53Zone_basic
=== PAUSE TestAccAWSRoute53Zone_basic
=== RUN   TestAccAWSRoute53Zone_disappears
=== PAUSE TestAccAWSRoute53Zone_disappears
=== RUN   TestAccAWSRoute53Zone_multiple
=== PAUSE TestAccAWSRoute53Zone_multiple
=== RUN   TestAccAWSRoute53Zone_Comment
=== PAUSE TestAccAWSRoute53Zone_Comment
=== RUN   TestAccAWSRoute53Zone_DelegationSetID
=== PAUSE TestAccAWSRoute53Zone_DelegationSetID
=== RUN   TestAccAWSRoute53Zone_ForceDestroy
=== PAUSE TestAccAWSRoute53Zone_ForceDestroy
=== RUN   TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== PAUSE TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== RUN   TestAccAWSRoute53Zone_Tags
=== PAUSE TestAccAWSRoute53Zone_Tags
=== RUN   TestAccAWSRoute53Zone_VPC_Single
=== PAUSE TestAccAWSRoute53Zone_VPC_Single
=== RUN   TestAccAWSRoute53Zone_VPC_Multiple
=== PAUSE TestAccAWSRoute53Zone_VPC_Multiple
=== RUN   TestAccAWSRoute53Zone_VPC_Updates
=== PAUSE TestAccAWSRoute53Zone_VPC_Updates
=== CONT  TestAccAWSRoute53ZoneDataSource_id
=== CONT  TestAccAWSRoute53Zone_VPC_Updates
=== CONT  TestAccAWSRoute53Zone_DelegationSetID
=== CONT  TestAccAWSRoute53ZoneDataSource_serviceDiscovery
=== CONT  TestAccAWSRoute53Zone_VPC_Multiple
=== CONT  TestAccAWSRoute53Zone_VPC_Single
=== CONT  TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== CONT  TestAccAWSRoute53Zone_Tags
=== CONT  TestAccAWSRoute53Zone_basic
=== CONT  TestAccAWSRoute53ZoneDataSource_vpc
=== CONT  TestAccAWSRoute53ZoneDataSource_tags
=== CONT  TestAccAWSRoute53Zone_disappears
=== CONT  TestAccAWSRoute53ZoneDataSource_name
=== CONT  TestAccAWSRoute53Zone_Comment
=== CONT  TestAccAWSRoute53Zone_multiple
=== CONT  TestAccAWSRoute53Zone_ForceDestroy
--- PASS: TestAccAWSRoute53Zone_Comment (63.67s)
--- PASS: TestAccAWSRoute53Zone_disappears (64.51s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (68.59s)
--- PASS: TestAccAWSRoute53Zone_basic (68.64s)
--- PASS: TestAccAWSRoute53ZoneDataSource_id (68.84s)
--- PASS: TestAccAWSRoute53Zone_multiple (69.18s)
--- PASS: TestAccAWSRoute53ZoneDataSource_name (83.40s)
--- PASS: TestAccAWSRoute53Zone_Tags (94.52s)
--- PASS: TestAccAWSRoute53ZoneDataSource_tags (95.88s)
--- PASS: TestAccAWSRoute53ZoneDataSource_vpc (111.22s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (113.13s)
--- PASS: TestAccAWSRoute53ZoneDataSource_serviceDiscovery (132.10s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (157.24s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (266.02s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (266.83s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (322.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       327.571s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSRoute53ZoneDataSource_\|TestAccAWSRoute53Zone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ZoneDataSource_\|TestAccAWSRoute53Zone_ -timeout 180m
=== RUN   TestAccAWSRoute53ZoneDataSource_id
=== PAUSE TestAccAWSRoute53ZoneDataSource_id
=== RUN   TestAccAWSRoute53ZoneDataSource_name
=== PAUSE TestAccAWSRoute53ZoneDataSource_name
=== RUN   TestAccAWSRoute53ZoneDataSource_tags
=== PAUSE TestAccAWSRoute53ZoneDataSource_tags
=== RUN   TestAccAWSRoute53ZoneDataSource_vpc
=== PAUSE TestAccAWSRoute53ZoneDataSource_vpc
=== RUN   TestAccAWSRoute53ZoneDataSource_serviceDiscovery
=== PAUSE TestAccAWSRoute53ZoneDataSource_serviceDiscovery
=== RUN   TestAccAWSRoute53Zone_basic
=== PAUSE TestAccAWSRoute53Zone_basic
=== RUN   TestAccAWSRoute53Zone_disappears
=== PAUSE TestAccAWSRoute53Zone_disappears
=== RUN   TestAccAWSRoute53Zone_multiple
=== PAUSE TestAccAWSRoute53Zone_multiple
=== RUN   TestAccAWSRoute53Zone_Comment
=== PAUSE TestAccAWSRoute53Zone_Comment
=== RUN   TestAccAWSRoute53Zone_DelegationSetID
=== PAUSE TestAccAWSRoute53Zone_DelegationSetID
=== RUN   TestAccAWSRoute53Zone_ForceDestroy
=== PAUSE TestAccAWSRoute53Zone_ForceDestroy
=== RUN   TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== PAUSE TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== RUN   TestAccAWSRoute53Zone_Tags
=== PAUSE TestAccAWSRoute53Zone_Tags
=== RUN   TestAccAWSRoute53Zone_VPC_Single
=== PAUSE TestAccAWSRoute53Zone_VPC_Single
=== RUN   TestAccAWSRoute53Zone_VPC_Multiple
=== PAUSE TestAccAWSRoute53Zone_VPC_Multiple
=== RUN   TestAccAWSRoute53Zone_VPC_Updates
=== PAUSE TestAccAWSRoute53Zone_VPC_Updates
=== CONT  TestAccAWSRoute53ZoneDataSource_id
=== CONT  TestAccAWSRoute53Zone_DelegationSetID
=== CONT  TestAccAWSRoute53Zone_VPC_Single
=== CONT  TestAccAWSRoute53Zone_ForceDestroy
=== CONT  TestAccAWSRoute53ZoneDataSource_serviceDiscovery
=== CONT  TestAccAWSRoute53ZoneDataSource_tags
=== CONT  TestAccAWSRoute53Zone_Tags
=== CONT  TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
=== CONT  TestAccAWSRoute53Zone_basic
=== CONT  TestAccAWSRoute53Zone_Comment
=== CONT  TestAccAWSRoute53Zone_multiple
=== CONT  TestAccAWSRoute53Zone_disappears
=== CONT  TestAccAWSRoute53Zone_VPC_Updates
=== CONT  TestAccAWSRoute53ZoneDataSource_vpc
=== CONT  TestAccAWSRoute53ZoneDataSource_name
=== CONT  TestAccAWSRoute53Zone_VPC_Multiple
=== CONT  TestAccAWSRoute53ZoneDataSource_serviceDiscovery
    provider_test.go:735: skipping tests; partition aws-us-gov does not support servicediscovery service
--- SKIP: TestAccAWSRoute53ZoneDataSource_serviceDiscovery (1.30s)
=== CONT  TestAccAWSRoute53Zone_ForceDestroy
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 7c73231e-d28b-47c0-963e-80a2c8f6f818
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
--- SKIP: TestAccAWSRoute53Zone_ForceDestroy (12.64s)
=== CONT  TestAccAWSRoute53Zone_Comment
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 2e6f0194-66d2-4f48-8d92-f1568c549569
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
=== CONT  TestAccAWSRoute53Zone_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: fa7c9743-dfcf-4f38-a2cb-dd2b33dc5a95
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
--- SKIP: TestAccAWSRoute53Zone_Comment (15.20s)
=== CONT  TestAccAWSRoute53Zone_disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 934f5e8f-ea73-41b3-aabd-36ec9f9800ee
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
=== CONT  TestAccAWSRoute53Zone_Tags
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: d3f3891d-74d8-4654-9593-83dd703f134d
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
=== CONT  TestAccAWSRoute53Zone_DelegationSetID
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: ffab7898-360b-472b-8430-2231405e9181
        
          with aws_route53_delegation_set.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_delegation_set" "test":
           2: resource "aws_route53_delegation_set" "test" {}
        
=== CONT  TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: c5f466cb-24e8-4e61-a848-8ed2a3fdbcb9
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
=== CONT  TestAccAWSRoute53ZoneDataSource_id
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 601949b1-2acc-481e-98f7-74c334539ca4
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
=== CONT  TestAccAWSRoute53ZoneDataSource_name
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: b687c77f-0157-4329-a08c-98bb775fbf6c
        
          with aws_route53_zone.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
=== CONT  TestAccAWSRoute53Zone_multiple
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 64952901-daba-4dfb-91bd-b59855714ac5
        
          with aws_route53_zone.test[2],
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: a7b3adb0-092b-4e3a-b2be-1568faad9936
        
          with aws_route53_zone.test[3],
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: f8e6b6b8-210a-4152-aee6-ac5fbc93fd8f
        
          with aws_route53_zone.test[1],
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 7af829b0-1573-45bc-923c-882a27648437
        
          with aws_route53_zone.test[4],
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
        
        Error: error creating Route53 Hosted Zone: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 685d4013-7ed3-4314-a1c5-3df78bc63850
        
          with aws_route53_zone.test[0],
          on terraform_plugin_test.tf line 2, in resource "aws_route53_zone" "test":
           2: resource "aws_route53_zone" "test" {
        
--- SKIP: TestAccAWSRoute53Zone_basic (15.42s)
--- SKIP: TestAccAWSRoute53Zone_DelegationSetID (15.62s)
--- SKIP: TestAccAWSRoute53Zone_Tags (15.62s)
--- SKIP: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (15.67s)
--- SKIP: TestAccAWSRoute53Zone_disappears (15.67s)
--- SKIP: TestAccAWSRoute53Zone_multiple (15.73s)
--- SKIP: TestAccAWSRoute53ZoneDataSource_name (15.74s)
--- SKIP: TestAccAWSRoute53ZoneDataSource_id (15.76s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (69.53s)
--- PASS: TestAccAWSRoute53ZoneDataSource_vpc (77.43s)
--- PASS: TestAccAWSRoute53ZoneDataSource_tags (83.35s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (97.13s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (199.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	202.325s

ewbankkit · 2021-08-23T16:08:56Z

@DrFaust92 Thanks for the contribution 🎉 👏.

github-actions · 2021-08-31T17:14:09Z

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-24T02:36:26Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

route53 zone resources - arn

3b1c246

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 22, 2021

route53 zone datesource - arn

b14e2b9

github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 22, 2021

ewbankkit approved these changes Aug 23, 2021

View reviewed changes

ewbankkit merged commit ddc12c8 into hashicorp:main Aug 23, 2021

github-actions bot added this to the v3.56.0 milestone Aug 23, 2021

DrFaust92 deleted the route53_zone_arn branch August 23, 2021 16:13

github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rd/route53_zone - add `arn` attribute #20652

rd/route53_zone - add `arn` attribute #20652

DrFaust92 commented Aug 22, 2021 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Aug 23, 2021

github-actions bot commented Aug 31, 2021

github-actions bot commented Jun 24, 2022

rd/route53_zone - add arn attribute #20652

rd/route53_zone - add arn attribute #20652

Conversation

DrFaust92 commented Aug 22, 2021 • edited Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Aug 23, 2021

github-actions bot commented Aug 31, 2021

github-actions bot commented Jun 24, 2022

rd/route53_zone - add `arn` attribute #20652

rd/route53_zone - add `arn` attribute #20652

DrFaust92 commented Aug 22, 2021 •

edited

Loading