Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elasticache_replication_group: Allows specifying and updating replica count on Global Replication Group members #20111

Merged
merged 3 commits into from
Jul 14, 2021
Merged

resource/aws_elasticache_replication_group: Allows specifying and updating replica count on Global Replication Group members #20111

merged 3 commits into from
Jul 14, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 8, 2021 •
edited
Loading

Currently, the replica count on a Global Replication Group member cannot be set using cluster_mode.replicas_per_node_group because setting global_replication_group_id incorrectly conflicts with cluster_mode.

Changes conflicts with setting to conflict with cluster_mode.num_node_groups.

Closes #19929
Closes #19053

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheGlobalReplicationGroup\|TestAccAWSElasticacheReplicationGroup'

--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover (14.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (662.77s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_disappears (809.08s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_Description (891.71s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (892.48s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (932.67s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1018.88s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_ClusterMode (1033.34s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (1.86s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1221.46s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1250.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1331.14s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1332.65s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1378.54s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (1537.76s)
--- PASS: TestAccAWSElasticacheReplicationGroup_disappears (1774.11s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (753.49s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1273.95s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1121.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1299.74s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (2527.59s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (2654.19s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (2711.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType (5.67s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup (1838.00s)
--- FAIL: TestAccAWSElasticacheGlobalReplicationGroup_ReplaceSecondary_DifferentRegion (3358.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (1470.89s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1591.16s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (2271.67s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode (1960.40s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (750.17s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (1235.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType (767.86s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp (2605.38s)
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (890.70s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (1129.10s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2114.60s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (1386.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_EngineVersion_Update (3696.51s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (1955.89s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (1365.84s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_MultipleSecondaries (3981.24s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary (1173.93s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown (3227.36s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (3640.57s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic (2313.79s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears (2209.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic (3164.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full (3194.13s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 8, 2021
@gdavison gdavison marked this pull request as ready for review July 9, 2021 17:55
@ewbankkit ewbankkit self-assigned this Jul 14, 2021
@ewbankkit
Copy link
Contributor

Commercial

% make testacc TESTARGS='-run=TestAccAWSElasticacheGlobalReplicationGroup\|TestAccAWSElasticacheReplicationGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheGlobalReplicationGroup\|TestAccAWSElasticacheReplicationGroup -timeout 180m
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_basic
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_basic
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_Description
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_Description
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_disappears
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_disappears
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_MultipleSecondaries
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_MultipleSecondaries
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_ReplaceSecondary_DifferentRegion
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_ReplaceSecondary_DifferentRegion
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_ClusterMode
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_ClusterMode
=== RUN   TestAccAWSElasticacheReplicationGroup_basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_basic
=== RUN   TestAccAWSElasticacheReplicationGroup_Uppercase
=== PAUSE TestAccAWSElasticacheReplicationGroup_Uppercase
=== RUN   TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
=== PAUSE TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
=== RUN   TestAccAWSElasticacheReplicationGroup_disappears
=== PAUSE TestAccAWSElasticacheReplicationGroup_disappears
=== RUN   TestAccAWSElasticacheReplicationGroup_updateDescription
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateDescription
=== RUN   TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
=== RUN   TestAccAWSElasticacheReplicationGroup_updateNodeSize
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateNodeSize
=== RUN   TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== RUN   TestAccAWSElasticacheReplicationGroup_vpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_vpc
=== RUN   TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
=== RUN   TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== RUN   TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== RUN   TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== PAUSE TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== RUN   TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== RUN   TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== PAUSE TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== RUN   TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== RUN   TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== RUN   TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== RUN   TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== PAUSE TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== RUN   TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== RUN   TestAccAWSElasticacheReplicationGroup_tags
=== PAUSE TestAccAWSElasticacheReplicationGroup_tags
=== RUN   TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== PAUSE TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== RUN   TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== RUN   TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== RUN   TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== RUN   TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== RUN   TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== RUN   TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== RUN   TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_basic
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== CONT  TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== CONT  TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== CONT  TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== CONT  TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== CONT  TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== CONT  TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== CONT  TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== CONT  TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (5.99s)
=== CONT  TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (651.01s)
=== CONT  TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover (1.84s)
=== CONT  TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (693.18s)
=== CONT  TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (824.04s)
=== CONT  TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (827.95s)
=== CONT  TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary (928.80s)
=== CONT  TestAccAWSElasticacheReplicationGroup_Uppercase
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (931.18s)
=== CONT  TestAccAWSElasticacheReplicationGroup_vpc
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode (1229.59s)
=== CONT  TestAccAWSElasticacheReplicationGroup_updateDescription
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (615.74s)
=== CONT  TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (1647.18s)
=== CONT  TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (1673.32s)
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (742.80s)
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1799.81s)
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (1927.53s)
=== CONT  TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (734.92s)
=== CONT  TestAccAWSElasticacheReplicationGroup_FinalSnapshot
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2069.19s)
=== CONT  TestAccAWSElasticacheReplicationGroup_updateNodeSize
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (2101.68s)
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_ReplaceSecondary_DifferentRegion
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears (2098.60s)
=== CONT  TestAccAWSElasticacheReplicationGroup_disappears
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic (2126.61s)
=== CONT  TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup (2241.01s)
=== CONT  TestAccAWSElasticacheReplicationGroup_basic
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (705.14s)
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_ClusterMode
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1623.20s)
=== CONT  TestAccAWSElasticacheReplicationGroup_tags
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (707.99s)
=== CONT  TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2573.64s)
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_Description
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (747.39s)
=== CONT  TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType (2.79s)
=== CONT  TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (2680.98s)
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_MultipleSecondaries
--- PASS: TestAccAWSElasticacheReplicationGroup_disappears (605.72s)
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_disappears
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (754.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1108.17s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType (682.44s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (589.93s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp (3087.43s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (782.90s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown (3148.27s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (2330.30s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_Description (861.99s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_ClusterMode (1197.83s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_disappears (744.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full (2717.42s)
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_ReplaceSecondary_DifferentRegion
    resource_aws_elasticache_global_replication_group_test.go:259: Step 2/2 error: Error running apply: exit status 1
        2021/07/14 10:13:54 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: Error creating ElastiCache Replication Group (tf-acc-test-2313420090804203609-t): InvalidGlobalReplicationGroupState: Global Replication Group is not in a valid state to perform this operation. Please retry when the Global Replication Group is in "available" or "primary-only" state.
        	status code: 400, request id: fe72ef4b-8f2c-4999-bd27-2fe60bae3fb0
        
          on terraform_plugin_test.tf line 134, in resource "aws_elasticache_replication_group" "third":
         134: resource "aws_elasticache_replication_group" "third" {
        
        
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1576.94s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic (3196.78s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (2072.54s)
--- FAIL: TestAccAWSElasticacheGlobalReplicationGroup_ReplaceSecondary_DifferentRegion (1892.73s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (2332.49s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (1360.99s)
--- PASS: TestAccAWSElasticacheReplicationGroup_EngineVersion_Update (2638.60s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_MultipleSecondaries (2759.45s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	5443.710s
FAIL
make: *** [testacc] Error 1

The code changes LGTM.
It doesn't look like the failure has anything to do with this change?

@ewbankkit ewbankkit removed their assignment Jul 14, 2021
@gdavison
Copy link
Contributor Author

No, it's not related. I've created #20180

@gdavison gdavison merged commit 2471586 into main Jul 14, 2021
@gdavison gdavison deleted the modify-global-replication-members branch July 14, 2021 16:18
@github-actions github-actions bot added this to the v3.50.0 milestone Jul 14, 2021
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Update CHANGELOG.md for #20111
64522c1
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.50.0
2 participants
@gdavison @ewbankkit