Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/neptune_cluster_endpoint - new resource #19898

Merged
merged 5 commits into from
Jun 22, 2021
Merged

r/neptune_cluster_endpoint - new resource #19898

merged 5 commits into from
Jun 22, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 19, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16498

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSNeptuneClusterEndpoint_'
--- PASS: TestAccAWSNeptuneClusterEndpoint_basic (249.91s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_tags (298.03s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_disappears (186.76s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_disappears_cluster (191.24s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/neptune Issues and PRs that pertain to the neptune service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jun 19, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jun 19, 2021
ewbankkit
ewbankkit approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneClusterEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNeptuneClusterEndpoint_ -timeout 180m
=== RUN   TestAccAWSNeptuneClusterEndpoint_basic
=== PAUSE TestAccAWSNeptuneClusterEndpoint_basic
=== RUN   TestAccAWSNeptuneClusterEndpoint_tags
=== PAUSE TestAccAWSNeptuneClusterEndpoint_tags
=== RUN   TestAccAWSNeptuneClusterEndpoint_disappears
=== PAUSE TestAccAWSNeptuneClusterEndpoint_disappears
=== RUN   TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== PAUSE TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== CONT  TestAccAWSNeptuneClusterEndpoint_basic
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears
=== CONT  TestAccAWSNeptuneClusterEndpoint_tags
--- PASS: TestAccAWSNeptuneClusterEndpoint_disappears_cluster (153.56s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_basic (194.09s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_disappears (212.02s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_tags (230.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	233.199s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneClusterEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNeptuneClusterEndpoint_ -timeout 180m
=== RUN   TestAccAWSNeptuneClusterEndpoint_basic
=== PAUSE TestAccAWSNeptuneClusterEndpoint_basic
=== RUN   TestAccAWSNeptuneClusterEndpoint_tags
    resource_aws_neptune_cluster_endpoint_test.go:52: Neptune Cluster Endpoint tags are not supported in GovCloud partition
--- SKIP: TestAccAWSNeptuneClusterEndpoint_tags (0.00s)
=== RUN   TestAccAWSNeptuneClusterEndpoint_disappears
=== PAUSE TestAccAWSNeptuneClusterEndpoint_disappears
=== RUN   TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== PAUSE TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== CONT  TestAccAWSNeptuneClusterEndpoint_basic
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears
--- PASS: TestAccAWSNeptuneClusterEndpoint_disappears_cluster (189.05s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_disappears (215.43s)
--- PASS: TestAccAWSNeptuneClusterEndpoint_basic (218.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	222.595s

@ewbankkit ewbankkit force-pushed the r/neptune_endpoint branch from 8b11447 to 4be2635 Compare June 22, 2021 14:30
@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 22, 2021 •
edited
Loading

@DrFaust92 Thanks for the contribution 🎉 👏.
I pushed a change to prevent resource tagging on GovCloud as it's not supported:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneClusterEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNeptuneClusterEndpoint_ -timeout 180m
=== RUN   TestAccAWSNeptuneClusterEndpoint_basic
=== PAUSE TestAccAWSNeptuneClusterEndpoint_basic
=== RUN   TestAccAWSNeptuneClusterEndpoint_tags
=== PAUSE TestAccAWSNeptuneClusterEndpoint_tags
=== RUN   TestAccAWSNeptuneClusterEndpoint_disappears
=== PAUSE TestAccAWSNeptuneClusterEndpoint_disappears
=== RUN   TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== PAUSE TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== CONT  TestAccAWSNeptuneClusterEndpoint_basic
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears_cluster
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears
=== CONT  TestAccAWSNeptuneClusterEndpoint_tags
    resource_aws_neptune_cluster_endpoint_test.go:55: Step 1/4 error: Error running apply: exit status 1
        2021/06/22 09:10:26 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Neptune Cluster Endpoint: InvalidParameterValue: Tagging endpoints is currently not available
        	status code: 400, request id: 33f172cb-a38f-43ab-8a18-3d9be7343d2a
        
          on terraform_plugin_test.tf line 23, in resource "aws_neptune_cluster_endpoint" "test":
          23: resource "aws_neptune_cluster_endpoint" "test" {
        
        
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears_cluster
    resource_aws_neptune_cluster_endpoint_test.go:123: Step 1/1 error: Error running apply: exit status 1
        2021/06/22 09:10:25 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error listing tags for Neptune Cluster Endpoint (arn:aws-us-gov:rds:us-gov-west-1:123456789012:cluster-endpoint:tf-acc-6861387726977152976): InvalidParameterValue: The specified resource name does not match an RDS resource in this region.
        	status code: 400, request id: aee43e88-60c4-4982-9fe4-1dbfa84d14c9
        
          on terraform_plugin_test.tf line 23, in resource "aws_neptune_cluster_endpoint" "test":
          23: resource "aws_neptune_cluster_endpoint" "test" {
        
        
=== CONT  TestAccAWSNeptuneClusterEndpoint_disappears
    resource_aws_neptune_cluster_endpoint_test.go:100: Step 1/1 error: Error running apply: exit status 1
        2021/06/22 09:10:26 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error listing tags for Neptune Cluster Endpoint (arn:aws-us-gov:rds:us-gov-west-1:123456789012:cluster-endpoint:tf-acc-5278239131941194660): InvalidParameterValue: The specified resource name does not match an RDS resource in this region.
        	status code: 400, request id: 1dac2c3b-2437-40c4-b26c-6d6e33a3696e
        
          on terraform_plugin_test.tf line 23, in resource "aws_neptune_cluster_endpoint" "test":
          23: resource "aws_neptune_cluster_endpoint" "test" {
        
        
=== CONT  TestAccAWSNeptuneClusterEndpoint_basic
    resource_aws_neptune_cluster_endpoint_test.go:22: Step 1/2 error: Error running apply: exit status 1
        2021/06/22 09:10:25 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error listing tags for Neptune Cluster Endpoint (arn:aws-us-gov:rds:us-gov-west-1:123456789012:cluster-endpoint:tf-acc-2846851985467715782): InvalidParameterValue: The specified resource name does not match an RDS resource in this region.
        	status code: 400, request id: 6caa71bc-6225-42b0-bee6-2c6fc53b27c4
        
          on terraform_plugin_test.tf line 23, in resource "aws_neptune_cluster_endpoint" "test":
          23: resource "aws_neptune_cluster_endpoint" "test" {
        
        
--- FAIL: TestAccAWSNeptuneClusterEndpoint_tags (135.44s)
--- FAIL: TestAccAWSNeptuneClusterEndpoint_disappears (187.90s)
--- FAIL: TestAccAWSNeptuneClusterEndpoint_basic (188.06s)
--- FAIL: TestAccAWSNeptuneClusterEndpoint_disappears_cluster (209.03s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	212.095s
FAIL
make: *** [testacc] Error 1

@ewbankkit ewbankkit merged commit 278a3e8 into hashicorp:main Jun 22, 2021
@github-actions github-actions bot added this to the v3.47.0 milestone Jun 22, 2021
@DrFaust92 DrFaust92 deleted the r/neptune_endpoint branch June 22, 2021 19:03
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/neptune Issues and PRs that pertain to the neptune service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.47.0
Development

Successfully merging this pull request may close these issues.

New resource: aws_neptune_cluster_custom_endpoint
2 participants
@DrFaust92 @ewbankkit