Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/datasync_location_nfs - support update + add mount_options #19767

Merged
merged 4 commits into from
Jun 14, 2021
Merged

r/datasync_location_nfs - support update + add mount_options #19767

merged 4 commits into from
Jun 14, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 11, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14054

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSyncLocationNfs_'
--- PASS: TestAccAWSDataSyncLocationNfs_basic (254.52s)
--- PASS: TestAccAWSDataSyncLocationNfs_Subdirectory (351.00s)
--- PASS: TestAccAWSDataSyncLocationNfs_disappears (251.73s)
--- PASS: TestAccAWSDataSyncLocationNfs_AgentARNs_Multple (264.48s)
--- PASS: TestAccAWSDataSyncLocationNfs_mountOptions (324.74s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 11, 2021 10:13
@github-actions github-actions bot added service/datasync Issues and PRs that pertain to the datasync service. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jun 11, 2021
@DrFaust92 DrFaust92 removed the service/location Issues and PRs that pertain to the location service. label Jun 11, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/location Issues and PRs that pertain to the location service. and removed documentation Introduces or discusses updates to documentation. service/location Issues and PRs that pertain to the location service. labels Jun 11, 2021
@DrFaust92 DrFaust92 added the documentation Introduces or discusses updates to documentation. label Jun 11, 2021
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/location Issues and PRs that pertain to the location service. labels Jun 12, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@DrFaust92 DrFaust92 force-pushed the r/datasync_location_nfs_update branch from d576a79 to 9685f84 Compare June 12, 2021 19:44
@github-actions github-actions bot removed service/autoscaling Issues and PRs that pertain to the autoscaling service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jun 12, 2021
ewbankkit
ewbankkit approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncLocationNfs_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationNfs_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationNfs_basic
=== PAUSE TestAccAWSDataSyncLocationNfs_basic
=== RUN   TestAccAWSDataSyncLocationNfs_mountOptions
=== PAUSE TestAccAWSDataSyncLocationNfs_mountOptions
=== RUN   TestAccAWSDataSyncLocationNfs_disappears
=== PAUSE TestAccAWSDataSyncLocationNfs_disappears
=== RUN   TestAccAWSDataSyncLocationNfs_AgentARNs_Multple
=== PAUSE TestAccAWSDataSyncLocationNfs_AgentARNs_Multple
=== RUN   TestAccAWSDataSyncLocationNfs_Subdirectory
=== PAUSE TestAccAWSDataSyncLocationNfs_Subdirectory
=== RUN   TestAccAWSDataSyncLocationNfs_Tags
=== PAUSE TestAccAWSDataSyncLocationNfs_Tags
=== CONT  TestAccAWSDataSyncLocationNfs_basic
=== CONT  TestAccAWSDataSyncLocationNfs_Tags
=== CONT  TestAccAWSDataSyncLocationNfs_disappears
=== CONT  TestAccAWSDataSyncLocationNfs_mountOptions
=== CONT  TestAccAWSDataSyncLocationNfs_AgentARNs_Multple
=== CONT  TestAccAWSDataSyncLocationNfs_Subdirectory
--- PASS: TestAccAWSDataSyncLocationNfs_disappears (212.16s)
--- PASS: TestAccAWSDataSyncLocationNfs_basic (227.29s)
--- PASS: TestAccAWSDataSyncLocationNfs_AgentARNs_Multple (240.09s)
--- PASS: TestAccAWSDataSyncLocationNfs_Subdirectory (240.98s)
--- PASS: TestAccAWSDataSyncLocationNfs_mountOptions (256.27s)
--- PASS: TestAccAWSDataSyncLocationNfs_Tags (281.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	285.867s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncLocationNfs_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationNfs_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationNfs_basic
=== PAUSE TestAccAWSDataSyncLocationNfs_basic
=== RUN   TestAccAWSDataSyncLocationNfs_mountOptions
=== PAUSE TestAccAWSDataSyncLocationNfs_mountOptions
=== RUN   TestAccAWSDataSyncLocationNfs_disappears
=== PAUSE TestAccAWSDataSyncLocationNfs_disappears
=== RUN   TestAccAWSDataSyncLocationNfs_AgentARNs_Multple
=== PAUSE TestAccAWSDataSyncLocationNfs_AgentARNs_Multple
=== RUN   TestAccAWSDataSyncLocationNfs_Subdirectory
=== PAUSE TestAccAWSDataSyncLocationNfs_Subdirectory
=== RUN   TestAccAWSDataSyncLocationNfs_Tags
=== PAUSE TestAccAWSDataSyncLocationNfs_Tags
=== CONT  TestAccAWSDataSyncLocationNfs_basic
=== CONT  TestAccAWSDataSyncLocationNfs_Subdirectory
=== CONT  TestAccAWSDataSyncLocationNfs_AgentARNs_Multple
=== CONT  TestAccAWSDataSyncLocationNfs_Tags
=== CONT  TestAccAWSDataSyncLocationNfs_disappears
=== CONT  TestAccAWSDataSyncLocationNfs_mountOptions
--- PASS: TestAccAWSDataSyncLocationNfs_disappears (209.36s)
--- PASS: TestAccAWSDataSyncLocationNfs_AgentARNs_Multple (216.21s)
--- PASS: TestAccAWSDataSyncLocationNfs_basic (236.63s)
--- PASS: TestAccAWSDataSyncLocationNfs_mountOptions (245.85s)
--- PASS: TestAccAWSDataSyncLocationNfs_Subdirectory (272.91s)
--- PASS: TestAccAWSDataSyncLocationNfs_Tags (280.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	284.009s

@ewbankkit ewbankkit merged commit 24ab4e6 into hashicorp:main Jun 14, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 14, 2021
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
@DrFaust92 DrFaust92 deleted the r/datasync_location_nfs_update branch February 12, 2022 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/datasync Issues and PRs that pertain to the datasync service. service/location Issues and PRs that pertain to the location service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.46.0
Development

Successfully merging this pull request may close these issues.

aws_datasync_location_nfs unable to set NFS Version
2 participants
@DrFaust92 @ewbankkit