Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/fsx_lustre_filesystem - allow updating storage_capacity #19568

Merged
merged 3 commits into from
Jun 2, 2021
Merged

r/fsx_lustre_filesystem - allow updating storage_capacity #19568

merged 3 commits into from
Jun 2, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16958
Supersedes #17027

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_StorageCapacity'
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1558.47s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate (2953.24s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner May 28, 2021 14:18
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels May 28, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 28, 2021
@DrFaust92 DrFaust92 mentioned this pull request May 28, 2021
Closed
ewbankkit
ewbankkit approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_StorageCapacity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_StorageCapacity -timeout 180m
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacity
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1479.75s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate (2577.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2580.045s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_StorageCapacity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_StorageCapacity -timeout 180m
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacity
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1298.87s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate (2387.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2390.923s

@ewbankkit ewbankkit merged commit deccb39 into hashicorp:main Jun 2, 2021
@github-actions github-actions bot added this to the v3.44.0 milestone Jun 2, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/fsx_lustre_capacity branch June 4, 2021 16:37
@github-actions
Copy link

github-actions bot commented Jul 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.44.0
Development

Successfully merging this pull request may close these issues.

Allow update-in-place for aws_fsx_lustre_file_system storage_capacity
3 participants
@DrFaust92 @ewbankkit @mtpdt