Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/apprunner_service: add missing arguments in expansion methods #19471

Merged
merged 2 commits into from
May 24, 2021
Merged

resource/apprunner_service: add missing arguments in expansion methods #19471

merged 2 commits into from
May 24, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 21, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19469

Output from acceptance testing (commercial):

--- PASS: TestAccAwsAppRunnerService_ImageRepository_RuntimeEnvironmentVars (302.57s)

--- FAIL: TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration (8.46s) --> known failure (will create an issue for this one)
--- PASS: TestAccAwsAppRunnerService_disappears (206.59s)
--- PASS: TestAccAwsAppRunnerService_tags (239.63s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_basic (317.41s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration (351.27s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration (440.80s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration (459.00s)

Output from acceptance testing (gov cloud):

--- SKIP: TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration (19.62s)
--- SKIP: TestAccAwsAppRunnerService_ImageRepository_basic (19.79s)
--- SKIP: TestAccAwsAppRunnerService_ImageRepository_RuntimeEnvironmentVars (21.95s)
--- SKIP: TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration (22.92s)
--- SKIP: TestAccAwsAppRunnerService_disappears (23.32s)
--- SKIP: TestAccAwsAppRunnerService_tags (25.92s)
--- SKIP: TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration (26.65s)
--- SKIP: TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration (26.73s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels May 21, 2021
@github-actions github-actions bot added service/apprunner Issues and PRs that pertain to the apprunner service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 21, 2021
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label May 21, 2021
@anGie44 anGie44 force-pushed the b-apprunner-service-image-repo-missing-expand-args branch from 22edc59 to 16a1342 Compare May 21, 2021 15:51
@anGie44 anGie44 marked this pull request as ready for review May 21, 2021 16:01
@anGie44 anGie44 requested a review from a team as a code owner May 21, 2021 16:01
@ewbankkit ewbankkit self-assigned this May 24, 2021
ewbankkit
ewbankkit approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppRunnerService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppRunnerService_ -timeout 180m
=== RUN   TestAccAwsAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_basic
=== RUN   TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration
=== RUN   TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration
=== RUN   TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration
=== RUN   TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
=== RUN   TestAccAwsAppRunnerService_ImageRepository_RuntimeEnvironmentVars
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_RuntimeEnvironmentVars
=== RUN   TestAccAwsAppRunnerService_disappears
=== PAUSE TestAccAwsAppRunnerService_disappears
=== RUN   TestAccAwsAppRunnerService_tags
=== PAUSE TestAccAwsAppRunnerService_tags
=== CONT  TestAccAwsAppRunnerService_ImageRepository_basic
=== CONT  TestAccAwsAppRunnerService_ImageRepository_RuntimeEnvironmentVars
=== CONT  TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration
=== CONT  TestAccAwsAppRunnerService_disappears
=== CONT  TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration
=== CONT  TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
=== CONT  TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration
=== CONT  TestAccAwsAppRunnerService_tags
=== CONT  TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
    resource_aws_apprunner_service_test.go:237: Step 1/5 error: Error running apply: exit status 1
        2021/05/24 10:25:54 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating App Runner Service (tf-acc-test-6345267047958536322): InvalidRequestException: Error in assuming instance role arn:aws:iam::187416307283:role/tf-acc-test-6345267047958536322
        
          on terraform_plugin_test.tf line 58, in resource "aws_apprunner_service" "test":
          58: resource "aws_apprunner_service" "test" {
        
        
--- FAIL: TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration (10.89s)
--- PASS: TestAccAwsAppRunnerService_disappears (224.42s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_basic (259.18s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_RuntimeEnvironmentVars (260.84s)
--- PASS: TestAccAwsAppRunnerService_tags (264.25s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration (372.04s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration (500.42s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration (550.91s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	554.630s
FAIL
make: *** [testacc] Error 1

Known failure addressed via #19483.

@anGie44 anGie44 added this to the v3.43.0 milestone May 24, 2021
@anGie44 anGie44 merged commit 4c91471 into main May 24, 2021
@anGie44 anGie44 deleted the b-apprunner-service-image-repo-missing-expand-args branch May 24, 2021 16:12
github-actions bot pushed a commit that referenced this pull request May 24, 2021
Update CHANGELOG.md for #19471
3b05635
@timotas timotas mentioned this pull request Jun 1, 2021
Closed
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. service/apprunner Issues and PRs that pertain to the apprunner service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.43.0
Development

Successfully merging this pull request may close these issues.

Resource aws_apprunner_service does not use image_configuration.runtime_environment_variables
2 participants
@anGie44 @ewbankkit