-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lambda_function: Wait for successful completion of function code update #19386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Acceptance test results in region where the behaviour has been observed
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (92.38s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (214.65s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (288.78s)
--- PASS: TestAccAWSLambdaFunction_tags (194.93s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (171.44s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (173.42s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (164.18s)
--- PASS: TestAccAWSLambdaFunction_concurrency (137.37s)
--- PASS: TestAccAWSLambdaFunction_disappears (73.53s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (175.49s)
--- PASS: TestAccAWSLambdaFunction_basic (85.02s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (147.04s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (80.60s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (79.34s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (204.78s)
--- PASS: TestAccAWSLambdaFunction_runtimes (1128.69s)
--- PASS: TestAccAWSLambdaFunction_Layers (86.86s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (155.36s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (84.81s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (143.74s)
--- PASS: TestAccAWSLambdaFunction_VPC (477.47s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (44.43s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (269.58s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (262.65s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (139.62s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (189.20s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (652.42s)
--- PASS: TestAccAWSLambdaFunction_versioned (83.90s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (212.92s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (85.95s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (44.58s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (148.34s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (87.22s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (125.61s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (84.00s)
--- PASS: TestAccAWSLambdaFunction_envVariables (271.75s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (122.68s)
--- PASS: TestAccAWSLambdaFunction_s3 (97.37s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (80.85s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn (80.70s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (137.89s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (139.40s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (72.62s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (137.17s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (125.21s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (259.03s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (202.18s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (541.14s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (973.61s)
Acceptance test results in primary region
--- FAIL: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (60.64s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (73.38s)
--- PASS: TestAccAWSLambdaFunction_disappears (83.82s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (85.95s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (94.35s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn (99.89s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (39.84s)
--- PASS: TestAccAWSLambdaFunction_basic (103.68s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (105.03s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (105.07s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (105.87s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (106.11s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (130.68s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.93s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (31.82s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (139.49s)
--- PASS: TestAccAWSLambdaFunction_concurrency (145.01s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (146.83s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (149.13s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (150.65s)
--- FAIL: TestAccAWSLambdaFunction_versioned (55.32s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (156.40s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (85.44s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (174.94s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (185.93s)
--- FAIL: TestAccAWSLambdaFunction_VPC (46.28s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (123.28s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (72.33s)
--- PASS: TestAccAWSLambdaFunction_Layers (76.03s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (118.77s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (121.46s)
--- PASS: TestFlattenLambdaImageConfigShouldNotFailWithEmptyImageConfig (0.00s)
--- PASS: TestAccAWSLambdaFunction_s3 (55.84s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (63.38s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (103.62s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (137.13s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (145.84s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (104.81s)
--- PASS: TestAccAWSLambdaFunction_envVariables (181.92s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (71.90s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (83.28s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (62.86s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (68.53s)
--- PASS: TestAccAWSLambdaFunction_tags (76.53s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (218.47s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (250.18s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (269.15s)
--- PASS: TestAccAWSLambdaFunction_runtimes (338.90s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1552.49s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1709.71s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1951.78s)
Acceptance test results in GovCloud
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (97.43s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (167.07s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (211.68s)
--- PASS: TestAccAWSLambdaFunction_disappears (225.61s)
--- PASS: TestAccAWSLambdaFunction_versioned (249.62s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)
--- PASS: TestAccAWSLambdaFunction_basic (254.60s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (302.16s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (311.37s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn (245.15s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (179.00s)
--- PASS: TestAccAWSLambdaFunction_concurrency (380.73s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (384.12s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (402.30s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (422.35s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (422.85s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (432.36s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (435.91s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (437.42s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (444.76s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (450.94s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (494.31s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (287.86s)
--- PASS: TestAccAWSLambdaFunction_envVariables (537.01s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (203.67s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (153.15s)
--- PASS: TestAccAWSLambdaFunction_s3 (63.72s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (366.39s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (318.59s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (426.25s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (425.18s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (518.36s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (405.09s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (318.10s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (468.85s)
--- PASS: TestAccAWSLambdaFunction_tags (558.78s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (406.13s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (414.39s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (693.50s)
--- PASS: TestAccAWSLambdaFunction_VPC (691.79s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (499.37s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (777.06s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (780.27s)
--- PASS: TestAccAWSLambdaFunction_Layers (470.70s)
--- PASS: TestAccAWSLambdaFunction_runtimes (1048.94s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (826.81s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1686.25s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (2181.91s)
This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
There are scenarios where failing to wait for successful completion of updates to a Lambda function's code results in Terraform diffs suggesting that the resources needs to be recreated:
This PR adds a wait for
LastUpdateStatusSuccessful
after function code update.Output from acceptance testing:
Commercial
GovCloud