-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SecurityHub Organization Configuration Resource #19108
Add SecurityHub Organization Configuration Resource #19108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @djsd123 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Addresses Issue #17287 |
@djsd123 Thanks for the contribution 🎉 👏.
|
Hi @ewbankkit, Thanks for the review. I've added you to the repo as a collaborator. However, I will go ahead and make the amendments and ping you shortly. |
Hello again @ewbankkit, That's done. Thanks for the suggestions. I'll note what you did to inform any potential PRs in the future. 💯 |
Resource to enable security hub's auto-enroll feature when apart of an organization and a security hub admin account has been configured. By default the **Auto-Enable** feature is disabled. See: [Automatically enabling new organization accounts](https://docs.aws.amazon.com/securityhub/latest/userguide/accounts-orgs-auto-enable.html) [method]: https://docs.aws.amazon.com/sdk-for-go/api/service/securityhub/#SecurityHub.UpdateOrganizationConfiguration [input]: https://docs.aws.amazon.com/sdk-for-go/api/service/securityhub/#UpdateOrganizationConfigurationInput Refactored with amendments suggested by @ewbankkit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSSecurityHub_serial/OrganizationConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSecurityHub_serial/OrganizationConfiguration -timeout 180m
=== RUN TestAccAWSSecurityHub_serial
=== RUN TestAccAWSSecurityHub_serial/OrganizationConfiguration
=== RUN TestAccAWSSecurityHub_serial/OrganizationConfiguration/basic
--- PASS: TestAccAWSSecurityHub_serial (31.10s)
--- PASS: TestAccAWSSecurityHub_serial/OrganizationConfiguration (31.10s)
--- PASS: TestAccAWSSecurityHub_serial/OrganizationConfiguration/basic (31.10s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 34.162s
This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Relates to this [Pull Request](#19108) The example doesn't include required parameter `auto_enable = true`
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Resource to enable security hub's auto-enroll feature when apart of an
organization and a security hub admin account has been configured.
By default the Auto-Enable feature is disabled. See: Automatically enabling new organization accounts
Community Note
Closes #17287
Output from acceptance testing: