r/aws_kms_key: Support policy lockout check bypass #18117

tism · 2021-03-16T05:57:47Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSKmsKey_'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsKey_ -timeout 120m
=== RUN   TestAccAWSKmsKey_basic
=== PAUSE TestAccAWSKmsKey_basic
=== RUN   TestAccAWSKmsKey_asymmetricKey
=== PAUSE TestAccAWSKmsKey_asymmetricKey
=== RUN   TestAccAWSKmsKey_disappears
=== PAUSE TestAccAWSKmsKey_disappears
=== RUN   TestAccAWSKmsKey_policy
=== PAUSE TestAccAWSKmsKey_policy
=== RUN   TestAccAWSKmsKey_policyBypass
=== PAUSE TestAccAWSKmsKey_policyBypass
=== RUN   TestAccAWSKmsKey_policyBypassUpdate
=== PAUSE TestAccAWSKmsKey_policyBypassUpdate
=== RUN   TestAccAWSKmsKey_Policy_IamRole
=== PAUSE TestAccAWSKmsKey_Policy_IamRole
=== RUN   TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== PAUSE TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== RUN   TestAccAWSKmsKey_isEnabled
=== PAUSE TestAccAWSKmsKey_isEnabled
=== RUN   TestAccAWSKmsKey_tags
=== PAUSE TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_basic
=== CONT  TestAccAWSKmsKey_Policy_IamRole
=== CONT  TestAccAWSKmsKey_policy
=== CONT  TestAccAWSKmsKey_policyBypass
=== CONT  TestAccAWSKmsKey_disappears
=== CONT  TestAccAWSKmsKey_isEnabled
=== CONT  TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== CONT  TestAccAWSKmsKey_asymmetricKey
=== CONT  TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_policyBypassUpdate
--- PASS: TestAccAWSKmsKey_disappears (29.68s)
--- PASS: TestAccAWSKmsKey_asymmetricKey (38.60s)
--- PASS: TestAccAWSKmsKey_basic (45.51s)
--- PASS: TestAccAWSKmsKey_Policy_IamRole (64.45s)
--- PASS: TestAccAWSKmsKey_Policy_IamServiceLinkedRole (69.81s)
--- PASS: TestAccAWSKmsKey_policyBypassUpdate (73.57s)
--- PASS: TestAccAWSKmsKey_tags (78.57s)
--- PASS: TestAccAWSKmsKey_policy (79.04s)
--- PASS: TestAccAWSKmsKey_policyBypass (180.87s)
--- PASS: TestAccAWSKmsKey_isEnabled (374.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	377.132s

Oddly if I run the acceptance tests from main in ap-southeast-2 both TestAccAWSKmsKey_policy and TestAccAWSKmsKey_tags both fail, but somewhat intermittently. Works fine on us-west-2.

Acceptance test output: % make testacc TESTARGS='-run=TestAccAWSKmsAlias_\|TestAccAWSEBSDefaultKmsKey_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsAlias_\|TestAccAWSEBSDefaultKmsKey_basic -timeout 180m === RUN TestAccAWSEBSDefaultKmsKey_basic === PAUSE TestAccAWSEBSDefaultKmsKey_basic === RUN TestAccAWSKmsAlias_basic === PAUSE TestAccAWSKmsAlias_basic === RUN TestAccAWSKmsAlias_disappears === PAUSE TestAccAWSKmsAlias_disappears === RUN TestAccAWSKmsAlias_Name_Generated === PAUSE TestAccAWSKmsAlias_Name_Generated === RUN TestAccAWSKmsAlias_NamePrefix === PAUSE TestAccAWSKmsAlias_NamePrefix === RUN TestAccAWSKmsAlias_UpdateKeyID === PAUSE TestAccAWSKmsAlias_UpdateKeyID === RUN TestAccAWSKmsAlias_MultipleAliasesForSameKey === PAUSE TestAccAWSKmsAlias_MultipleAliasesForSameKey === RUN TestAccAWSKmsAlias_ArnDiffSuppress === PAUSE TestAccAWSKmsAlias_ArnDiffSuppress === CONT TestAccAWSEBSDefaultKmsKey_basic === CONT TestAccAWSKmsAlias_UpdateKeyID === CONT TestAccAWSKmsAlias_ArnDiffSuppress === CONT TestAccAWSKmsAlias_MultipleAliasesForSameKey === CONT TestAccAWSKmsAlias_Name_Generated === CONT TestAccAWSKmsAlias_disappears === CONT TestAccAWSKmsAlias_NamePrefix === CONT TestAccAWSKmsAlias_basic --- PASS: TestAccAWSKmsAlias_disappears (20.97s) --- PASS: TestAccAWSKmsAlias_Name_Generated (23.93s) --- PASS: TestAccAWSKmsAlias_basic (23.96s) --- PASS: TestAccAWSKmsAlias_NamePrefix (24.19s) --- PASS: TestAccAWSKmsAlias_MultipleAliasesForSameKey (24.28s) --- PASS: TestAccAWSEBSDefaultKmsKey_basic (24.39s) --- PASS: TestAccAWSKmsAlias_ArnDiffSuppress (31.42s) --- PASS: TestAccAWSKmsAlias_UpdateKeyID (35.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 39.542s

Acceptance test output: % make testacc TESTARGS='-run=TestAccDataSourceAwsKmsAlias_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsKmsAlias_ -timeout 180m === RUN TestAccDataSourceAwsKmsAlias_AwsService === PAUSE TestAccDataSourceAwsKmsAlias_AwsService === RUN TestAccDataSourceAwsKmsAlias_CMK === PAUSE TestAccDataSourceAwsKmsAlias_CMK === CONT TestAccDataSourceAwsKmsAlias_AwsService === CONT TestAccDataSourceAwsKmsAlias_CMK --- PASS: TestAccDataSourceAwsKmsAlias_AwsService (12.56s) --- PASS: TestAccDataSourceAwsKmsAlias_CMK (21.23s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 24.461s

…ment. Acceptance test output: % make testacc TESTARGS='-run=TestAccAWSKmsExternalKey_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsExternalKey_ -timeout 180m === RUN TestAccAWSKmsExternalKey_basic === PAUSE TestAccAWSKmsExternalKey_basic === RUN TestAccAWSKmsExternalKey_disappears === PAUSE TestAccAWSKmsExternalKey_disappears === RUN TestAccAWSKmsExternalKey_DeletionWindowInDays === PAUSE TestAccAWSKmsExternalKey_DeletionWindowInDays === RUN TestAccAWSKmsExternalKey_Description === PAUSE TestAccAWSKmsExternalKey_Description === RUN TestAccAWSKmsExternalKey_Enabled === PAUSE TestAccAWSKmsExternalKey_Enabled === RUN TestAccAWSKmsExternalKey_KeyMaterialBase64 === PAUSE TestAccAWSKmsExternalKey_KeyMaterialBase64 === RUN TestAccAWSKmsExternalKey_Policy === PAUSE TestAccAWSKmsExternalKey_Policy === RUN TestAccAWSKmsExternalKey_PolicyBypass === PAUSE TestAccAWSKmsExternalKey_PolicyBypass === RUN TestAccAWSKmsExternalKey_Tags === PAUSE TestAccAWSKmsExternalKey_Tags === RUN TestAccAWSKmsExternalKey_ValidTo === PAUSE TestAccAWSKmsExternalKey_ValidTo === CONT TestAccAWSKmsExternalKey_basic === CONT TestAccAWSKmsExternalKey_Policy === CONT TestAccAWSKmsExternalKey_Description === CONT TestAccAWSKmsExternalKey_Enabled === CONT TestAccAWSKmsExternalKey_disappears === CONT TestAccAWSKmsExternalKey_ValidTo === CONT TestAccAWSKmsExternalKey_Tags === CONT TestAccAWSKmsExternalKey_PolicyBypass === CONT TestAccAWSKmsExternalKey_KeyMaterialBase64 === CONT TestAccAWSKmsExternalKey_DeletionWindowInDays --- PASS: TestAccAWSKmsExternalKey_disappears (17.41s) --- PASS: TestAccAWSKmsExternalKey_basic (26.35s) --- PASS: TestAccAWSKmsExternalKey_PolicyBypass (26.47s) --- PASS: TestAccAWSKmsExternalKey_Description (38.35s) --- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (38.49s) --- PASS: TestAccAWSKmsExternalKey_Policy (42.59s) --- PASS: TestAccAWSKmsExternalKey_Tags (50.91s) --- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (108.03s) --- PASS: TestAccAWSKmsExternalKey_ValidTo (179.40s) --- PASS: TestAccAWSKmsExternalKey_Enabled (205.79s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 210.650s

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSKmsExternalKey_\|TestAccDataSourceAwsKmsAlias_\|TestAccAWSKmsAlias_\|TestAccAWSKmsKey_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsExternalKey_\|TestAccDataSourceAwsKmsAlias_\|TestAccAWSKmsAlias_\|TestAccAWSKmsKey_ -timeout 180m
=== RUN   TestAccDataSourceAwsKmsAlias_AwsService
=== PAUSE TestAccDataSourceAwsKmsAlias_AwsService
=== RUN   TestAccDataSourceAwsKmsAlias_CMK
=== PAUSE TestAccDataSourceAwsKmsAlias_CMK
=== RUN   TestAccAWSKmsAlias_basic
=== PAUSE TestAccAWSKmsAlias_basic
=== RUN   TestAccAWSKmsAlias_disappears
=== PAUSE TestAccAWSKmsAlias_disappears
=== RUN   TestAccAWSKmsAlias_Name_Generated
=== PAUSE TestAccAWSKmsAlias_Name_Generated
=== RUN   TestAccAWSKmsAlias_NamePrefix
=== PAUSE TestAccAWSKmsAlias_NamePrefix
=== RUN   TestAccAWSKmsAlias_UpdateKeyID
=== PAUSE TestAccAWSKmsAlias_UpdateKeyID
=== RUN   TestAccAWSKmsAlias_MultipleAliasesForSameKey
=== PAUSE TestAccAWSKmsAlias_MultipleAliasesForSameKey
=== RUN   TestAccAWSKmsAlias_ArnDiffSuppress
=== PAUSE TestAccAWSKmsAlias_ArnDiffSuppress
=== RUN   TestAccAWSKmsExternalKey_basic
=== PAUSE TestAccAWSKmsExternalKey_basic
=== RUN   TestAccAWSKmsExternalKey_disappears
=== PAUSE TestAccAWSKmsExternalKey_disappears
=== RUN   TestAccAWSKmsExternalKey_DeletionWindowInDays
=== PAUSE TestAccAWSKmsExternalKey_DeletionWindowInDays
=== RUN   TestAccAWSKmsExternalKey_Description
=== PAUSE TestAccAWSKmsExternalKey_Description
=== RUN   TestAccAWSKmsExternalKey_Enabled
=== PAUSE TestAccAWSKmsExternalKey_Enabled
=== RUN   TestAccAWSKmsExternalKey_KeyMaterialBase64
=== PAUSE TestAccAWSKmsExternalKey_KeyMaterialBase64
=== RUN   TestAccAWSKmsExternalKey_Policy
=== PAUSE TestAccAWSKmsExternalKey_Policy
=== RUN   TestAccAWSKmsExternalKey_PolicyBypass
=== PAUSE TestAccAWSKmsExternalKey_PolicyBypass
=== RUN   TestAccAWSKmsExternalKey_Tags
=== PAUSE TestAccAWSKmsExternalKey_Tags
=== RUN   TestAccAWSKmsExternalKey_ValidTo
=== PAUSE TestAccAWSKmsExternalKey_ValidTo
=== RUN   TestAccAWSKmsKey_basic
=== PAUSE TestAccAWSKmsKey_basic
=== RUN   TestAccAWSKmsKey_asymmetricKey
=== PAUSE TestAccAWSKmsKey_asymmetricKey
=== RUN   TestAccAWSKmsKey_disappears
=== PAUSE TestAccAWSKmsKey_disappears
=== RUN   TestAccAWSKmsKey_policy
=== PAUSE TestAccAWSKmsKey_policy
=== RUN   TestAccAWSKmsKey_policyBypass
=== PAUSE TestAccAWSKmsKey_policyBypass
=== RUN   TestAccAWSKmsKey_policyBypassUpdate
=== PAUSE TestAccAWSKmsKey_policyBypassUpdate
=== RUN   TestAccAWSKmsKey_Policy_IamRole
=== PAUSE TestAccAWSKmsKey_Policy_IamRole
=== RUN   TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== PAUSE TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== RUN   TestAccAWSKmsKey_isEnabled
=== PAUSE TestAccAWSKmsKey_isEnabled
=== RUN   TestAccAWSKmsKey_tags
=== PAUSE TestAccAWSKmsKey_tags
=== CONT  TestAccDataSourceAwsKmsAlias_AwsService
=== CONT  TestAccAWSKmsAlias_ArnDiffSuppress
=== CONT  TestAccAWSKmsAlias_disappears
=== CONT  TestAccAWSKmsKey_asymmetricKey
=== CONT  TestAccAWSKmsExternalKey_Policy
=== CONT  TestAccAWSKmsAlias_Name_Generated
=== CONT  TestAccAWSKmsKey_policy
=== CONT  TestAccAWSKmsKey_disappears
=== CONT  TestAccAWSKmsAlias_basic
=== CONT  TestAccAWSKmsExternalKey_KeyMaterialBase64
=== CONT  TestAccAWSKmsExternalKey_Enabled
=== CONT  TestAccAWSKmsExternalKey_Description
=== CONT  TestAccAWSKmsExternalKey_DeletionWindowInDays
=== CONT  TestAccAWSKmsExternalKey_disappears
=== CONT  TestAccAWSKmsAlias_MultipleAliasesForSameKey
=== CONT  TestAccAWSKmsKey_policyBypass
=== CONT  TestAccAWSKmsExternalKey_ValidTo
=== CONT  TestAccAWSKmsExternalKey_basic
=== CONT  TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== CONT  TestAccAWSKmsKey_basic
--- PASS: TestAccDataSourceAwsKmsAlias_AwsService (57.21s)
=== CONT  TestAccAWSKmsAlias_UpdateKeyID
--- PASS: TestAccAWSKmsExternalKey_disappears (63.66s)
=== CONT  TestAccAWSKmsKey_Policy_IamRole
--- PASS: TestAccAWSKmsKey_disappears (66.05s)
=== CONT  TestAccAWSKmsKey_tags
--- PASS: TestAccAWSKmsKey_asymmetricKey (74.90s)
=== CONT  TestAccDataSourceAwsKmsAlias_CMK
--- PASS: TestAccAWSKmsAlias_disappears (78.97s)
=== CONT  TestAccAWSKmsKey_isEnabled
--- PASS: TestAccAWSKmsExternalKey_basic (83.84s)
=== CONT  TestAccAWSKmsKey_policyBypassUpdate
--- PASS: TestAccAWSKmsKey_basic (88.40s)
=== CONT  TestAccAWSKmsExternalKey_Tags
--- PASS: TestAccAWSKmsAlias_basic (91.06s)
=== CONT  TestAccAWSKmsExternalKey_PolicyBypass
--- PASS: TestAccAWSKmsAlias_Name_Generated (93.53s)
=== CONT  TestAccAWSKmsAlias_NamePrefix
--- PASS: TestAccAWSKmsAlias_MultipleAliasesForSameKey (97.45s)
=== CONT  TestAccAWSKmsExternalKey_Enabled
--- PASS: TestAccAWSKmsExternalKey_Enabled (276.58s)
--- PASS: TestAccAWSKmsKey_Policy_IamServiceLinkedRole (123.86s)
--- PASS: TestAccAWSKmsAlias_ArnDiffSuppress (130.98s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (138.40s)
--- PASS: TestAccAWSKmsKey_policy (143.96s)
--- PASS: TestAccAWSKmsExternalKey_Description (148.19s)
--- PASS: TestAccAWSKmsExternalKey_Policy (148.36s)
--- PASS: TestAccDataSourceAwsKmsAlias_CMK (73.84s)
--- PASS: TestAccAWSKmsExternalKey_PolicyBypass (66.76s)
--- PASS: TestAccAWSKmsAlias_NamePrefix (65.38s)
--- PASS: TestAccAWSKmsKey_Policy_IamRole (97.58s)
--- PASS: TestAccAWSKmsAlias_UpdateKeyID (109.54s)
--- PASS: TestAccAWSKmsKey_policyBypassUpdate (91.69s)
--- PASS: TestAccAWSKmsKey_policyBypass (183.78s)
--- PASS: TestAccAWSKmsExternalKey_Tags (110.76s)
--- PASS: TestAccAWSKmsKey_tags (133.46s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (203.73s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (247.03s)
--- PASS: TestAccAWSKmsKey_isEnabled (186.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	279.534s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSKmsExternalKey_\|TestAccDataSourceAwsKmsAlias_\|TestAccAWSKmsAlias_\|TestAccAWSKmsKey_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsExternalKey_\|TestAccDataSourceAwsKmsAlias_\|TestAccAWSKmsAlias_\|TestAccAWSKmsKey_ -timeout 180m
=== RUN   TestAccDataSourceAwsKmsAlias_AwsService
=== PAUSE TestAccDataSourceAwsKmsAlias_AwsService
=== RUN   TestAccDataSourceAwsKmsAlias_CMK
=== PAUSE TestAccDataSourceAwsKmsAlias_CMK
=== RUN   TestAccAWSKmsAlias_basic
=== PAUSE TestAccAWSKmsAlias_basic
=== RUN   TestAccAWSKmsAlias_disappears
=== PAUSE TestAccAWSKmsAlias_disappears
=== RUN   TestAccAWSKmsAlias_Name_Generated
=== PAUSE TestAccAWSKmsAlias_Name_Generated
=== RUN   TestAccAWSKmsAlias_NamePrefix
=== PAUSE TestAccAWSKmsAlias_NamePrefix
=== RUN   TestAccAWSKmsAlias_UpdateKeyID
=== PAUSE TestAccAWSKmsAlias_UpdateKeyID
=== RUN   TestAccAWSKmsAlias_MultipleAliasesForSameKey
=== PAUSE TestAccAWSKmsAlias_MultipleAliasesForSameKey
=== RUN   TestAccAWSKmsAlias_ArnDiffSuppress
=== PAUSE TestAccAWSKmsAlias_ArnDiffSuppress
=== RUN   TestAccAWSKmsExternalKey_basic
=== PAUSE TestAccAWSKmsExternalKey_basic
=== RUN   TestAccAWSKmsExternalKey_disappears
=== PAUSE TestAccAWSKmsExternalKey_disappears
=== RUN   TestAccAWSKmsExternalKey_DeletionWindowInDays
=== PAUSE TestAccAWSKmsExternalKey_DeletionWindowInDays
=== RUN   TestAccAWSKmsExternalKey_Description
=== PAUSE TestAccAWSKmsExternalKey_Description
=== RUN   TestAccAWSKmsExternalKey_Enabled
=== PAUSE TestAccAWSKmsExternalKey_Enabled
=== RUN   TestAccAWSKmsExternalKey_KeyMaterialBase64
=== PAUSE TestAccAWSKmsExternalKey_KeyMaterialBase64
=== RUN   TestAccAWSKmsExternalKey_Policy
=== PAUSE TestAccAWSKmsExternalKey_Policy
=== RUN   TestAccAWSKmsExternalKey_PolicyBypass
=== PAUSE TestAccAWSKmsExternalKey_PolicyBypass
=== RUN   TestAccAWSKmsExternalKey_Tags
=== PAUSE TestAccAWSKmsExternalKey_Tags
=== RUN   TestAccAWSKmsExternalKey_ValidTo
=== PAUSE TestAccAWSKmsExternalKey_ValidTo
=== RUN   TestAccAWSKmsKey_basic
=== PAUSE TestAccAWSKmsKey_basic
=== RUN   TestAccAWSKmsKey_asymmetricKey
=== PAUSE TestAccAWSKmsKey_asymmetricKey
=== RUN   TestAccAWSKmsKey_disappears
=== PAUSE TestAccAWSKmsKey_disappears
=== RUN   TestAccAWSKmsKey_policy
=== PAUSE TestAccAWSKmsKey_policy
=== RUN   TestAccAWSKmsKey_policyBypass
=== PAUSE TestAccAWSKmsKey_policyBypass
=== RUN   TestAccAWSKmsKey_policyBypassUpdate
=== PAUSE TestAccAWSKmsKey_policyBypassUpdate
=== RUN   TestAccAWSKmsKey_Policy_IamRole
=== PAUSE TestAccAWSKmsKey_Policy_IamRole
=== RUN   TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== PAUSE TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== RUN   TestAccAWSKmsKey_isEnabled
=== PAUSE TestAccAWSKmsKey_isEnabled
=== RUN   TestAccAWSKmsKey_tags
=== PAUSE TestAccAWSKmsKey_tags
=== CONT  TestAccDataSourceAwsKmsAlias_AwsService
=== CONT  TestAccAWSKmsExternalKey_Policy
=== CONT  TestAccAWSKmsKey_policyBypass
=== CONT  TestAccAWSKmsKey_asymmetricKey
=== CONT  TestAccAWSKmsAlias_ArnDiffSuppress
=== CONT  TestAccAWSKmsExternalKey_KeyMaterialBase64
=== CONT  TestAccAWSKmsExternalKey_Enabled
=== CONT  TestAccAWSKmsExternalKey_Description
=== CONT  TestAccAWSKmsExternalKey_DeletionWindowInDays
=== CONT  TestAccAWSKmsExternalKey_disappears
=== CONT  TestAccAWSKmsExternalKey_basic
=== CONT  TestAccAWSKmsExternalKey_Tags
=== CONT  TestAccAWSKmsExternalKey_ValidTo
=== CONT  TestAccAWSKmsKey_basic
=== CONT  TestAccAWSKmsKey_policy
=== CONT  TestAccAWSKmsKey_disappears
=== CONT  TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsExternalKey_PolicyBypass
=== CONT  TestAccAWSKmsAlias_basic
=== CONT  TestAccAWSKmsAlias_Name_Generated
--- PASS: TestAccDataSourceAwsKmsAlias_AwsService (62.45s)
=== CONT  TestAccAWSKmsKey_isEnabled
--- PASS: TestAccAWSKmsExternalKey_disappears (66.94s)
=== CONT  TestAccAWSKmsKey_Policy_IamServiceLinkedRole
--- PASS: TestAccAWSKmsKey_disappears (69.81s)
=== CONT  TestAccAWSKmsKey_Policy_IamRole
--- PASS: TestAccAWSKmsKey_asymmetricKey (82.26s)
=== CONT  TestAccAWSKmsKey_policyBypassUpdate
--- PASS: TestAccAWSKmsKey_basic (91.10s)
=== CONT  TestAccAWSKmsAlias_disappears
--- PASS: TestAccAWSKmsExternalKey_basic (91.29s)
=== CONT  TestAccAWSKmsAlias_UpdateKeyID
--- PASS: TestAccAWSKmsExternalKey_PolicyBypass (93.12s)
--- PASS: TestAccAWSKmsAlias_basic (93.23s)
=== CONT  TestAccAWSKmsAlias_NamePrefix
=== CONT  TestAccAWSKmsAlias_MultipleAliasesForSameKey
--- PASS: TestAccAWSKmsAlias_Name_Generated (93.58s)
=== CONT  TestAccDataSourceAwsKmsAlias_CMK
--- PASS: TestAccAWSKmsAlias_ArnDiffSuppress (122.14s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (125.76s)
=== CONT  TestAccAWSKmsExternalKey_Description
--- PASS: TestAccAWSKmsKey_policy (135.77s)
--- PASS: TestAccAWSKmsExternalKey_Policy (136.17s)
--- PASS: TestAccAWSKmsExternalKey_Description (102.58s)
--- PASS: TestAccAWSKmsAlias_disappears (51.87s)
--- PASS: TestAccDataSourceAwsKmsAlias_CMK (51.72s)
--- PASS: TestAccAWSKmsAlias_NamePrefix (57.29s)
--- PASS: TestAccAWSKmsAlias_MultipleAliasesForSameKey (57.76s)
--- PASS: TestAccAWSKmsKey_Policy_IamRole (81.49s)
--- PASS: TestAccAWSKmsKey_Policy_IamServiceLinkedRole (91.69s)
--- PASS: TestAccAWSKmsAlias_UpdateKeyID (77.80s)
--- PASS: TestAccAWSKmsKey_policyBypass (188.35s)
--- PASS: TestAccAWSKmsExternalKey_Tags (206.31s)
--- PASS: TestAccAWSKmsKey_policyBypassUpdate (147.55s)
--- PASS: TestAccAWSKmsKey_tags (291.59s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (357.66s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (371.76s)
--- PASS: TestAccAWSKmsKey_isEnabled (471.43s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (673.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	683.496s

ewbankkit · 2021-08-03T15:06:26Z

@tism Thanks for the contribution 🎉 👏.
I went ahead and made the same changes to the aws_kms_external_key resource.

github-actions · 2021-08-05T22:24:12Z

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-09-05T02:07:17Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

tism requested a review from a team as a code owner March 16, 2021 05:57

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2021

tism added 3 commits July 17, 2021 16:47

Add policy lockout check bypass flag

d2195b5

Supply bypass flag when creating kms keys

10c4a11

Supply bypass flag when updating kms keys

a4a57d6

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 17, 2021

tism and others added 13 commits July 17, 2021 16:50

Add doco for bypass lockout check flag

a0324c4

Fix terraform formatting

7ae8f2f

Add CHANGELOG entry.

9d45932

Add internal KMS finder package.

ee55e96

r/aws_kms_key: Some waiter simplification.

ceed49d

Add 'tfresource.RetryWhen'.

e6ceb12

r/aws_kms_key: Simplify retry on Read.

381e4d5

Tweak 'RetryWhenNotFound'.

352de32

Tweak 'SetLastError'.

740579a

Add 'Context' versions of Retry functions.

d0810a8

Add 'tfresource.WaitUntil'.

bfe31d9

Add 'updateKmsKeyRotationEnabled'.

56a5697

r/aws_kms_key: Tidy up eventual consistency checks.

5ad13b7

ewbankkit added 12 commits July 22, 2021 16:48

r/aws_kms_alias: Add and use 'finder.AliasByName'.

95bcab6

r/aws_kms_alias: Add 'AliasARNToKeyARN'.

60b0404

Error check.

4130ed6

Add 'KeyARNOrIDEqual'.

6acc07e

r/aws_kms_external_key: Use internal packages.

4398730

Add and use 'findKmsKey'.

c3bbe28

r/aws_kms_key: Test completely empty configuration.

3eb202a

r/aws_kms_external_key: Add 'waiter.KeyMaterialImported'.

dfc1480

Add 'updateKmsKeyDescription' and 'waiter.KeyValidToPropagated'.

adcb59f

ewbankkit force-pushed the f-aws_kms_key-bypass_policy_check branch from bbb1b6a to 3fa5fc8 Compare August 3, 2021 13:47

Supply bypass flag when updating kms keys

c111d91

ewbankkit force-pushed the f-aws_kms_key-bypass_policy_check branch from 3fa5fc8 to c111d91 Compare August 3, 2021 13:55

ewbankkit added 2 commits August 3, 2021 10:08

Fix golangci-lint errors.

bc1698d

Fix awsproviderlint 'XAT001: missing ErrorCheck'.

0b4a4c8

ewbankkit approved these changes Aug 3, 2021

View reviewed changes

ewbankkit merged commit ce03236 into hashicorp:main Aug 3, 2021

github-actions bot added this to the v3.53.0 milestone Aug 3, 2021

jniebuhr mentioned this pull request Aug 9, 2021

Error for bypass_policy_lockout_safety_check when applying aws_kms_key #20490

Open

dzandt mentioned this pull request Aug 26, 2021

KMS doesn't work with newest verision of provider #20588

Closed

github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_kms_key: Support policy lockout check bypass #18117

r/aws_kms_key: Support policy lockout check bypass #18117

tism commented Mar 16, 2021

ewbankkit left a comment

ewbankkit commented Aug 3, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Sep 5, 2021

r/aws_kms_key: Support policy lockout check bypass #18117

r/aws_kms_key: Support policy lockout check bypass #18117

Conversation

tism commented Mar 16, 2021

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Aug 3, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Sep 5, 2021