r/aws_autoscalingplans_scaling_plan: Work around Plugin SDK bug updating Map in Set #17987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/L
|
Without the fix: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification -timeout 120m
=== RUN TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification
=== CONT TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification
resource_aws_autoscalingplans_scaling_plan_test.go:312: Step 2/3 error: Error running apply: exit status 1
2021/03/08 16:14:35 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.13.0
Error: error updating Auto Scaling Scaling Plan (tf-acc-test-5827494292471838491/1): InvalidParameter: 4 validation error(s) found.
- missing required field, UpdateScalingPlanInput.ScalingInstructions[0].ResourceId.
- missing required field, UpdateScalingPlanInput.ScalingInstructions[0].ScalableDimension.
- missing required field, UpdateScalingPlanInput.ScalingInstructions[0].ServiceNamespace.
- missing required field, UpdateScalingPlanInput.ScalingInstructions[0].TargetTrackingConfigurations[0].TargetValue.
on terraform_plugin_test.tf line 60, in resource "aws_autoscalingplans_scaling_plan" "test":
60: resource "aws_autoscalingplans_scaling_plan" "test" {
--- FAIL: TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification (50.25s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 50.351s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1 |
ewbankkit
force-pushed
the
r/aws_autoscalingplans_scaling_plan-customized_scaling_metric_specification-update
branch
from
5b6aa57 to
7ce23e8
Compare
…ing Map in Set. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m === RUN TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling === PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling === RUN TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling === PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling === RUN TestAccAwsAutoScalingPlansScalingPlan_basicUpdate === PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate === RUN TestAccAwsAutoScalingPlansScalingPlan_disappears === PAUSE TestAccAwsAutoScalingPlansScalingPlan_disappears === RUN TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification === PAUSE TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification === CONT TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling === CONT TestAccAwsAutoScalingPlansScalingPlan_disappears === CONT TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification === CONT TestAccAwsAutoScalingPlansScalingPlan_basicUpdate === CONT TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling --- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (57.92s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (59.75s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (60.09s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification (98.59s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (110.94s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 111.067s
ewbankkit
force-pushed
the
r/aws_autoscalingplans_scaling_plan-customized_scaling_metric_specification-update
branch
from
7ce23e8 to
2cbc917
Compare
github-actions
bot
added
size/XL
|
After rebase: % make testacc TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 180m
=== RUN TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== RUN TestAccAwsAutoScalingPlansScalingPlan_disappears
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_disappears
=== RUN TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification
=== CONT TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification
=== CONT TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== CONT TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (79.63s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (80.91s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (90.61s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_dynamicScaling_CustomizedScalingMetricSpecification (123.71s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (123.74s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 127.059s |
ewbankkit
deleted the
r/aws_autoscalingplans_scaling_plan-customized_scaling_metric_specification-update
branch
|
This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #17929.
Relates: hashicorp/terraform-plugin-sdk#588.
Output from acceptance testing: