Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ec2_client_vpn_endpoint: self service portal options #17897

Closed
wants to merge 1 commit into from
Closed

resource/aws_ec2_client_vpn_endpoint: self service portal options #17897

wants to merge 1 commit into from

Conversation

nbsdan
Copy link
Contributor

@nbsdan nbsdan commented Mar 3, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16019

Output from acceptance testing:

Need help with running acceptance tests

Unable to run acceptance tests as I do not have an AWS account I can use

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 3, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 3, 2021
github-actions[bot]
github-actions bot reviewed Mar 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nbsdan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@nbsdan nbsdan force-pushed the f-aws_ec2_client_vpn_endpoint-self_service_options branch from d7753f6 to afee1da Compare March 3, 2021 14:21
@nbsdan nbsdan force-pushed the f-aws_ec2_client_vpn_endpoint-self_service_options branch from afee1da to db27c4b Compare March 3, 2021 14:37
@nbsdan nbsdan marked this pull request as ready for review March 3, 2021 15:52
@nbsdan nbsdan requested a review from a team as a code owner March 3, 2021 15:52
@nbsdan nbsdan changed the title [WIP] resource/aws_ec2_client_vpn_endpoint: self service portal options resource/aws_ec2_client_vpn_endpoint: self service portal options Mar 3, 2021
@guilhermeblanco
Copy link

Any luck into getting this reviewed/merged? It's been hanging around for over a quarter without any feedback.
It's been so long that it's staling and now conflicts are happening.

@antgel
Copy link

antgel commented Jul 15, 2021

@nbsdan Shame that this was hanging around for so long and now there's a conflict. Can you rebase your commit in the meantime and hopefully someone from the Terraform team will be along at some point?

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2021
@aidan-mundy aidan-mundy mentioned this pull request Sep 9, 2021
Merged
@aidan-mundy
Copy link
Contributor

@breathingdust I created #20846 as a replacement for this MR with the merge conflict resolved.

@ewbankkit
Copy link
Contributor

Replaced by #20846.

@nbsdan Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit closed this Sep 11, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jeremiah-norris-champ jeremiah-norris-champ jeremiah-norris-champ approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client VPN Endpoint - Add Optional Self-Service Portal Arguments
7 participants
@nbsdan @guilhermeblanco @antgel @aidan-mundy @ewbankkit @jeremiah-norris-champ @breathingdust