Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_instance: add support for CoIP enabled argument #17864

Merged
merged 6 commits into from
Aug 4, 2021
Merged

resource/aws_db_instance: add support for CoIP enabled argument #17864

merged 6 commits into from
Aug 4, 2021

Conversation

farhanangullia
Copy link
Contributor

@farhanangullia farhanangullia commented Mar 1, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17165

Release note for CHANGELOG:

enhancement:

resource/aws_db_instance: Add support for `customer_owned_ip_enabled` argument

Affected Resource(s)

  • resource: aws_db_instance

Terraform Configuration

resource "aws_db_instance" "foo" {
  customer_owned_ip_enabled = true
  allocated_storage         = 20
  engine                    = "mysql"
  engine_version            = "8.0.17"
  instance_class            = "db.m5.large"
  name                      = "foo"
  parameter_group_name      = "default.mysql8.0"
  password                  = "foobarbaz"
  username                  = "foo"
  db_subnet_group_name      = "foo-db-subnet-group"
  storage_encrypted         = true
}

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBInstance_CoipEnabled'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSDBInstance_CoipEnabled -timeout 120m
=== RUN   TestAccAWSDBInstance_CoipEnabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== PAUSE TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== RUN   TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== PAUSE TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== CONT  TestAccAWSDBInstance_CoipEnabled
=== CONT  TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== CONT  TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== CONT  TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
--- PASS: TestAccAWSDBInstance_CoipEnabled (550.70s)
--- PASS: TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled (659.79s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
--- PASS: TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime (1628.76s)
--- PASS: TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier (1852.34s)
--- PASS: TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled (794.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2006.422s

...

@farhanangullia farhanangullia requested a review from a team as a code owner March 1, 2021 10:36
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 1, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 1, 2021
@farhanangullia farhanangullia changed the title [WIP] resource/aws_db_instance: add support for CoIP enabled argument resource/aws_db_instance: add support for CoIP enabled argument Mar 2, 2021
@farhanangullia farhanangullia requested review from ewbankkit and removed request for a team March 2, 2021 15:28
@farhanangullia farhanangullia force-pushed the f-aws_db_instance-customer_owned_ip_enabled branch 2 times, most recently from 6f7e520 to 3a32fc7 Compare May 17, 2021 16:41
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 4, 2021
@ewbankkit ewbankkit force-pushed the f-aws_db_instance-customer_owned_ip_enabled branch from 3a32fc7 to f60c0c3 Compare August 4, 2021 21:34
@ewbankkit
Copy link
Contributor

@farhanangullia Thanks for the contribution 🎉 👏.

ewbankkit
ewbankkit approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSDBInstance_CoipEnabled\|TestAccAWSDBInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_CoipEnabled\|TestAccAWSDBInstance_basic -timeout 180m
=== RUN   TestAccAWSDBInstance_basic
=== PAUSE TestAccAWSDBInstance_basic
=== RUN   TestAccAWSDBInstance_CoipEnabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== PAUSE TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== RUN   TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== PAUSE TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== CONT  TestAccAWSDBInstance_basic
=== CONT  TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== CONT  TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== CONT  TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== CONT  TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== CONT  TestAccAWSDBInstance_CoipEnabled
=== CONT  TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled (1.42s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime (1.49s)
=== CONT  TestAccAWSDBInstance_CoipEnabled
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled (1.65s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier (7.26s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled (7.30s)
--- PASS: TestAccAWSDBInstance_basic (325.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	328.636s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSDBInstance_CoipEnabled\|TestAccAWSDBInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_CoipEnabled\|TestAccAWSDBInstance_basic -timeout 180m
=== RUN   TestAccAWSDBInstance_basic
=== PAUSE TestAccAWSDBInstance_basic
=== RUN   TestAccAWSDBInstance_CoipEnabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== PAUSE TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== RUN   TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== PAUSE TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== RUN   TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== PAUSE TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== CONT  TestAccAWSDBInstance_basic
=== CONT  TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
=== CONT  TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
=== CONT  TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
=== CONT  TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
=== CONT  TestAccAWSDBInstance_CoipEnabled
=== CONT  TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_DisabledToEnabled (2.93s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_SnapshotIdentifier (2.99s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_RestoreToPointInTime (8.18s)
=== CONT  TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled_EnabledToDisabled (8.28s)
=== CONT  TestAccAWSDBInstance_CoipEnabled
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSDBInstance_CoipEnabled (8.40s)
--- PASS: TestAccAWSDBInstance_basic (475.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	478.612s

@ewbankkit ewbankkit merged commit 065918e into hashicorp:main Aug 4, 2021
@github-actions github-actions bot added this to the v3.53.0 milestone Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.53.0
Development

Successfully merging this pull request may close these issues.

Add enable-customer-owned-ip argument for Resource: aws_db_instance
3 participants
@farhanangullia @ewbankkit @justinretzolk