Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/Support for AthenaEngineVersion option in Athena work groups #17733

Merged
merged 8 commits into from
Nov 23, 2021

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Feb 20, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17456.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAthenaWorkGroup_Configuration_EngineVersion'
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_EngineVersion
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_EngineVersion
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_EngineVersion
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_EngineVersion (76.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.704s
$ make testacc TESTARGS='-run=TestAccAWSAthenaWorkGroup_basic'
=== RUN   TestAccAWSAthenaWorkGroup_basic
=== PAUSE TestAccAWSAthenaWorkGroup_basic
=== CONT  TestAccAWSAthenaWorkGroup_basic
--- PASS: TestAccAWSAthenaWorkGroup_basic (45.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	49.462s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner February 20, 2021 18:30
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 20, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 20, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Feb 20, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 11, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@anGie44 anGie44 self-assigned this Nov 23, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @nikhil-goenka ! Looks great overall 🚀 I've merged in the main branch to address some merge conflicts post-service-packages refactor and updated the schema to align with the upstream AWS API naming conventions.

Output of acceptance tests:

--- PASS: TestAccAthenaWorkGroup_ResultEncryption_kms (101.46s)
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_sseS3 (66.33s)
--- PASS: TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy (102.58s)
--- PASS: TestAccAthenaWorkGroup_Result_outputLocation (102.97s)
--- PASS: TestAccAthenaWorkGroup_basic (67.42s)
--- PASS: TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery (98.54s)
--- PASS: TestAccAthenaWorkGroup_configurationEngineVersion (114.53s)
--- PASS: TestAccAthenaWorkGroup_description (99.69s)
--- PASS: TestAccAthenaWorkGroup_disappears (50.29s)
--- PASS: TestAccAthenaWorkGroup_enforceWorkGroup (101.43s)
--- PASS: TestAccAthenaWorkGroup_forceDestroy (75.27s)
--- PASS: TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled (101.89s)
--- PASS: TestAccAthenaWorkGroup_requesterPaysEnabled (102.12s)
--- PASS: TestAccAthenaWorkGroup_state (112.60s)
--- PASS: TestAccAthenaWorkGroup_tags (111.86s)

@anGie44 anGie44 added this to the v3.67.0 milestone Nov 23, 2021
@anGie44 anGie44 merged commit 448475e into hashicorp:main Nov 23, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/athena Issues and PRs that pertain to the athena service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for AthenaEngineVersion option in Athena work groups
4 participants