Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws_ses_reciept_rule): include period in name validation regex #17627

Merged
merged 1 commit into from
Feb 16, 2021
Merged

fix(aws_ses_reciept_rule): include period in name validation regex #17627

merged 1 commit into from
Feb 16, 2021

Conversation

joshsleeper
Copy link
Contributor

@joshsleeper joshsleeper commented Feb 15, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13960 (bug introduced due to mistake in official AWS docs, which has also been reported)
Closes #17602

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSESReceiptRule_'
==> Checking that code complies with gofmt requirements...TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESReceiptRule_ -timeout 120m=== RUN   TestAccAWSSESReceiptRule_basic
=== PAUSE TestAccAWSSESReceiptRule_basic
=== RUN   TestAccAWSSESReceiptRule_s3Action
=== PAUSE TestAccAWSSESReceiptRule_s3Action
=== RUN   TestAccAWSSESReceiptRule_order
=== PAUSE TestAccAWSSESReceiptRule_order
=== RUN   TestAccAWSSESReceiptRule_actions
=== PAUSE TestAccAWSSESReceiptRule_actions
=== RUN   TestAccAWSSESReceiptRule_disappears
=== PAUSE TestAccAWSSESReceiptRule_disappears
=== CONT  TestAccAWSSESReceiptRule_basic
=== CONT  TestAccAWSSESReceiptRule_actions
=== CONT  TestAccAWSSESReceiptRule_order
=== CONT  TestAccAWSSESReceiptRule_disappears
=== CONT  TestAccAWSSESReceiptRule_s3Action
--- PASS: TestAccAWSSESReceiptRule_actions (16.47s)
--- PASS: TestAccAWSSESReceiptRule_basic (16.48s)
--- PASS: TestAccAWSSESReceiptRule_order (16.73s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (19.08s)
--- PASS: TestAccAWSSESReceiptRule_disappears (22.37s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       22.477s
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. labels Feb 15, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 15, 2021
github-actions[bot]
github-actions bot reviewed Feb 15, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @joshsleeper 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@DrFaust92 DrFaust92 added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2021
@joshsleeper joshsleeper marked this pull request as ready for review February 15, 2021 22:55
@joshsleeper joshsleeper requested a review from a team as a code owner February 15, 2021 22:55
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Feb 16, 2021
@anGie44 anGie44 added this to the v3.29.0 milestone Feb 16, 2021
@anGie44 anGie44 self-assigned this Feb 16, 2021
anGie44
anGie44 approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @joshsleeper, looks great! 🚀 🚀

Output of acceptance tests (commercial):

--- PASS: TestAccAWSSESReceiptRule_basic (14.96s)
--- PASS: TestAccAWSSESReceiptRule_actions (14.98s)
--- PASS: TestAccAWSSESReceiptRule_order (16.12s)
--- PASS: TestAccAWSSESReceiptRule_disappears (21.32s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (24.61s)

@anGie44 anGie44 merged commit c63960b into hashicorp:main Feb 16, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ses Issues and PRs that pertain to the ses service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.

aws_ses_reciept_rule validation isn't accurate, causing plan/apply failures for things AWS would be fine with
3 participants
@joshsleeper @anGie44 @DrFaust92