Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfux: add missing value to resource_type_list #17595

Merged
merged 2 commits into from
Feb 18, 2021
Merged

bugfux: add missing value to resource_type_list #17595

merged 2 commits into from
Feb 18, 2021

Conversation

mcalhoun
Copy link
Contributor

@mcalhoun mcalhoun commented Feb 12, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17572

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsFms'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsFms* -timeout 120m
=== RUN   TestAccAwsFmsAdminAccount_basic
=== PAUSE TestAccAwsFmsAdminAccount_basic
=== CONT  TestAccAwsFmsAdminAccount_basic
    provider_test.go:781: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAwsFmsAdminAccount_basic (1.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.387s

@mcalhoun mcalhoun requested a review from a team as a code owner February 12, 2021 15:57
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/fms Issues and PRs that pertain to the fms service. labels Feb 12, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021
github-actions[bot]
github-actions bot reviewed Feb 12, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mcalhoun 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 18, 2021
@anGie44 anGie44 self-assigned this Feb 18, 2021
anGie44
anGie44 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcalhoun, thank you for this PR! Just a small nit to move the validation values onto newlines as the line is getting rather long and to update the documentation. I'll add a commit onto the work here to get this merged in 👍

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Feb 18, 2021
@anGie44 anGie44 added this to the v3.29.0 milestone Feb 18, 2021
@anGie44 anGie44 force-pushed the chore/17572-fix-resource-type-list-validation branch from 96982ad to c7921d5 Compare February 18, 2021 18:23
@anGie44 anGie44 force-pushed the chore/17572-fix-resource-type-list-validation branch from c7921d5 to 6ae83e7 Compare February 18, 2021 18:25
@anGie44 anGie44 force-pushed the chore/17572-fix-resource-type-list-validation branch from 6e1f8f5 to 0eb4b27 Compare February 18, 2021 19:10
@anGie44 anGie44 merged commit 2131187 into hashicorp:main Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/fms Issues and PRs that pertain to the fms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.

aws_fms_policy resource_type_list validation rejecting valid AWS::EC2::VPC value
2 participants
@mcalhoun @anGie44