Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sageamaker_model_package_group - new resource #17366

Merged
merged 6 commits into from
Feb 10, 2021
Merged

r/sageamaker_model_package_group - new resource #17366

merged 6 commits into from
Feb 10, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerModelPackageGroup_'
--- PASS: TestAccAWSSagemakerModelPackageGroup_disappears (26.29s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_basic (36.78s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_description (36.89s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_tags (89.19s)
...

@DrFaust92 DrFaust92 requested a review from a team as a code owner January 30, 2021 11:44
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 30, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 30, 2021
ewbankkit
ewbankkit approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerModelPackageGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModelPackageGroup_ -timeout 120m
=== RUN   TestAccAWSSagemakerModelPackageGroup_basic
=== PAUSE TestAccAWSSagemakerModelPackageGroup_basic
=== RUN   TestAccAWSSagemakerModelPackageGroup_description
=== PAUSE TestAccAWSSagemakerModelPackageGroup_description
=== RUN   TestAccAWSSagemakerModelPackageGroup_tags
=== PAUSE TestAccAWSSagemakerModelPackageGroup_tags
=== RUN   TestAccAWSSagemakerModelPackageGroup_disappears
=== PAUSE TestAccAWSSagemakerModelPackageGroup_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroup_basic
=== CONT  TestAccAWSSagemakerModelPackageGroup_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroup_tags
=== CONT  TestAccAWSSagemakerModelPackageGroup_description
--- PASS: TestAccAWSSagemakerModelPackageGroup_description (16.91s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_disappears (17.04s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_basic (21.84s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_tags (42.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.671s

@DrFaust92 @ewbankkit
Apply suggestions from code review
890aa38 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerModelPackageGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModelPackageGroup_ -timeout 120m
=== RUN   TestAccAWSSagemakerModelPackageGroup_basic
=== PAUSE TestAccAWSSagemakerModelPackageGroup_basic
=== RUN   TestAccAWSSagemakerModelPackageGroup_description
=== PAUSE TestAccAWSSagemakerModelPackageGroup_description
=== RUN   TestAccAWSSagemakerModelPackageGroup_tags
=== PAUSE TestAccAWSSagemakerModelPackageGroup_tags
=== RUN   TestAccAWSSagemakerModelPackageGroup_disappears
=== PAUSE TestAccAWSSagemakerModelPackageGroup_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroup_basic
=== CONT  TestAccAWSSagemakerModelPackageGroup_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroup_tags
=== CONT  TestAccAWSSagemakerModelPackageGroup_description
--- PASS: TestAccAWSSagemakerModelPackageGroup_disappears (11.47s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_basic (15.51s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_description (15.71s)
--- PASS: TestAccAWSSagemakerModelPackageGroup_tags (34.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.855s

Failing Acceptance Tests in GovCloud (us-gov-west-1)

These tests will need to be skipped, a follow up issue will be created to track this work.

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerModelPackageGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModelPackageGroup_ -timeout 120m
=== RUN   TestAccAWSSagemakerModelPackageGroup_basic
=== PAUSE TestAccAWSSagemakerModelPackageGroup_basic
=== RUN   TestAccAWSSagemakerModelPackageGroup_description
=== PAUSE TestAccAWSSagemakerModelPackageGroup_description
=== RUN   TestAccAWSSagemakerModelPackageGroup_tags
=== PAUSE TestAccAWSSagemakerModelPackageGroup_tags
=== RUN   TestAccAWSSagemakerModelPackageGroup_disappears
=== PAUSE TestAccAWSSagemakerModelPackageGroup_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroup_basic
=== CONT  TestAccAWSSagemakerModelPackageGroup_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroup_description
=== CONT  TestAccAWSSagemakerModelPackageGroup_tags
=== CONT  TestAccAWSSagemakerModelPackageGroup_disappears
    resource_aws_sagemaker_model_package_group_test.go:163: Step 1/1 error: Error running apply: 2021/02/10 08:18:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.12.0

        Error: error creating SageMaker Model Package Group tf-acc-test-8314827973041593631: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 0a6c864d-d77e-43a2-91f5-e906eefe46f8


=== CONT  TestAccAWSSagemakerModelPackageGroup_description
    resource_aws_sagemaker_model_package_group_test.go:93: Step 1/2 error: Error running apply: 2021/02/10 08:18:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.12.0

        Error: error creating SageMaker Model Package Group tf-acc-test-3740237711744291030: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 3069b992-f9b9-4f85-a736-93685db778c4


=== CONT  TestAccAWSSagemakerModelPackageGroup_tags
    resource_aws_sagemaker_model_package_group_test.go:119: Step 1/4 error: Error running apply: 2021/02/10 08:18:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.12.0

        Error: error creating SageMaker Model Package Group tf-acc-test-4268414703224873836: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: fe2dbb2c-14bf-4491-ae55-039686df8caa


=== CONT  TestAccAWSSagemakerModelPackageGroup_basic
    resource_aws_sagemaker_model_package_group_test.go:65: Step 1/2 error: Error running apply: 2021/02/10 08:18:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.12.0

        Error: error creating SageMaker Model Package Group tf-acc-test-6501003966160909864: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 076128f1-f182-4a92-b063-cb25303e0085


--- FAIL: TestAccAWSSagemakerModelPackageGroup_disappears (4.20s)
--- FAIL: TestAccAWSSagemakerModelPackageGroup_description (4.21s)
--- FAIL: TestAccAWSSagemakerModelPackageGroup_tags (4.22s)
--- FAIL: TestAccAWSSagemakerModelPackageGroup_basic (4.23s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	6.039s
FAIL
make: *** [testacc] Error 1

@breathingdust breathingdust merged commit 4622f57 into hashicorp:main Feb 10, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 10, 2021
@breathingdust breathingdust mentioned this pull request Feb 10, 2021
Closed
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
@DrFaust92 DrFaust92 deleted the r/sageamaker_model_package_group branch April 15, 2021 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @breathingdust @ewbankkit