Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/lakeformation permissions: Fix multiple permissions bug #17189

Merged
merged 10 commits into from
Jan 21, 2021
Merged

resource/lakeformation permissions: Fix multiple permissions bug #17189

merged 10 commits into from
Jan 21, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 20, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17047

Release note for CHANGELOG:

resource/lakeformation_permissions: Fix multiple permissions bug

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSLakeFormation_serial (347.89s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (60.78s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (15.88s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (14.67s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (14.48s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (15.74s)
    --- PASS: TestAccAWSLakeFormation_serial/Permissions (287.11s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableDataSource (29.12s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (24.26s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (21.74s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/table (23.90s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumns (28.37s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basicDataSource (25.09s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/databaseDataSource (28.06s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (26.15s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsAndTable (23.79s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocationDataSource (28.97s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsDataSource (27.67s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 20, 2021
@YakDriver YakDriver force-pushed the b-lakeformation-permissions branch from 3506d0a to d4ee7cd Compare January 21, 2021 13:59
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 21, 2021
@YakDriver YakDriver force-pushed the b-lakeformation-permissions branch from d4ee7cd to d77ac81 Compare January 21, 2021 13:59
@YakDriver YakDriver marked this pull request as ready for review January 21, 2021 16:46
@YakDriver YakDriver requested a review from a team as a code owner January 21, 2021 16:46
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Jan 21, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 21, 2021
@YakDriver
Copy link
Member Author

YakDriver commented Jan 21, 2021 •
edited
Loading

Latest (GovCloud):

--- PASS: TestAccAWSLakeFormation_serial (336.07s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (61.10s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (15.62s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (14.76s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (14.51s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (16.22s)
    --- PASS: TestAccAWSLakeFormation_serial/Permissions (274.96s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (21.83s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocationDataSource (26.40s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/databaseDataSource (29.61s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableDataSource (26.33s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (24.49s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (25.39s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/table (23.95s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumns (23.20s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsAndTable (25.70s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basicDataSource (26.09s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsDataSource (23.51s)

Latest (Commercial):

--- PASS: TestAccAWSLakeFormation_serial (324.12s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (43.54s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (10.81s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (11.16s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (10.01s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (11.56s)
    --- PASS: TestAccAWSLakeFormation_serial/Permissions (280.58s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumns (23.79s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basicDataSource (29.01s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocationDataSource (27.62s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsDataSource (25.59s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsAndTable (30.15s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/databaseDataSource (25.87s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableDataSource (27.93s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (19.31s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (26.29s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (20.88s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/table (24.14s)

bflad
bflad approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Through no fault of your own, this resource is a little scary. I think this is correct though and passes regression testing.

Output from acceptance testing:

--- FAIL: TestAccAWSLakeFormation_serial (316.72s)
    --- FAIL: TestAccAWSLakeFormation_serial/Permissions (274.28s)
        --- FAIL: TestAccAWSLakeFormation_serial/Permissions/dataLocation (25.07s) # unrelated account issue
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocationDataSource (27.38s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsDataSource (26.06s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumns (24.31s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableWithColumnsAndTable (25.36s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basicDataSource (20.68s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/databaseDataSource (27.77s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/tableDataSource (30.45s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (20.64s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (22.35s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/table (24.20s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (42.44s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (10.63s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (10.06s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (11.65s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (10.10s)

@YakDriver
Copy link
Member Author

@bflad I agree that it's scary. Hopefully a small community can build around this to help it mature. That and maybe some API maturing.

@YakDriver YakDriver added this to the v3.25.0 milestone Jan 21, 2021
@YakDriver YakDriver merged commit 85f8992 into master Jan 21, 2021
@YakDriver YakDriver deleted the b-lakeformation-permissions branch January 21, 2021 20:58
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partition/aws-us-gov Pertains to the aws-us-gov partition. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.25.0
Development

Successfully merging this pull request may close these issues.

Error: error reading Lake Formation permissions: multiple permissions found
2 participants
@YakDriver @bflad