resource/instance: Fix invalid address set #17136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/S
YakDriver
force-pushed
the
b-instance-ebs-tags
branch
from
1b84870 to
3d22c96
Compare
ghost
added
size/S
bflad
reviewed
Jan 15, 2021
bflad
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Looks good to me. Verified it breaks before schema update and passes after schema update. Not sure if this should close #17125 though since that report is for the resource.
Previously:
=== CONT TestAccAWSInstanceDataSource_blockDeviceTags
panic: Invalid address to set: []string{"ebs_block_device", "0", "tags"}
goroutine 634 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc002221e00, 0x8367470, 0x10, 0x6cccf40, 0xc002ceeee0, 0x0, 0x1)
/Users/bflad/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.4.0/helper/schema/resource_data.go:230 +0x36f
github.com/terraform-providers/terraform-provider-aws/aws.readBlockDevices(0xc002221e00, 0xc002a40200, 0xc000010fb0, 0x0, 0x0)
/Users/bflad/src/github.com/hashicorp/terraform-provider-aws-trois/aws/resource_aws_instance.go:1675 +0x445
github.com/terraform-providers/terraform-provider-aws/aws.instanceDescriptionAttributes(0xc002221e00, 0xc002a40200, 0xc000010fb0, 0x0, 0x1, 0xc0035575e0)
/Users/bflad/src/github.com/hashicorp/terraform-provider-aws-trois/aws/data_source_aws_instance.go:503 +0xa05
github.com/terraform-providers/terraform-provider-aws/aws.dataSourceAwsInstanceRead(0xc002221e00, 0x7612b60, 0xc001fc8c00, 0xce15040, 0x8833d30)
/Users/bflad/src/github.com/hashicorp/terraform-provider-aws-trois/aws/data_source_aws_instance.go:407 +0x5bd
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc0013cf680, 0x928b160, 0xc002be2040, 0xc002221e00, 0x7612b60, 0xc001fc8c00, 0x0, 0x0, 0x0)
Output from acceptance testing after code changes:
--- PASS: TestAccAWSInstanceDataSource_AzUserData (78.98s)
--- PASS: TestAccAWSInstanceDataSource_basic (104.62s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (97.97s)
--- PASS: TestAccAWSInstanceDataSource_blockDeviceTags (118.77s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (158.08s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (85.49s)
--- PASS: TestAccAWSInstanceDataSource_enclaveOptions (101.20s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (171.71s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (220.22s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (184.78s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (197.76s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (108.89s)
--- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (113.39s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (112.68s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (118.60s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (144.01s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (115.89s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (148.66s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (123.05s)
--- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (114.98s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (108.75s)
--- PASS: TestAccAWSInstanceDataSource_tags (97.26s)
--- PASS: TestAccAWSInstanceDataSource_VPC (112.37s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (114.48s)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #17125
Release note for CHANGELOG:
Output from acceptance testing (commercial):
GovCloud:
Unrelated failures due to unsupported features: