PoolArn attribute support in Data Source: aws_ec2_coip_pool #17046

sumitmenaria · 2021-01-11T07:17:29Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

DataSource/aws_ec2_coip_pool pool_arn attribute support

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_Id'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_Id -timeout 120m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
--- PASS: TestAccDataSourceAwsEc2CoipPool_Id (34.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.272s

...

Added the attribute pool_arn in Data Source: aws_ec2_coip_pool to resolve hashicorp#16426

Added attribute pool_arn in datasource ec2_coip

updated test to check pool_arn in data source aws_ec2_coip_pool_test.go

acceptancetest for datasource/aws_ec2_coip_pool

data source aws_ec2_coip_pool documentation updated with pool_arn attribute

attribute reference updated with pool_arn

github-actions

Welcome @sumitmenaria 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

testAccMatchResourceAttrRegionalARN for awsproviderlint to test arn

aws/data_source_aws_ec2_coip_pool.go

ewbankkit · 2021-01-11T20:40:48Z

@sumitmenaria Thanks for the contribution 👏. Could you please rename the new attribute to plan arn?
Although we usually prefer that the attribute name matches the property name in the underlying AWS API, for the property that contains the resource's ARN we always try and stick with arn - Guidelines here.
Other than that (and the comment above) this looks great.

data_source_ec2_coip_pool.go pool_arn -> arn pool_arn : removed from optional

optional removed from pool_arn attribute and name changed to arn

data_source_ec2_coip_pool_test.go ARN test function update with attribute name arn instead of pool_arn

website/docs/d/ec2_coip_pool.html.markdown

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>

ewbankkit

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_ -timeout 120m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Filter
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Filter (1.90s)
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Id (1.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.067s

sumitmenaria · 2021-01-20T01:03:46Z

@ewbankkit Pardom me for my ignorance, is there any tentative timeline when this request is going to be merged?

FireballDWF · 2021-08-03T01:21:47Z

@ewbankkit What is the next step to move this forward?

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_ -timeout 120m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Filter
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Filter (1.43s)
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Id (1.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.156s

ewbankkit · 2021-08-03T14:36:39Z

@sumitmenaria Thanks for the contribution 🎉 👏.

github-actions · 2021-08-05T22:24:24Z

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-09-05T02:07:14Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

sumitmenaria added 6 commits January 11, 2021 17:35

Added attribute pool_arn in datasource ec2_coip

a75593a

Added the attribute pool_arn in Data Source: aws_ec2_coip_pool to resolve hashicorp#16426

Merge pull request #1 from sumitmenaria/sumitmenaria-coip_arn

ec7fa55

Added attribute pool_arn in datasource ec2_coip

acceptancetest for datasource/aws_ec2_coip_pool

39049da

updated test to check pool_arn in data source aws_ec2_coip_pool_test.go

Merge pull request #2 from sumitmenaria/sumitmenaria-coip_test

413b13f

acceptancetest for datasource/aws_ec2_coip_pool

attribute reference updated with pool_arn

7da2f89

data source aws_ec2_coip_pool documentation updated with pool_arn attribute

Merge pull request #3 from sumitmenaria/sumitmenaria-ec2_coip_doc

8cdd96a

attribute reference updated with pool_arn

sumitmenaria requested a review from a team as a code owner January 11, 2021 07:17

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 11, 2021

github-actions bot reviewed Jan 11, 2021

View reviewed changes

arn function check testAccMatchResourceAttrRegionalARN

67cefe5

testAccMatchResourceAttrRegionalARN for awsproviderlint to test arn

sumitmenaria closed this Jan 11, 2021

sumitmenaria reopened this Jan 11, 2021

ewbankkit reviewed Jan 11, 2021

View reviewed changes

aws/data_source_aws_ec2_coip_pool.go Outdated Show resolved Hide resolved

ewbankkit added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2021

sumitmenaria added 4 commits January 12, 2021 14:00

pool_arn attribute remove from optional and name changed to arn

6d0690e

data_source_ec2_coip_pool.go pool_arn -> arn pool_arn : removed from optional

Merge pull request #4 from sumitmenaria/sumitmenaria-coip_pool_rename

274da93

optional removed from pool_arn attribute and name changed to arn

update test to include new pool_arn name

2766d79

data_source_ec2_coip_pool_test.go ARN test function update with attribute name arn instead of pool_arn

gofmt

fc517a6

ewbankkit reviewed Jan 12, 2021

View reviewed changes

website/docs/d/ec2_coip_pool.html.markdown Outdated Show resolved Hide resolved

Update website/docs/d/ec2_coip_pool.html.markdown

9fe9233

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>

ewbankkit reviewed Jan 12, 2021

View reviewed changes

ewbankkit removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 12, 2021

Base automatically changed from master to main January 23, 2021 01:00

ewbankkit mentioned this pull request Mar 18, 2021

ARN attribute may contain incorrect AWS account ID for shareable resources #16978

Closed

12 tasks

Add CHANGELOG entry.

01dc4d5

ewbankkit approved these changes Aug 3, 2021

View reviewed changes

ewbankkit merged commit a3c59d2 into hashicorp:main Aug 3, 2021

github-actions bot added this to the v3.53.0 milestone Aug 3, 2021

github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PoolArn attribute support in Data Source: aws_ec2_coip_pool #17046

PoolArn attribute support in Data Source: aws_ec2_coip_pool #17046

sumitmenaria commented Jan 11, 2021

github-actions bot left a comment

ewbankkit commented Jan 11, 2021

ewbankkit left a comment •

edited

Loading

sumitmenaria commented Jan 20, 2021

FireballDWF commented Aug 3, 2021

ewbankkit left a comment

ewbankkit commented Aug 3, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Sep 5, 2021

PoolArn attribute support in Data Source: aws_ec2_coip_pool #17046

PoolArn attribute support in Data Source: aws_ec2_coip_pool #17046

Conversation

sumitmenaria commented Jan 11, 2021

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

ewbankkit commented Jan 11, 2021

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

sumitmenaria commented Jan 20, 2021

FireballDWF commented Aug 3, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Aug 3, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Sep 5, 2021

ewbankkit left a comment •

edited

Loading