-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resources & Data Sources: ElastiCache Redis - User #16629
New Resources & Data Sources: ElastiCache Redis - User #16629
Conversation
Still need to add a lot of functionality, but the foundation is there now from a testability perspecitve. |
I feel that this is ready for review. Please let me know if there is anything else we might need to go over. Thank you! |
Any movement with this? |
patiently waiting |
I've ended up hacking my own Cloudformation / CLI hack in the meanwhile. It's sadly meant we used a bunch of workarounds. If this needs some more tests or merge conflicts fixing to get it out, im happy to help. |
Any progress on this? |
@hashicorp/terraform-aws |
Could a maintainer rebase this? |
Sorry for the radio silence with this project. I will start working on it again during the evenings and should try to get something out shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheUser_ -timeout 180m
=== RUN TestAccAWSElasticacheUser_basic
=== PAUSE TestAccAWSElasticacheUser_basic
=== RUN TestAccAWSElasticacheUser_tags
=== PAUSE TestAccAWSElasticacheUser_tags
=== RUN TestAccAWSElasticacheUser_disappears
=== PAUSE TestAccAWSElasticacheUser_disappears
=== CONT TestAccAWSElasticacheUser_basic
=== CONT TestAccAWSElasticacheUser_disappears
=== CONT TestAccAWSElasticacheUser_tags
--- PASS: TestAccAWSElasticacheUser_disappears (14.71s)
--- PASS: TestAccAWSElasticacheUser_basic (17.78s)
--- PASS: TestAccAWSElasticacheUser_tags (40.13s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 40.196s
This functionality has been released in v3.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates to #16327
Blocks #16504
Release note for CHANGELOG:
Output from acceptance testing: