Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_registry - new resource #16418

Merged
merged 2 commits into from
Nov 26, 2020
Merged

r/glue_registry - new resource #16418

merged 2 commits into from
Nov 26, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16342
Release note for CHANGELOG:

resource_aws_glue_registry - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueRegistry_'
--- PASS: TestAccAWSGlueRegistry_disappears (29.99s)
--- PASS: TestAccAWSGlueRegistry_basic (41.39s)
--- PASS: TestAccAWSGlueRegistry_Description (72.98s)
--- PASS: TestAccAWSGlueRegistry_tags (103.72s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 24, 2020 21:36
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 24, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Nov 24, 2020
ewbankkit
ewbankkit reviewed Nov 25, 2020
View reviewed changes
aws/internal/service/glue/id.go
@@ -30,3 +32,9 @@ func stringifyAwsGluePartition(partValues *schema.Set) string {

return vals
}

func CreateAwsGlueRegistryID(id string) *glue.RegistryId {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. My understanding is that Create and Parse ID functions are meant to work on strings only, so this functionality can just be moved into finder.RegistryByID.

ewbankkit
ewbankkit approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueRegistry_ -timeout 120m
=== RUN   TestAccAWSGlueRegistry_basic
=== PAUSE TestAccAWSGlueRegistry_basic
=== RUN   TestAccAWSGlueRegistry_Description
=== PAUSE TestAccAWSGlueRegistry_Description
=== RUN   TestAccAWSGlueRegistry_tags
=== PAUSE TestAccAWSGlueRegistry_tags
=== RUN   TestAccAWSGlueRegistry_disappears
=== PAUSE TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_basic
=== CONT  TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_tags
=== CONT  TestAccAWSGlueRegistry_Description
--- PASS: TestAccAWSGlueRegistry_disappears (13.39s)
--- PASS: TestAccAWSGlueRegistry_basic (19.79s)
--- PASS: TestAccAWSGlueRegistry_Description (32.31s)
--- PASS: TestAccAWSGlueRegistry_tags (43.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.579s

@DrFaust92 @ewbankkit
Update website/docs/r/glue_registry.html.markdown
1bab884 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2).

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueRegistry_ -timeout 120m
=== RUN   TestAccAWSGlueRegistry_basic
=== PAUSE TestAccAWSGlueRegistry_basic
=== RUN   TestAccAWSGlueRegistry_Description
=== PAUSE TestAccAWSGlueRegistry_Description
=== RUN   TestAccAWSGlueRegistry_tags
=== PAUSE TestAccAWSGlueRegistry_tags
=== RUN   TestAccAWSGlueRegistry_disappears
=== PAUSE TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_basic
=== CONT  TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_tags
=== CONT  TestAccAWSGlueRegistry_Description
--- PASS: TestAccAWSGlueRegistry_disappears (11.29s)
--- PASS: TestAccAWSGlueRegistry_basic (15.10s)
--- PASS: TestAccAWSGlueRegistry_Description (25.43s)
--- PASS: TestAccAWSGlueRegistry_tags (35.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.355s

Verified Acceptance Tests in GovCloud (us-gov-west-1) (Registries appear not to be supported in GovCloud)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueRegistry_ -timeout 120m
=== RUN   TestAccAWSGlueRegistry_basic
=== PAUSE TestAccAWSGlueRegistry_basic
=== RUN   TestAccAWSGlueRegistry_Description
=== PAUSE TestAccAWSGlueRegistry_Description
=== RUN   TestAccAWSGlueRegistry_tags
=== PAUSE TestAccAWSGlueRegistry_tags
=== RUN   TestAccAWSGlueRegistry_disappears
=== PAUSE TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_basic
=== CONT  TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_Description
=== CONT  TestAccAWSGlueRegistry_tags
=== CONT  TestAccAWSGlueRegistry_disappears
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_disappears (0.99s)
=== CONT  TestAccAWSGlueRegistry_tags
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_tags (0.99s)
=== CONT  TestAccAWSGlueRegistry_basic
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_basic (1.00s)
=== CONT  TestAccAWSGlueRegistry_Description
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_Description (1.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.595s

@breathingdust breathingdust added this to the v3.19.0 milestone Nov 26, 2020
@breathingdust breathingdust merged commit 5f947c0 into hashicorp:master Nov 26, 2020
breathingdust added a commit that referenced this pull request Nov 26, 2020
@breathingdust
Update CHANGELOG.md for #16418
65cbd23
@ghost
Copy link

ghost commented Dec 1, 2020

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 27, 2020
@DrFaust92 DrFaust92 deleted the r/glue_registry branch April 15, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @breathingdust @ewbankkit