-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: Followup items from initial Code Signing release #16412
Conversation
Reference: #16383 (review) Reference: #16384 (review) Reference: #16398 Changes: ``` * data-source/aws_lambda_function: Prevent Lambda GetFunctionCodeSigningConfig API call error outside AWS Commercial regions * resource/aws_lambda_function: Prevent Lambda GetFunctionCodeSigningConfig API call error outside AWS Commercial regions ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSLambdaFunction_basic (660.06s) --- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1207.31s) --- PASS: TestAccAWSLambdaFunction_concurrency (1032.30s) --- PASS: TestAccAWSLambdaFunction_concurrencyCycle (1057.54s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (132.39s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (138.81s) --- PASS: TestAccAWSLambdaFunction_disablePublish (88.73s) --- PASS: TestAccAWSLambdaFunction_disappears (1220.09s) --- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (86.77s) --- PASS: TestAccAWSLambdaFunction_enablePublish (129.99s) --- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (145.89s) --- PASS: TestAccAWSLambdaFunction_envVariables (718.17s) --- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (14.86s) --- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (1370.29s) --- PASS: TestAccAWSLambdaFunction_Layers (1016.49s) --- PASS: TestAccAWSLambdaFunction_LayersUpdate (160.26s) --- PASS: TestAccAWSLambdaFunction_localUpdate (505.56s) --- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (503.80s) --- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (48.16s) --- PASS: TestAccAWSLambdaFunction_runtimes (1695.07s) --- PASS: TestAccAWSLambdaFunction_s3 (40.08s) --- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.03s) --- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (64.88s) --- PASS: TestAccAWSLambdaFunction_tags (1238.40s) --- PASS: TestAccAWSLambdaFunction_tracingConfig (89.38s) --- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (737.76s) --- PASS: TestAccAWSLambdaFunction_versioned (101.60s) --- PASS: TestAccAWSLambdaFunction_versionedUpdate (1113.10s) --- PASS: TestAccAWSLambdaFunction_VPC (1412.53s) --- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (989.01s) --- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (623.72s) --- PASS: TestAccAWSLambdaFunction_VPCRemoval (1977.57s) --- PASS: TestAccDataSourceAWSLambdaFunction_alias (1211.85s) --- PASS: TestAccDataSourceAWSLambdaFunction_basic (54.11s) --- PASS: TestAccDataSourceAWSLambdaFunction_environment (1182.31s) --- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (1941.83s) --- PASS: TestAccDataSourceAWSLambdaFunction_layers (1106.50s) --- PASS: TestAccDataSourceAWSLambdaFunction_version (966.75s) --- PASS: TestAccDataSourceAWSLambdaFunction_vpc (1697.94s) --- PASS: TestAccAWSSignerSigningJob_basic (35.73s) --- PASS: TestAccAWSSignerSigningProfile_basic (18.48s) --- PASS: TestAccAWSSignerSigningProfile_GenerateName (18.16s) --- PASS: TestAccAWSSignerSigningProfile_GenerateNameWithNamePrefix (18.17s) --- PASS: TestAccAWSSignerSigningProfile_SignatureValidityPeriod (25.69s) --- PASS: TestAccAWSSignerSigningProfile_tags (30.83s) --- PASS: TestAccAWSSignerSigningProfilePermission_basic (23.93s) --- PASS: TestAccAWSSignerSigningProfilePermission_GetSigningProfile (39.86s) --- PASS: TestAccAWSSignerSigningProfilePermission_StartSigningJob_GetSP (25.33s) --- PASS: TestAccAWSSignerSigningProfilePermission_StatementPrefix (28.76s) --- PASS: TestAccDataSourceAWSSignerSigningJob_basic (30.06s) --- PASS: TestAccDataSourceAWSSignerSigningProfile_basic (12.39s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSLambdaFunction_basic (60.15s) --- PASS: TestAccAWSLambdaFunction_concurrency (86.67s) --- PASS: TestAccAWSLambdaFunction_concurrencyCycle (138.48s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (152.23s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (138.97s) --- PASS: TestAccAWSLambdaFunction_disablePublish (72.75s) --- PASS: TestAccAWSLambdaFunction_disappears (104.35s) --- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (918.89s) --- PASS: TestAccAWSLambdaFunction_enablePublish (111.27s) --- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (156.43s) --- PASS: TestAccAWSLambdaFunction_envVariables (168.64s) --- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (25.56s) --- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1546.53s) --- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (891.68s) --- PASS: TestAccAWSLambdaFunction_Layers (916.74s) --- PASS: TestAccAWSLambdaFunction_LayersUpdate (401.14s) --- PASS: TestAccAWSLambdaFunction_localUpdate (1074.54s) --- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (1062.94s) --- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (888.61s) --- PASS: TestAccAWSLambdaFunction_runtimes (1187.08s) --- PASS: TestAccAWSLambdaFunction_s3 (35.88s) --- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.64s) --- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (62.12s) --- PASS: TestAccAWSLambdaFunction_tags (859.06s) --- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (541.36s) --- PASS: TestAccAWSLambdaFunction_versioned (148.92s) --- PASS: TestAccAWSLambdaFunction_versionedUpdate (692.93s) --- PASS: TestAccAWSLambdaFunction_VPC (1181.39s) --- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (703.33s) --- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (455.69s) --- PASS: TestAccAWSLambdaFunction_VPCRemoval (994.78s) --- PASS: TestAccAWSLambdaFunction_VPCUpdate (1224.48s) --- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (2.22s) --- SKIP: TestAccAWSSignerSigningJob_basic (7.57s) --- SKIP: TestAccAWSSignerSigningProfile_basic (7.52s) --- SKIP: TestAccAWSSignerSigningProfile_GenerateName (7.44s) --- SKIP: TestAccAWSSignerSigningProfile_GenerateNameWithNamePrefix (1.85s) --- SKIP: TestAccAWSSignerSigningProfile_SignatureValidityPeriod (7.35s) --- SKIP: TestAccAWSSignerSigningProfile_tags (7.87s) --- SKIP: TestAccAWSSignerSigningProfilePermission_basic (7.66s) --- SKIP: TestAccAWSSignerSigningProfilePermission_GetSigningProfile (7.65s) --- SKIP: TestAccAWSSignerSigningProfilePermission_StartSigningJob_GetSP (1.84s) --- SKIP: TestAccAWSSignerSigningProfilePermission_StatementPrefix (1.86s) --- PASS: TestAccDataSourceAWSLambdaFunction_alias (42.58s) --- PASS: TestAccDataSourceAWSLambdaFunction_basic (34.49s) --- PASS: TestAccDataSourceAWSLambdaFunction_environment (113.95s) --- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (961.20s) --- PASS: TestAccDataSourceAWSLambdaFunction_layers (136.12s) --- PASS: TestAccDataSourceAWSLambdaFunction_version (248.84s) --- PASS: TestAccDataSourceAWSLambdaFunction_vpc (598.98s) --- SKIP: TestAccDataSourceAWSSignerSigningJob_basic (7.44s) --- SKIP: TestAccDataSourceAWSSignerSigningProfile_basic (7.37s) ```
Created katbyte/terrafmt#37, will just remove |
Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccDataSourceAWSSignerSigningJob_basic (29.41s) --- PASS: TestAccAWSSignerSigningJob_basic (31.16s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccDataSourceAWSSignerSigningJob_basic (2.08s) --- SKIP: TestAccAWSSignerSigningJob_basic (2.09s) ```
After fixing Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):
|
This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Reference: #16383 (review)
Reference: #16384 (review)
Closes #16398
Release note for CHANGELOG:
Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):