Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_rds_global_cluster: Prevent recreation when using encrypted source_db_cluster_identifier without storage_encrypted #15916

Merged
merged 1 commit into from
Oct 29, 2020
Merged

resource/aws_rds_global_cluster: Prevent recreation when using encrypted source_db_cluster_identifier without storage_encrypted #15916

merged 1 commit into from
Oct 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 29, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15177

Release note for CHANGELOG:

* resource/aws_rds_global_cluster: Prevent recreation when using encrypted `source_db_cluster_identifier` without `storage_encrypted`

Output from acceptance testing:

--- PASS: TestAccAWSRdsGlobalCluster_basic (25.00s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (35.93s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (35.59s)
--- PASS: TestAccAWSRdsGlobalCluster_disappears (19.24s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (25.19s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (25.11s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (25.27s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (23.12s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier (129.42s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (128.96s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (37.43s)

@bflad
resource/aws_rds_global_cluster: Prevent recreation when using encryp…
e45118c 
…ted source_db_cluster_identifier without storage_encrypted

Reference: #15177

Output from acceptance testing:

```
--- PASS: TestAccAWSRdsGlobalCluster_basic (25.00s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (35.93s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (35.59s)
--- PASS: TestAccAWSRdsGlobalCluster_disappears (19.24s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (25.19s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (25.11s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (25.27s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (23.12s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier (129.42s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (128.96s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (37.43s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Oct 29, 2020
@bflad bflad requested a review from a team October 29, 2020 18:25
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 29, 2020
anGie44
anGie44 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 👍

@bflad bflad added this to the v3.13.0 milestone Oct 29, 2020
@bflad bflad merged commit e65f867 into master Oct 29, 2020
@bflad bflad deleted the b-aws_rds_global_cluster-storage_encrypted branch October 29, 2020 19:38
bflad added a commit that referenced this pull request Oct 29, 2020
@bflad
Update CHANGELOG for #15916
21efd86
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

Subsequent plan/apply forces global cluster recreation when source cluster's storage_encrypted=true
2 participants
@bflad @anGie44