aws_ec2_fleet: support in-place update of launch template config #15387
Conversation
ghost
added
size/S
github-actions
bot
added
the
needs-triage
|
Any chance of this getting a look anytime soon? I know there's quite a backlog of PRs, but I see quite a few things being merged most days and this one is fairly minimal as far as resource changes go. My team has had to do do this kind of modification pretty often the last couple of months, and it's a bit difficult to manage a custom build of an official provider across multiple users and modules. |
|
Hopefully a check-in after three months isn't too much noise. Managing a custom version of the provider, especially rebuilding to keep up with upstream changes, continues to cause us pain in using Terraform in production. Any chance someone could look at this change? Is there any more information I need to provide? |
|
Have been following this PR for a while, any progress in the review? Thanks @bflad @ewbankkit @gdavison @YakDriver @anGie44 @breathingdust |
breathingdust
added
enhancement
|
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
github-actions
bot
added
size/M
There was a problem hiding this comment.
Looks great! Thank you for your contribution and patience. 🎉
Output from acceptance tests (us-west-2):
% make testacc TESTS=TestAccEC2Fleet PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Fleet' -timeout 180m
--- SKIP: TestAccEC2Fleet_LaunchTemplateOverride_maxPrice (0.00s)
--- PASS: TestAccEC2Fleet_SpotOptions_capacityRebalance (51.39s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_spot (52.17s)
--- PASS: TestAccEC2Fleet_basic (53.58s)
--- PASS: TestAccEC2Fleet_type (54.25s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_onDemand (54.62s)
--- PASS: TestAccEC2Fleet_SpotOptions_allocationStrategy (89.74s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_defaultTargetCapacityType (89.94s)
--- PASS: TestAccEC2Fleet_terminateInstancesWithExpiration (94.04s)
--- PASS: TestAccEC2Fleet_replaceUnhealthyInstances (94.25s)
--- PASS: TestAccEC2Fleet_SpotOptions_instancePoolsToUseCount (94.28s)
--- PASS: TestAccEC2Fleet_SpotOptions_instanceInterruptionBehavior (94.67s)
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateName (101.54s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_availabilityZone (101.95s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_weightedCapacity (102.24s)
--- PASS: TestAccEC2Fleet_tags (103.81s)
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_version (104.81s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceType (109.85s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_subnetID (111.31s)
--- PASS: TestAccEC2Fleet_disappears (41.67s)
--- PASS: TestAccEC2Fleet_OnDemandOptions_allocationStrategy (84.26s)
--- PASS: TestAccEC2Fleet_excessCapacityTerminationPolicy (105.91s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverridePriority_multiple (106.70s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_priority (104.65s)
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateID (107.87s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverrideWeightedCapacity_multiple (102.65s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_totalTargetCapacity (473.62s)
--- PASS: TestAccEC2Fleet_templateMultipleNetworkInterfaces (554.46s)Output from acceptance tests (GovCloud):
% make testacc TESTS=TestAccEC2Fleet PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Fleet' -timeout 180m
--- SKIP: TestAccEC2Fleet_LaunchTemplateOverride_maxPrice (0.00s)
--- PASS: TestAccEC2Fleet_SpotOptions_capacityRebalance (62.51s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_onDemand (62.59s)
--- PASS: TestAccEC2Fleet_type (62.59s)
--- PASS: TestAccEC2Fleet_basic (62.66s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_defaultTargetCapacityType (96.38s)
--- PASS: TestAccEC2Fleet_replaceUnhealthyInstances (104.87s)
--- PASS: TestAccEC2Fleet_terminateInstancesWithExpiration (104.93s)
--- PASS: TestAccEC2Fleet_SpotOptions_instancePoolsToUseCount (105.07s)
--- PASS: TestAccEC2Fleet_SpotOptions_allocationStrategy (105.12s)
--- PASS: TestAccEC2Fleet_OnDemandOptions_allocationStrategy (105.12s)
--- PASS: TestAccEC2Fleet_SpotOptions_instanceInterruptionBehavior (105.12s)
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateName (108.33s)
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateID (113.88s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverrideWeightedCapacity_multiple (114.31s)
--- PASS: TestAccEC2Fleet_excessCapacityTerminationPolicy (114.48s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceType (114.54s)
--- PASS: TestAccEC2Fleet_tags (114.54s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_weightedCapacity (114.56s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_subnetID (119.48s)
--- PASS: TestAccEC2Fleet_disappears (40.59s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_spot (43.68s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_priority (105.16s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverridePriority_multiple (105.45s)
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_availabilityZone (105.38s)
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_version (106.48s)
--- PASS: TestAccEC2Fleet_templateMultipleNetworkInterfaces (552.20s)
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_totalTargetCapacity (470.54s)
|
This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #14946
Release note for CHANGELOG:
Output from acceptance testing: