Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_redshift_cluster: Increase default Update timeout to 75 minutes and remove arbitrary lower create timeout in testing #15339

Merged
merged 1 commit into from
Sep 30, 2020
Merged

resource/aws_redshift_cluster: Increase default Update timeout to 75 minutes and remove arbitrary lower create timeout in testing #15339

merged 1 commit into from
Sep 30, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 24, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14754

Release note for CHANGELOG:

* resource/aws_redshift_cluster: Increase default update timeout to 75 minutes

Previously (inconsistently):

=== CONT  TestAccAWSRedshiftCluster_basic
TestAccAWSRedshiftCluster_basic: resource_aws_redshift_cluster_test.go:69: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_changeEncryption1
TestAccAWSRedshiftCluster_changeEncryption1: resource_aws_redshift_cluster_test.go:526: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeCount: resource_aws_redshift_cluster_test.go:353: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeType
TestAccAWSRedshiftCluster_updateNodeType: resource_aws_redshift_cluster_test.go:390: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeCount: resource_aws_redshift_cluster_test.go:353: Step 2/2 error: terraform failed: exit status 1
stderr:
Error: Error Modifying Redshift Cluster (tf-redshift-cluster-7778138192916979662): timeout while waiting for state to become 'available' (last state: 'resizing', timeout: 40m0s)

The 75 minute update timeout value is chosen to match the create timeout value.

Output from acceptance testing:

--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (373.42s)
--- PASS: TestAccAWSRedshiftCluster_basic (789.01s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (792.82s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (960.36s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (1111.85s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1275.44s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1290.59s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (1320.91s)
--- PASS: TestAccAWSRedshiftCluster_tags (1501.17s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1502.53s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1512.02s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2246.61s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2506.37s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3070.55s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3251.04s)

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 24, 2020
@bflad
resource/aws_redshift_cluster: Increase default Update timeout to 75 …
3af7574 
…minutes and remove arbitrary lower create timeout in testing

Reference: #14754

Previously (inconsistently):

```
=== CONT  TestAccAWSRedshiftCluster_basic
TestAccAWSRedshiftCluster_basic: resource_aws_redshift_cluster_test.go:69: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_changeEncryption1
TestAccAWSRedshiftCluster_changeEncryption1: resource_aws_redshift_cluster_test.go:526: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeCount: resource_aws_redshift_cluster_test.go:353: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeType
TestAccAWSRedshiftCluster_updateNodeType: resource_aws_redshift_cluster_test.go:390: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeCount: resource_aws_redshift_cluster_test.go:353: Step 2/2 error: terraform failed: exit status 1
stderr:
Error: Error Modifying Redshift Cluster (tf-redshift-cluster-7778138192916979662): timeout while waiting for state to become 'available' (last state: 'resizing', timeout: 40m0s)
```

The 75 minute update timeout value is chosen to match the create timeout value.

Output from acceptance testing:

```
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (373.42s)
--- PASS: TestAccAWSRedshiftCluster_basic (789.01s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (792.82s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (960.36s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (1111.85s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1275.44s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1290.59s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (1320.91s)
--- PASS: TestAccAWSRedshiftCluster_tags (1501.17s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1502.53s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1512.02s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2246.61s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2506.37s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3070.55s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3251.04s)
```
@bflad bflad force-pushed the b-aws_redshift_cluster-timeouts branch from 9391841 to 3af7574 Compare September 25, 2020 16:21
@bflad bflad marked this pull request as ready for review September 25, 2020 16:22
@bflad bflad requested a review from a team September 25, 2020 16:22
anGie44
anGie44 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v3.9.0 milestone Sep 30, 2020
@bflad bflad added the bug Addresses a defect in current functionality. label Sep 30, 2020
@bflad bflad merged commit c560893 into master Sep 30, 2020
@bflad bflad deleted the b-aws_redshift_cluster-timeouts branch September 30, 2020 16:16
bflad added a commit that referenced this pull request Sep 30, 2020
@bflad
Update CHANGELOG for #15339
c7c4ea1
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

resource/aws_redshift_cluster: Increase Default Create Timeout
2 participants
@bflad @anGie44