Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f/Support ApplyOnlyAtCronInterval for aws_ssm_association #15038

Merged
merged 2 commits into from
Feb 12, 2021
Merged

f/Support ApplyOnlyAtCronInterval for aws_ssm_association #15038

merged 2 commits into from
Feb 12, 2021

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Sep 4, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15034

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMAssociation_withScheduleExpressionAndCronInterval'
--- PASS: TestAccAWSSSMAssociation_withScheduleExpressionAndCronInterval (124.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       124.613s
...

@nikhil-goenka nikhil-goenka requested a review from a team September 4, 2020 21:50
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. labels Sep 4, 2020
@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Sep 5, 2020
@nikhil-goenka nikhil-goenka changed the title Support ApplyOnlyAtCronInterval for aws_ssm_association f/Support ApplyOnlyAtCronInterval for aws_ssm_association Sep 12, 2020
@nikhil-goenka nikhil-goenka marked this pull request as draft September 16, 2020 15:24
@nikhil-goenka nikhil-goenka marked this pull request as ready for review September 18, 2020 17:35
@marcus-bcl
Copy link

Is there any word on this getting merged? We're currently waiting for it as we need to apply a bunch of aws_ssm_association resources but don't want them all immediately firing when we do.

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2021
@bflad bflad self-assigned this Feb 12, 2021
bflad
bflad approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After splitting out the tests, looks good, thank you @nikhil-goenka 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (26.48s)
--- PASS: TestAccAWSSSMAssociation_rateControl (36.32s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (39.12s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (39.44s)
--- PASS: TestAccAWSSSMAssociation_withParameters (41.73s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (41.97s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (49.30s)
--- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (53.28s)
--- PASS: TestAccAWSSSMAssociation_withTargets (57.36s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (57.49s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.00s)
--- PASS: TestAccAWSSSMAssociation_basic (98.52s)
--- PASS: TestAccAWSSSMAssociation_disappears (116.82s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (38.37s)
--- PASS: TestAccAWSSSMAssociation_withParameters (49.05s)
--- PASS: TestAccAWSSSMAssociation_rateControl (49.73s)
--- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (52.95s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (52.95s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (56.16s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (63.14s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (63.99s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (64.88s)
--- PASS: TestAccAWSSSMAssociation_withTargets (71.86s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.33s)
--- PASS: TestAccAWSSSMAssociation_basic (112.52s)
--- PASS: TestAccAWSSSMAssociation_disappears (119.66s)

aws/resource_aws_ssm_association_test.go
@@ -958,6 +958,7 @@ DOC
resource "aws_ssm_association" "test" {
name = aws_ssm_document.test.name
schedule_expression = "cron(0 16 ? * TUE *)"
apply_only_at_cron_interval = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure we are not introducing any regressions, going to split this new argument into its own testing on merge.

bflad added a commit that referenced this pull request Feb 12, 2021
@bflad
resource/aws_ssm_association: Finalize apply_only_at_cron_interval an…
c4779c6 
…d add CHANGELOG entry for #15038

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (26.48s)
--- PASS: TestAccAWSSSMAssociation_rateControl (36.32s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (39.12s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (39.44s)
--- PASS: TestAccAWSSSMAssociation_withParameters (41.73s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (41.97s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (49.30s)
--- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (53.28s)
--- PASS: TestAccAWSSSMAssociation_withTargets (57.36s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (57.49s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.00s)
--- PASS: TestAccAWSSSMAssociation_basic (98.52s)
--- PASS: TestAccAWSSSMAssociation_disappears (116.82s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (38.37s)
--- PASS: TestAccAWSSSMAssociation_withParameters (49.05s)
--- PASS: TestAccAWSSSMAssociation_rateControl (49.73s)
--- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (52.95s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (52.95s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (56.16s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (63.14s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (63.99s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (64.88s)
--- PASS: TestAccAWSSSMAssociation_withTargets (71.86s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.33s)
--- PASS: TestAccAWSSSMAssociation_basic (112.52s)
--- PASS: TestAccAWSSSMAssociation_disappears (119.66s)
```
@bflad bflad merged commit 9ea8d23 into hashicorp:main Feb 12, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 12, 2021
@nikhil-goenka nikhil-goenka deleted the aws_ssm_association branch February 12, 2021 05:45
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.

Add support for ApplyOnlyAtCronInterval to aws_ssm_association
3 participants
@nikhil-goenka @marcus-bcl @bflad